Index: openacs-4/packages/acs-subsite/tcl/attribute-procs-oracle.xql
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/tcl/attribute-procs-oracle.xql,v
diff -u -r1.3 -r1.3.30.1
--- openacs-4/packages/acs-subsite/tcl/attribute-procs-oracle.xql	11 Aug 2001 21:31:03 -0000	1.3
+++ openacs-4/packages/acs-subsite/tcl/attribute-procs-oracle.xql	27 Oct 2015 22:56:30 -0000	1.3.30.1
@@ -3,20 +3,6 @@
 <queryset>
    <rdbms><type>oracle</type><version>8.1.6</version></rdbms>
 
-<fullquery name="attribute_for_dynamic_object_p">      
-      <querytext>
-      
-	select case when exists (select 1 
-                                   from acs_attributes a, acs_object_types t
-                                  where t.dynamic_p = 't'
-                                    and a.object_type = t.object_type
-                                    and a.attribute_id = :value)
-	            then 1 else 0 end
-	  from dual
-    
-      </querytext>
-</fullquery>
-
  
 <fullquery name="exists_p.attr_exists_p">      
       <querytext>
Index: openacs-4/packages/acs-subsite/tcl/attribute-procs-postgresql.xql
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/tcl/attribute-procs-postgresql.xql,v
diff -u -r1.4 -r1.4.30.1
--- openacs-4/packages/acs-subsite/tcl/attribute-procs-postgresql.xql	4 Dec 2001 00:20:47 -0000	1.4
+++ openacs-4/packages/acs-subsite/tcl/attribute-procs-postgresql.xql	27 Oct 2015 22:56:30 -0000	1.4.30.1
@@ -3,21 +3,6 @@
 <queryset>
    <rdbms><type>postgresql</type><version>7.1</version></rdbms>
 
-<fullquery name="attribute_for_dynamic_object_p">      
-      <querytext>
-      
-	select case when exists (select 1 
-                                   from acs_attributes a, acs_object_types t
-                                  where t.dynamic_p = 't'
-                                    and a.object_type = t.object_type
-                                    and a.attribute_id = :value)
-	            then 1 else 0 end
-	  
-    
-      </querytext>
-</fullquery>
-
- 
 <fullquery name="attribute::exists_p.attr_exists_p">      
       <querytext>
       
Index: openacs-4/packages/acs-subsite/tcl/attribute-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/tcl/attribute-procs.tcl,v
diff -u -r1.12.2.1 -r1.12.2.2
--- openacs-4/packages/acs-subsite/tcl/attribute-procs.tcl	10 Sep 2015 08:21:35 -0000	1.12.2.1
+++ openacs-4/packages/acs-subsite/tcl/attribute-procs.tcl	27 Oct 2015 22:56:30 -0000	1.12.2.2
@@ -25,7 +25,7 @@
                                     and a.object_type = t.object_type
                                     and a.attribute_id = :value)
 	            then 1 else 0 end
-	  from dual
+	  from dual        
     }] } {
 	return 1
     }
Index: openacs-4/packages/acs-subsite/tcl/package-procs-oracle.xql
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/tcl/package-procs-oracle.xql,v
diff -u -r1.14 -r1.14.8.1
--- openacs-4/packages/acs-subsite/tcl/package-procs-oracle.xql	13 Sep 2009 23:54:41 -0000	1.14
+++ openacs-4/packages/acs-subsite/tcl/package-procs-oracle.xql	27 Oct 2015 22:56:30 -0000	1.14.8.1
@@ -3,20 +3,7 @@
 <queryset>
    <rdbms><type>oracle</type><version>8.1.6</version></rdbms>
 
-<fullquery name="package_type_dynamic_p.object_type_dynamic_p">      
-      <querytext>
-      
-	select case when exists (select 1 
-                                   from acs_object_types t
-                                  where t.dynamic_p = 't'
-                                    and t.object_type = :object_type)
-	            then 1 else 0 end
-	  from dual
-    
-      </querytext>
-</fullquery>
 
- 
 <fullquery name="package_create_attribute_list.select_all_attributes">      
       <querytext>
       
Index: openacs-4/packages/acs-subsite/tcl/package-procs-postgresql.xql
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/tcl/package-procs-postgresql.xql,v
diff -u -r1.20 -r1.20.2.1
--- openacs-4/packages/acs-subsite/tcl/package-procs-postgresql.xql	27 Oct 2014 16:39:46 -0000	1.20
+++ openacs-4/packages/acs-subsite/tcl/package-procs-postgresql.xql	27 Oct 2015 22:56:30 -0000	1.20.2.1
@@ -3,20 +3,6 @@
 <queryset>
    <rdbms><type>postgresql</type><version>7.1</version></rdbms>
 
-<fullquery name="package_type_dynamic_p.object_type_dynamic_p">      
-      <querytext>
-      
-	select case when exists (select 1 
-                                   from acs_object_types t
-                                  where t.dynamic_p = 't'
-                                    and t.object_type = :object_type)
-	            then 1 else 0 end
-	  
-    
-      </querytext>
-</fullquery>
-
- 
 <fullquery name="package_create_attribute_list.select_all_attributes">      
       <querytext>
 
Index: openacs-4/packages/acs-subsite/tcl/package-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/tcl/package-procs.tcl,v
diff -u -r1.26.2.1 -r1.26.2.2
--- openacs-4/packages/acs-subsite/tcl/package-procs.tcl	22 Aug 2015 10:09:06 -0000	1.26.2.1
+++ openacs-4/packages/acs-subsite/tcl/package-procs.tcl	27 Oct 2015 22:56:30 -0000	1.26.2.2
@@ -19,12 +19,12 @@
     @creation-date 12/30/2000
 } {
     return [db_string object_type_dynamic_p {
-        select case when exists (select 1
-                                 from acs_object_types t
-                                 where t.dynamic_p = 't'
-                                 and t.object_type = :object_type)
-        then 1 else 0 end
-        from dual
+        	select case when exists (select 1 
+                                   from acs_object_types t
+                                  where t.dynamic_p = 't'
+                                    and t.object_type = :object_type)
+	            then 1 else 0 end
+	  from dual
     }]
 }
 
@@ -326,15 +326,7 @@
         db_exec_plsql $stmt_name $code
 
         # Let's check to make sure the package is valid
-        if { ![db_string package_valid_p {
-            select case when exists (select 1
-                                     from user_objects
-                                     where status = 'INVALID'
-                                     and object_name = upper(:package_name)
-                                     and object_type = upper(:type))
-            then 0 else 1 end
-            from dual
-        }] } {
+        if { ![db_string package_valid_p {}] } {
             error "$object_type \"$package_name\" is not valid after compiling:\n\n$code\n\n"
         }
     }
Fisheye: Tag 1.1.30.1 refers to a dead (removed) revision in file `openacs-4/packages/acs-subsite/tcl/plsql-utility-procs-oracle.xql'.
Fisheye: No comparison available.  Pass `N' to diff?
Fisheye: Tag 1.1.30.1 refers to a dead (removed) revision in file `openacs-4/packages/acs-subsite/tcl/plsql-utility-procs-postgresql.xql'.
Fisheye: No comparison available.  Pass `N' to diff?
Index: openacs-4/packages/acs-subsite/tcl/plsql-utility-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/tcl/plsql-utility-procs.tcl,v
diff -u -r1.3.2.1 -r1.3.2.2
--- openacs-4/packages/acs-subsite/tcl/plsql-utility-procs.tcl	10 Sep 2015 08:21:36 -0000	1.3.2.1
+++ openacs-4/packages/acs-subsite/tcl/plsql-utility-procs.tcl	27 Oct 2015 22:56:30 -0000	1.3.2.2
@@ -55,8 +55,8 @@
                         then 1
                         else 0
                    end
-              from dual
-	}]
+              from dual            
+        }]
     }
 
 
Index: openacs-4/packages/acs-subsite/tcl/rel-types-procs-oracle.xql
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/tcl/rel-types-procs-oracle.xql,v
diff -u -r1.3 -r1.3.14.1
--- openacs-4/packages/acs-subsite/tcl/rel-types-procs-oracle.xql	4 Jun 2005 12:38:26 -0000	1.3
+++ openacs-4/packages/acs-subsite/tcl/rel-types-procs-oracle.xql	27 Oct 2015 22:56:30 -0000	1.3.14.1
@@ -3,19 +3,6 @@
 <queryset>
    <rdbms><type>oracle</type><version>8.1.6</version></rdbms>
 
-<fullquery name="rel_type_dynamic_p">      
-      <querytext>
-      
-	select case when exists (select 1 
-                                   from acs_object_types t
-                                  where t.dynamic_p = 't'
-                                    and t.object_type = :value)
-	            then 1 else 0 end
-	  from dual
-    
-      </querytext>
-</fullquery>
-
 <fullquery name="rel_types::new.drop_type">
 <querytext>
 begin acs_rel_type.drop_type(:rel_type); end;
Index: openacs-4/packages/acs-subsite/tcl/rel-types-procs-postgresql.xql
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/tcl/rel-types-procs-postgresql.xql,v
diff -u -r1.8 -r1.8.14.1
--- openacs-4/packages/acs-subsite/tcl/rel-types-procs-postgresql.xql	18 Nov 2005 10:40:01 -0000	1.8
+++ openacs-4/packages/acs-subsite/tcl/rel-types-procs-postgresql.xql	27 Oct 2015 22:56:30 -0000	1.8.14.1
@@ -3,20 +3,6 @@
 <queryset>
    <rdbms><type>postgresql</type><version>7.1</version></rdbms>
 
-<fullquery name="rel_type_dynamic_p">      
-      <querytext>
-      
-	select case when exists (select 1 
-                                   from acs_object_types t
-                                  where t.dynamic_p = 't'
-                                    and t.object_type = :value)
-	            then 1 else 0 end
-	  
-    
-      </querytext>
-</fullquery>
-
- 
 <fullquery name="rel_types::additional_rel_types_group_type_p.group_rel_type_exists">      
       <querytext>
 
Index: openacs-4/packages/acs-subsite/tcl/rel-types-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/tcl/rel-types-procs.tcl,v
diff -u -r1.11.2.1 -r1.11.2.2
--- openacs-4/packages/acs-subsite/tcl/rel-types-procs.tcl	10 Sep 2015 08:21:36 -0000	1.11.2.1
+++ openacs-4/packages/acs-subsite/tcl/rel-types-procs.tcl	27 Oct 2015 22:56:31 -0000	1.11.2.2
@@ -17,12 +17,13 @@
     @creation-date 12/30/2000
 } {
     if {[db_string rel_type_dynamic_p {
-	select case when exists (select 1
-				 from acs_object_types t
-				 where t.dynamic_p = 't'
-				 and t.object_type = :value)
-	then 1 else 0 end
-	from dual}]} {
+        	select case when exists (select 1 
+                                   from acs_object_types t
+                                  where t.dynamic_p = 't'
+                                    and t.object_type = :value)
+	            then 1 else 0 end
+	  from dual
+    }]} {
 	return 1
     }
     ad_complain "Specific rel type either does not exist or is not dynamic and thus cannot be modified"
Index: openacs-4/packages/acs-subsite/tcl/relation-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/tcl/relation-procs.tcl,v
diff -u -r1.16.2.1 -r1.16.2.2
--- openacs-4/packages/acs-subsite/tcl/relation-procs.tcl	10 Sep 2015 08:21:36 -0000	1.16.2.1
+++ openacs-4/packages/acs-subsite/tcl/relation-procs.tcl	27 Oct 2015 22:56:31 -0000	1.16.2.2
@@ -113,9 +113,7 @@
 	# JCD: this is enforced by trigger so no longer check explicitly
 	# see membership_rels_in_tr
 	# 
-	# set violated_err_msg [db_string select_rel_violation {
-	#    select rel_constraint.violation(:rel_id) from dual
-	# } -default ""]
+	# set violated_err_msg [db_string select_rel_violation {} -default ""]
 	#
 	# if { $violated_err_msg ne "" } {
 	#     error $violated_err_msg