Index: openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl,v diff -u -r1.79.2.38 -r1.79.2.39 --- openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl 7 Feb 2021 18:53:28 -0000 1.79.2.38 +++ openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl 14 Feb 2021 21:05:52 -0000 1.79.2.39 @@ -793,9 +793,6 @@ @author Peter Harper @creation-date 24 July 2001 } { - global aa_testcase_id - global aa_package_key - if {$affirm_actual eq $affirm_value} { aa_log_result "pass" [subst {[aa_indent] $affirm_name, actual = "$affirm_actual"}] return 1 Index: openacs-4/packages/acs-automated-testing/tcl/test/acs-automated-testing-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-automated-testing/tcl/test/acs-automated-testing-procs.tcl,v diff -u -r1.10.2.4 -r1.10.2.5 --- openacs-4/packages/acs-automated-testing/tcl/test/acs-automated-testing-procs.tcl 3 Sep 2019 08:44:16 -0000 1.10.2.4 +++ openacs-4/packages/acs-automated-testing/tcl/test/acs-automated-testing-procs.tcl 14 Feb 2021 21:05:52 -0000 1.10.2.5 @@ -8,10 +8,22 @@ aa_register_case \ -cats {api web} \ -procs { - acs::test::user::create + aa_equals + aa_false + aa_log + aa_register_case + aa_run_with_teardown + aa_section + aa_true + acs::test::confirm_email acs::test::http acs::test::login acs::test::logout + acs::test::reply_contains + acs::test::reply_contains_no + acs::test::reply_has_status_code + acs::test::user::create + acs::test::user::delete } \ webtest_example { @@ -48,6 +60,7 @@ acs::test::reply_contains $d [dict get $user_info last_name] aa_equals "login [dict get $d login]" [dict get $d login] via_login aa_true "cookies are not empty '[dict get $d session cookies]'" {[dict get $d session cookies] ne ""} + aa_false "cookies are not empty '[dict get $d session cookies]'" {[dict get $d session cookies] eq ""} ######################################################################################## aa_section "Make a second request, now the cookie should be used" @@ -76,7 +89,10 @@ aa_register_case \ -cats {api smoke production_safe} \ -procs { + aa_register_case aa::coverage::proc_coverage + aa_equals + aa_true } \ aa__coverage_proc_coverage { @@ -121,8 +137,11 @@ aa_register_case \ -cats {api smoke production_safe} \ -procs { + aa_register_case aa::coverage::proc_covered_p aa::coverage::proc_list + aa_equals + aa_true } \ aa__coverage_proc_proc_list_covered { @@ -151,7 +170,7 @@ set package_proc_list [aa::coverage::proc_list -package_key $package] foreach proc_info $package_proc_list { dict with proc_info { - aa_equals "package $package: dict size" "[dict size $proc_info]" "2" + aa_equals "package $package: dict size" [dict size $proc_info] "2" aa_true "package $package: proc_name not empty" {[dict get $proc_info proc_name] ne ""} aa_true "package $package proc $proc_name: covered_p is boolean" {[string is boolean [dict get $proc_info covered_p]]} aa_true "package $package proc $proc_name: covered_p and aa::coverage::proc_covered_p are coherent" { @@ -166,7 +185,9 @@ aa_register_case \ -cats {api smoke production_safe} \ -procs { + aa_register_case aa::coverage::proc_coverage_level + aa_equals } \ aa__coverage_proc_coverage_level { Index: openacs-4/packages/acs-automated-testing/www/admin/testcase.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-automated-testing/www/admin/testcase.tcl,v diff -u -r1.22.2.3 -r1.22.2.4 --- openacs-4/packages/acs-automated-testing/www/admin/testcase.tcl 2 Sep 2019 14:41:34 -0000 1.22.2.3 +++ openacs-4/packages/acs-automated-testing/www/admin/testcase.tcl 14 Feb 2021 21:05:52 -0000 1.22.2.4 @@ -5,7 +5,7 @@ package_key:token {showsource:boolean 0} {quiet:boolean 1} - {return_url ""} + {return_url:localurl ""} } -properties { title:onevalue context_bar:onevalue Index: openacs-4/packages/acs-subsite/tcl/test/acs-subsite-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-subsite/tcl/test/acs-subsite-procs.tcl,v diff -u -r1.12.2.17 -r1.12.2.18 --- openacs-4/packages/acs-subsite/tcl/test/acs-subsite-procs.tcl 1 Sep 2020 17:40:42 -0000 1.12.2.17 +++ openacs-4/packages/acs-subsite/tcl/test/acs-subsite-procs.tcl 14 Feb 2021 21:09:41 -0000 1.12.2.18 @@ -24,9 +24,10 @@ aa_register_case \ -procs { + _ group::delete group::new - _ + lang::message::unregister lang::util::convert_to_i18n } \ group_localization { @@ -77,6 +78,7 @@ aa_register_case \ -bugs {775} \ -procs { + aa_error group::delete group::new permission::grant @@ -108,9 +110,12 @@ aa_register_case \ -bugs {1144} \ -procs { + acs::test::user::create acs_user::delete application_group::group_id_from_package_id + auth::set_email_verified group::add_member + site_node::get_from_url } \ acs_subsite_expose_bug_1144 { Exposes Bug 1144. @@ -189,9 +194,10 @@ aa_register_case \ -cats smoke \ -procs { + acs::test::user::create group::add_member - group::member_p group::admin_p + group::member_p group::new relation_add } acs_subsite_check_composite_group { @@ -358,6 +364,8 @@ party::get export_vars acs_user::delete + acs::test::confirm_email + acs::test::user::create } acs_subsite_test_email_confirmation { Calls the mail confirmation page with a new user and checks that result is as expected Index: openacs-4/packages/acs-templating/tcl/test/spell-checker-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-templating/tcl/test/spell-checker-procs.tcl,v diff -u -r1.13 -r1.13.2.1 --- openacs-4/packages/acs-templating/tcl/test/spell-checker-procs.tcl 22 Jul 2018 11:37:20 -0000 1.13 +++ openacs-4/packages/acs-templating/tcl/test/spell-checker-procs.tcl 14 Feb 2021 21:09:41 -0000 1.13.2.1 @@ -11,6 +11,7 @@ -procs { parameter::get_from_package_key template::util::spellcheck::get_element_formtext + util_sets_equal_p } \ spellcheck__get_element_formtext { Test the spell-check proc that does the actual spell-checking. Index: openacs-4/packages/file-storage/tcl/test/file-storage-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/file-storage/tcl/test/file-storage-procs.tcl,v diff -u -r1.10.2.2 -r1.10.2.3 --- openacs-4/packages/file-storage/tcl/test/file-storage-procs.tcl 17 Apr 2019 11:00:16 -0000 1.10.2.2 +++ openacs-4/packages/file-storage/tcl/test/file-storage-procs.tcl 14 Feb 2021 21:09:41 -0000 1.10.2.3 @@ -11,6 +11,7 @@ -procs { file_storage::test::create_new_folder file_storage::test::delete_current_folder + acs::test::follow_link } \ fs_create_folder { @@ -67,6 +68,7 @@ file_storage::test::create_new_folder file_storage::test::edit_folder file_storage::test::delete_current_folder + acs::test::follow_link } \ fs_edit_folder { @@ -129,6 +131,7 @@ -cats {web smoke} \ -libraries tclwebtest \ -procs { + aa_display_result file_storage::twt::call_fs_page file_storage::twt::create_new_folder file_storage::twt::add_file_to_folder Index: openacs-4/packages/xotcl-core/tcl/test/xotcl-test-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xotcl-core/tcl/test/xotcl-test-procs.tcl,v diff -u -r1.1.2.12 -r1.1.2.13 --- openacs-4/packages/xotcl-core/tcl/test/xotcl-test-procs.tcl 7 Feb 2021 18:45:38 -0000 1.1.2.12 +++ openacs-4/packages/xotcl-core/tcl/test/xotcl-test-procs.tcl 14 Feb 2021 21:12:32 -0000 1.1.2.13 @@ -147,11 +147,15 @@ aa_register_case -cats { api smoke } -procs { + "::xo::db::Class proc exists_in_db" + "::xo::db::CrClass instproc get_instance_from_db" "::xo::db::CrClass proc get_instance_from_db" + "::xo::db::CrItem instproc delete" "::xo::db::CrItem instproc save" "::xo::db::CrItem instproc save_new" - "::xo::db::CrItem instproc delete" - "::xo::db::Class proc exists_in_db" + "::xo::db::DB-postgresql instproc 0or1row" + "::xo::db::DB-postgresql instproc 1row" + "::xo::db::DB-postgresql instproc get_value" } test_cr_items { Test basic ::xo::db::CrItem ORM features } { Index: openacs-4/packages/xowf/tcl/test/xowf-test-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowf/tcl/test/xowf-test-procs.tcl,v diff -u -r1.14.2.12 -r1.14.2.13 --- openacs-4/packages/xowf/tcl/test/xowf-test-procs.tcl 7 Feb 2021 18:47:57 -0000 1.14.2.12 +++ openacs-4/packages/xowf/tcl/test/xowf-test-procs.tcl 14 Feb 2021 21:14:24 -0000 1.14.2.13 @@ -16,10 +16,20 @@ } aa_register_case -init_classes {xowf_require_test_instance} -cats {web} -procs { + "::lang::system::locale" "::xo::Package instproc reply_to_user" "::xowf::Package instproc initialize" "::xowiki::Package instproc invoke" "::xowiki::require_parameter_page" + "::xowiki::test::create_form_page" + "::xowiki::test::edit_form_page" + "::xowiki::test::require_test_folder" + ::acs::test::form_get_fields + ::acs::test::form_reply + ::acs::test::get_form + ::acs::test::get_url_from_location + ::acs::test::xpath::get_form + ::acs::test::xpath::get_form_values } create_folder_with_page { Create a folder in an xowf instance with a form page and edit this @@ -95,6 +105,9 @@ } aa_register_case -init_classes {xowf_require_test_instance} -cats {web} -procs { + ::acs::test::form_get_fields + ::acs::test::form_set_fields + "::lang::system::locale" "::xo::Package instproc reply_to_user" "::xowf::Package instproc destroy" "::xowf::Package instproc initialize" @@ -110,8 +123,12 @@ "::xowf::WorkflowPage instproc wf_context" "::xowf::WorkflowPage instproc www-edit" "::xowf::WorkflowPage instproc www-view" - "::xowiki::Package instproc invoke" "::xowiki::FormPage instproc www-edit" + "::xowiki::Package instproc invoke" + "::xowiki::test::create_form" + "::xowiki::test::create_form_page" + "::xowiki::test::edit_form_page" + "::xowiki::test::require_test_folder" } create_workflow_with_instance { Create an xowf workflow and a instance in a folder. Index: openacs-4/packages/xowiki/tcl/test/api-test-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/test/api-test-procs.tcl,v diff -u -r1.1.2.4 -r1.1.2.5 --- openacs-4/packages/xowiki/tcl/test/api-test-procs.tcl 2 Nov 2019 15:46:40 -0000 1.1.2.4 +++ openacs-4/packages/xowiki/tcl/test/api-test-procs.tcl 14 Feb 2021 21:14:24 -0000 1.1.2.5 @@ -1,6 +1,7 @@ aa_register_case \ -cats {smoke production_safe} \ -procs { + "::acs::test::require_package_instance" "::xowiki::Package instproc normalize_path" } \ package_normalize_path { Index: openacs-4/packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl,v diff -u -r1.1.2.9 -r1.1.2.10 --- openacs-4/packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl 7 Feb 2021 18:46:56 -0000 1.1.2.9 +++ openacs-4/packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl 14 Feb 2021 21:14:24 -0000 1.1.2.10 @@ -9,30 +9,43 @@ aa_register_case \ -cats {api smoke} \ -procs { - "::xowiki::Package instproc make_link" - "::xowiki::Package instproc resolve_page" - lang::system::get_locales + "::xo::ConnectionContext instproc form_parameter" + "::xo::ConnectionContext instproc returnredirect" + "::xo::ConnectionContext instproc user_id" + "::xo::Package instproc require_root_folder" + "::xo::PackageMgr instproc initialize" + "::xo::at_cleanup" "::xo::db::CrClass instproc get_instance_from_db" + "::xo::db::DB-postgresql instproc 0or1row" + "::xo::db::DB-postgresql instproc dml" + "::xo::db::DB-postgresql instproc get_value" + "::xo::db::DB-postgresql instproc list" + "::xowiki::FormPage instproc is_folder_page" + "::xowiki::FormPage instproc property" + "::xowiki::FormPage proc filter_expression" "::xowiki::Package instproc external_name" "::xowiki::Package instproc item_ref" + "::xowiki::Package instproc make_link" + "::xowiki::Package instproc resolve_page" + "::xowiki::Page instproc is_folder_page" + "::xowiki::Page instproc pretty_link" + "::xowiki::Page instproc render" + "::xowiki::Page instproc www-create-new" "::xowiki::Page instproc www-delete" "::xowiki::Page instproc www-edit" "::xowiki::Page instproc www-revisions" "::xowiki::Page instproc www-view" - "::xowiki::Page instproc www-create-new" - "::xo::Package instproc require_root_folder" - "::xo::PackageMgr instproc initialize" - "::xowiki::Page instproc pretty_link" - "::xowiki::Page instproc render" - "::xowiki::Page instproc is_folder_page" - "::xowiki::FormPage instproc is_folder_page" - "xowiki::FormPage instproc property" - site_node::exists_p - site_node::unmount + "::xowiki::locales" + "::xowiki::test::require_folder" + "::xowiki::test::require_link" + "::xowiki::test::require_page" + lang::system::get_locales site_node::delete + site_node::exists_p site_node::get - site_node::instantiate_and_mount site_node::get_from_url + site_node::instantiate_and_mount + site_node::unmount } \ xowiki_test_cases { XoWiki Test Cases Index: openacs-4/packages/xowiki/tcl/test/xowiki-link-test-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/test/xowiki-link-test-procs.tcl,v diff -u -r1.1.2.6 -r1.1.2.7 --- openacs-4/packages/xowiki/tcl/test/xowiki-link-test-procs.tcl 26 Aug 2020 18:35:00 -0000 1.1.2.6 +++ openacs-4/packages/xowiki/tcl/test/xowiki-link-test-procs.tcl 14 Feb 2021 21:14:24 -0000 1.1.2.7 @@ -3,7 +3,17 @@ aa_register_case \ -cats {smoke production_safe} \ -procs { + "::acs::test::dom_html" + "::acs::test::require_package_instance" + "::lang::system::locale" + "::lang::system::set_locale" + "::xo::PackageMgr instproc initialize" + "::xo::db::CrClass proc get_instance_from_db" + "::xo::parameter proc set_value" "::xowiki::Page instproc render" + "::xowiki::test::require_folder" + "::xowiki::test::require_link" + "::xowiki::test::require_page" } \ link_tests { Test links pointing to folders in different instances Index: openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl,v diff -u -r1.1.2.38 -r1.1.2.39 --- openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl 7 Feb 2021 18:46:56 -0000 1.1.2.38 +++ openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl 14 Feb 2021 21:14:24 -0000 1.1.2.39 @@ -20,9 +20,16 @@ aa_register_case \ -cats {smoke production_safe} \ -procs { - "::xowiki::Page instproc find_slot" - "::xo::db::CrItem instproc update_attribute_from_slot" + "::acs::test::require_package_instance" + "::lang::system::set_locale" + "::site_node::delete" + "::site_node::get_node_id" + "::site_node::unmount" "::xo::db::CrClass proc get_instance_from_db" + "::xo::db::CrItem instproc update_attribute_from_slot" + "::xowiki::Page instproc find_slot" + "::xowiki::test::require_folder" + "::xowiki::test::require_page" } \ slot_interactions { Test slot interactions @@ -113,13 +120,21 @@ aa_register_case \ -cats {smoke production_safe} \ -procs { + "::acs::test::require_package_instance" + "::lang::system::locale" + "::lang::system::set_locale" + "::site_node::delete" + "::site_node::get_node_id" + "::site_node::unmount" "::xo::db::CrClass proc get_instance_from_db" "::xo::db::CrClass proc lookup" "::xowiki::Package instproc item_info_from_url" "::xowiki::Package instproc item_ref" "::xowiki::Package instproc lookup" "::xowiki::Package instproc resolve_page" "::xowiki::Page instproc create_link" + "::xowiki::test::require_folder" + "::xowiki::test::require_page" } \ path_resolve { Test various forms of path resolving @@ -304,15 +319,30 @@ aa_register_case -cats {web} -procs { + "::acs::test::dom_html" + "::acs::test::http" + "::acs::test::reply_has_status_code" + "::acs::test::require_package_instance" + "::export_vars" + "::lang::system::locale" "::xo::Package instproc initialize" - "::xowiki::Package instproc invoke" "::xo::Package instproc reply_to_user" + "::xowiki::Package instproc invoke" + "::xowiki::Page instproc www-create-new" + "::xowiki::Page instproc www-edit" "::xowiki::test::create_form" "::xowiki::test::create_form_page" - "::xowiki::test::require_test_folder" "::xowiki::test::edit_form_page" - "::xowiki::Page instproc www-edit" - "::xowiki::Page instproc www-create-new" + "::xowiki::test::get_form_CSSclass" + "::xowiki::test::get_object_name" + "::xowiki::test::require_test_folder" + ::acs::test::form_get_fields + ::acs::test::form_reply + ::acs::test::form_set_fields + ::acs::test::get_form + ::acs::test::get_url_from_location + ::acs::test::xpath::get_form + ::acs::test::xpath::get_form_values } create_form_with_form_instance { Create an xowiki form and an instance of this form. Here we