Index: openacs-4/packages/dotlrn/tcl/community-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn/tcl/community-procs.tcl,v diff -u -r1.234.2.13 -r1.234.2.14 --- openacs-4/packages/dotlrn/tcl/community-procs.tcl 25 Nov 2020 14:35:27 -0000 1.234.2.13 +++ openacs-4/packages/dotlrn/tcl/community-procs.tcl 1 Feb 2021 11:04:50 -0000 1.234.2.14 @@ -326,14 +326,14 @@ dotlrn_community::set_site_template_id -community_id $community_id \ -site_template_id [parameter::get -package_id [dotlrn::get_package_id] -parameter "CommDefaultSiteTemplate_p"] - # This new community should _not_ inherit it's permissions - # from the root dotlrn instance. Why? All dotlrn users - # can read the root dotlrn instance, but only members of - # this community should be able to read this instance (and - # it's children) + # + # This new community should _not_ inherit its permissions from + # the root dotlrn instance. Why? All dotlrn users can read the + # root dotlrn instance, but only members of this community + # should be able to read this instance (and its children). + # permission::set_not_inherit -object_id $community_id - # Grant permission to dotlrn-admin group set dotlrn_admin_group_id [db_string group_id_from_name " @@ -1217,7 +1217,7 @@ } { Checks if the community_key passed in is valid for creating a new community by checking that the name does not contain - spaces and that it's not the same as an existing (possible) + spaces and that it is not the same as an existing (possible) sibling's name. @return dict with fields 'valid_p' and 'errmsg' @@ -1250,7 +1250,7 @@ } { Checks if the community_key passed in is valid for creating a new community by checking that the name does not contain - spaces and that it's not the same as an existing (possible) + spaces and that it is not the same as an existing (possible) sibling's name. @return boolean, or a complaint in the response if @@ -1836,7 +1836,9 @@ -community_key $key if {$term_id ne ""} { - # it's a class instance that we're cloning + # + # It is a class instance that we're cloning. + # ns_set put $extra_vars class_key [db_string get_class_key { select class_key from dotlrn_class_instances_full @@ -1966,11 +1968,11 @@ db_dml copy_customizations_if_any {} } - # This new community should _not_ inherit it's permissions + # This new community should _not_ inherit its permissions # from the root dotlrn instance. Why? All dotlrn users # can read the root dotlrn instance, but only members of # this community should be able to read this instance (and - # it's children) + # its children) permission::set_not_inherit -object_id $clone_id # Grant read_private_data permission to "non guest" users. Index: openacs-4/packages/dotlrn/www/community-edit-2.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn/www/community-edit-2.tcl,v diff -u -r1.23.2.2 -r1.23.2.3 --- openacs-4/packages/dotlrn/www/community-edit-2.tcl 3 Jul 2020 08:11:13 -0000 1.23.2.2 +++ openacs-4/packages/dotlrn/www/community-edit-2.tcl 1 Feb 2021 11:04:50 -0000 1.23.2.3 @@ -90,17 +90,17 @@ # We will store the image in the topmost root folder set parent_id [db_string get_root_folder {}] - # if this is a re-upload, pass along the item_id + # If this is a re-upload, pass along the item_id. set item_id [content::item::get_id_by_name -name $logo_name -parent_id $parent_id] - # if it's a new upload, create the item + # If it is a new upload, create the item. if { $item_id eq ""} { set item_id [content::item::new -name $logo_name -parent_id $parent_id -content_type image] - # since it's just the header logo, which can't be accessed outside of - # the community anyway, let everyone have access to see it. That way - # it won't cause any trouble later on when we try to implement - # try-before-you-buy for non-members. + # Since it is just the header logo, which can't be accessed + # outside of the community anyway, let everyone have access to + # see it. That way it won't cause any trouble later on when + # we try to implement try-before-you-buy for non-members. permission::grant -party_id [acs_magic_object registered_users] -object_id $item_id -privilege read } Index: openacs-4/packages/dotlrn/www/dotlrn-master-kelp.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn/www/dotlrn-master-kelp.tcl,v diff -u -r1.13.2.1 -r1.13.2.2 --- openacs-4/packages/dotlrn/www/dotlrn-master-kelp.tcl 27 Sep 2019 13:00:36 -0000 1.13.2.1 +++ openacs-4/packages/dotlrn/www/dotlrn-master-kelp.tcl 1 Feb 2021 11:04:50 -0000 1.13.2.2 @@ -21,7 +21,7 @@ Instructions: - 1. Put this file and it's .adp file into the server's /www directory. + 1. Put this file and its .adp file into the server's /www directory. That's the one with the "default-master" Tcl and adp files. You don't have to edit or remove the "default-master" files, since they will be ignored by the next step. Index: openacs-4/packages/dotlrn/www/dotlrn-master.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn/www/dotlrn-master.tcl,v diff -u -r1.49.2.1 -r1.49.2.2 --- openacs-4/packages/dotlrn/www/dotlrn-master.tcl 27 Sep 2019 13:02:23 -0000 1.49.2.1 +++ openacs-4/packages/dotlrn/www/dotlrn-master.tcl 1 Feb 2021 11:04:50 -0000 1.49.2.2 @@ -22,7 +22,7 @@ Instructions: - 1. Put this file and it's .adp file into the server's /www directory. + 1. Put this file and its .adp file into the server's /www directory. That's the one with the "default-master" Tcl and adp files. You don't have to edit or remove the "default-master" files, since they will be ignored by the next step. Index: openacs-4/packages/dotlrn/www/subcommunity-new.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/dotlrn/www/subcommunity-new.tcl,v diff -u -r1.29.2.1 -r1.29.2.2 --- openacs-4/packages/dotlrn/www/subcommunity-new.tcl 3 Jul 2020 08:11:13 -0000 1.29.2.1 +++ openacs-4/packages/dotlrn/www/subcommunity-new.tcl 1 Feb 2021 11:04:50 -0000 1.29.2.2 @@ -33,8 +33,9 @@ set context [list [list "one-community-admin" [_ dotlrn.Admin]] $title] set portal_id [dotlrn_community::get_portal_id -community_id $parent_community_id] -# set the join policy widget to default to -# the same as it's parent +# +# Set the join policy widget to default to the same as its parent. +# if {[dotlrn_community::open_p -community_id $parent_community_id]} { set join_policy_list [list [list [_ dotlrn.Open] open] [list [_ dotlrn.Closed] closed] [list [_ dotlrn.Needs_Approval] "needs approval"]] } elseif {[dotlrn_community::needs_approval_p -community_id $parent_community_id]} {