Index: openacs-4/packages/acs-tcl/tcl/deprecated-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/deprecated-procs.tcl,v diff -u -r1.29.2.12 -r1.29.2.13 --- openacs-4/packages/acs-tcl/tcl/deprecated-procs.tcl 23 May 2021 17:57:07 -0000 1.29.2.12 +++ openacs-4/packages/acs-tcl/tcl/deprecated-procs.tcl 28 Dec 2021 10:34:45 -0000 1.29.2.13 @@ -3882,6 +3882,26 @@ return [lsearch -index $sublist_element_pos $list_of_lists $query_string] } +ad_proc -deprecated util_list_to_ns_set { aList } { + Convert a list in the form "key value key value ..." into an ns_set. + + DEPRECATED: this proc can be replaced with a oneliner using list expansion. + + @see ns_set create ?name? ?key? ?value? ... + + @param aList The list to convert + + @return The id of a (non-persistent) ns_set +} { + # set setid [ns_set create] + # foreach {k v} $aList { + # ns_set put $setid $k $v + # } + + # return $setid + return [ns_set create s {*}$aList] +} + # Local variables: # mode: tcl # tcl-indent-level: 4 Index: openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl,v diff -u -r1.189.2.108 -r1.189.2.109 --- openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl 28 Dec 2021 09:18:10 -0000 1.189.2.108 +++ openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl 28 Dec 2021 10:34:45 -0000 1.189.2.109 @@ -2860,22 +2860,6 @@ return $result } - -ad_proc -public util_list_to_ns_set { aList } { - Convert a list in the form "key value key value ..." into an ns_set. - - @param aList The list to convert - - @return The id of a (non-persistent) ns_set -} { - set setid [ns_set create] - foreach {k v} $aList { - ns_set put $setid $k $v - } - - return $setid -} - ad_proc -public util_sets_equal_p { list1 list2 } { Tests whether each unique string in list1 occurs as many times in list1 as in list2 and vice versa (regardless of order). Index: openacs-4/packages/bulk-mail/tcl/bulk-mail-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/bulk-mail/tcl/bulk-mail-procs.tcl,v diff -u -r1.18.2.6 -r1.18.2.7 --- openacs-4/packages/bulk-mail/tcl/bulk-mail-procs.tcl 23 Feb 2021 16:05:35 -0000 1.18.2.6 +++ openacs-4/packages/bulk-mail/tcl/bulk-mail-procs.tcl 28 Dec 2021 10:34:45 -0000 1.18.2.7 @@ -268,7 +268,7 @@ # Comment: I have to ask Caroline or Andrew if itis ok to # change bulk-mail datamodel to accommodate message_type. - set extra_headers [util_list_to_ns_set [ns_set get $bulk_mail extra_headers]] + set extra_headers [ns_set create s {*}[ns_set get $bulk_mail extra_headers]] set message_type [ns_set get $extra_headers bulk-mail-type] # don't need this anymore and don't want to send it along