Index: openacs-4/contrib/packages/project-manager/project-manager.info =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/Attic/project-manager.info,v diff -u -r1.16.2.34 -r1.16.2.35 --- openacs-4/contrib/packages/project-manager/project-manager.info 25 Apr 2005 21:14:30 -0000 1.16.2.34 +++ openacs-4/contrib/packages/project-manager/project-manager.info 29 Apr 2005 17:02:30 -0000 1.16.2.35 @@ -7,21 +7,20 @@ f f - + Jade Rubick Project management tool for OpenACS 2005-01-13 Integrated Bakery Resources Track tasks, estimates and actual progress for a project. See the <a href="http://openacs.org/projects/dotwrk/project_management/">project page</a> for more information. - + - - + Index: openacs-4/contrib/packages/project-manager/tcl/task-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/tcl/Attic/task-procs.tcl,v diff -u -r1.4.2.38 -r1.4.2.39 --- openacs-4/contrib/packages/project-manager/tcl/task-procs.tcl 29 Mar 2005 10:37:18 -0000 1.4.2.38 +++ openacs-4/contrib/packages/project-manager/tcl/task-procs.tcl 29 Apr 2005 17:02:31 -0000 1.4.2.39 @@ -799,12 +799,8 @@ ad_proc -public pm::task::get_url { object_id } { - - set package_id [db_string pm_package_id "select package_id from cr_folders cf, cr_items ci1, cr_items ci2 where cf.folder_id = ci1.parent_id and ci1.item_id = ci2.parent_id and ci2.item_id = :object_id"] + set url [pm::util::url] - set url "[ad_url]" - append url [site_node::get_url_from_object_id -object_id $package_id] - set package_url "${url}task-one?task_id=$object_id" return $package_url Index: openacs-4/contrib/packages/project-manager/www/add-edit-2.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/add-edit-2.tcl,v diff -u -r1.4.2.2 -r1.4.2.3 --- openacs-4/contrib/packages/project-manager/www/add-edit-2.tcl 2 Jul 2004 23:13:49 -0000 1.4.2.2 +++ openacs-4/contrib/packages/project-manager/www/add-edit-2.tcl 29 Apr 2005 17:02:31 -0000 1.4.2.3 @@ -39,7 +39,7 @@ # the unique identifier for this package set package_id [ad_conn package_id] set subsite_id [ad_conn subsite_id] -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] set user_group_id [application_group::group_id_from_package_id \ -package_id $subsite_id] Index: openacs-4/contrib/packages/project-manager/www/add-edit.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/add-edit.tcl,v diff -u -r1.16.2.5 -r1.16.2.6 --- openacs-4/contrib/packages/project-manager/www/add-edit.tcl 16 Dec 2004 16:22:53 -0000 1.16.2.5 +++ openacs-4/contrib/packages/project-manager/www/add-edit.tcl 29 Apr 2005 17:02:31 -0000 1.16.2.6 @@ -36,7 +36,7 @@ # --------------------------------------------------------------- # # the unique identifier for this package set package_id [ad_conn package_id] -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] # terminology set project_term [parameter::get -parameter "ProjectName" -default "Project"] Index: openacs-4/contrib/packages/project-manager/www/calendar-users-update.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/calendar-users-update.tcl,v diff -u -r1.1.2.1 -r1.1.2.2 --- openacs-4/contrib/packages/project-manager/www/calendar-users-update.tcl 15 Sep 2004 23:07:39 -0000 1.1.2.1 +++ openacs-4/contrib/packages/project-manager/www/calendar-users-update.tcl 29 Apr 2005 17:02:31 -0000 1.1.2.2 @@ -15,9 +15,9 @@ } -errors { } -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] -if {[empty_string_p party_id]} { +if {[empty_string_p $party_id]} { set party_id [list $user_id] } Index: openacs-4/contrib/packages/project-manager/www/index.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/index.tcl,v diff -u -r1.13.2.10 -r1.13.2.11 --- openacs-4/contrib/packages/project-manager/www/index.tcl 21 Dec 2004 02:02:39 -0000 1.13.2.10 +++ openacs-4/contrib/packages/project-manager/www/index.tcl 29 Apr 2005 17:02:31 -0000 1.13.2.11 @@ -52,7 +52,7 @@ # the unique identifier for this package set package_id [ad_conn package_id] -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] # permissions permission::require_permission -party_id $user_id -object_id $package_id -privilege read Index: openacs-4/contrib/packages/project-manager/www/log-bulk.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/log-bulk.tcl,v diff -u -r1.2.2.3 -r1.2.2.4 --- openacs-4/contrib/packages/project-manager/www/log-bulk.tcl 20 Dec 2004 18:32:07 -0000 1.2.2.3 +++ openacs-4/contrib/packages/project-manager/www/log-bulk.tcl 29 Apr 2005 17:02:31 -0000 1.2.2.4 @@ -19,7 +19,7 @@ } set package_id [ad_conn package_id] -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] set title "Log time for multiple tasks" Index: openacs-4/contrib/packages/project-manager/www/one.adp =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/one.adp,v diff -u -r1.31.2.15 -r1.31.2.16 --- openacs-4/contrib/packages/project-manager/www/one.adp 25 Apr 2005 11:09:21 -0000 1.31.2.15 +++ openacs-4/contrib/packages/project-manager/www/one.adp 29 Apr 2005 17:02:31 -0000 1.31.2.16 @@ -7,7 +7,6 @@ @my_title;noquote@ @context;noquote@ - @project_item_id@

(not current, select live version from the task change page)

Index: openacs-4/contrib/packages/project-manager/www/one.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/one.tcl,v diff -u -r1.30.2.17 -r1.30.2.18 --- openacs-4/contrib/packages/project-manager/www/one.tcl 5 Jan 2005 16:08:14 -0000 1.30.2.17 +++ openacs-4/contrib/packages/project-manager/www/one.tcl 29 Apr 2005 17:02:31 -0000 1.30.2.18 @@ -94,7 +94,7 @@ # the unique identifier for this package set package_id [ad_conn package_id] set package_url [ad_conn package_url] -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] # terminology and other parameters Index: openacs-4/contrib/packages/project-manager/www/process-add-edit.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/process-add-edit.tcl,v diff -u -r1.4.2.3 -r1.4.2.4 --- openacs-4/contrib/packages/project-manager/www/process-add-edit.tcl 25 Nov 2004 01:16:07 -0000 1.4.2.3 +++ openacs-4/contrib/packages/project-manager/www/process-add-edit.tcl 29 Apr 2005 17:02:31 -0000 1.4.2.4 @@ -27,7 +27,7 @@ # --------------------------------------------------------------- # # the unique identifier for this package set package_id [ad_conn package_id] -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] # terminology and parameters set project_term [parameter::get -parameter "ProjectName" -default "Project"] Index: openacs-4/contrib/packages/project-manager/www/process-dependency-add-edit.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/process-dependency-add-edit.tcl,v diff -u -r1.6.2.2 -r1.6.2.3 --- openacs-4/contrib/packages/project-manager/www/process-dependency-add-edit.tcl 2 Jul 2004 23:13:49 -0000 1.6.2.2 +++ openacs-4/contrib/packages/project-manager/www/process-dependency-add-edit.tcl 29 Apr 2005 17:02:31 -0000 1.6.2.3 @@ -69,7 +69,7 @@ # the unique identifier for this package set package_id [ad_conn package_id] -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] # permissions Index: openacs-4/contrib/packages/project-manager/www/process-instance-edit-2.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/process-instance-edit-2.tcl,v diff -u -r1.1.2.1 -r1.1.2.2 --- openacs-4/contrib/packages/project-manager/www/process-instance-edit-2.tcl 6 Nov 2004 01:21:30 -0000 1.1.2.1 +++ openacs-4/contrib/packages/project-manager/www/process-instance-edit-2.tcl 29 Apr 2005 17:02:31 -0000 1.1.2.2 @@ -17,7 +17,7 @@ } -errors { } -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] set package_id [ad_conn package_id] permission::require_permission \ Index: openacs-4/contrib/packages/project-manager/www/process-instances.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/process-instances.tcl,v diff -u -r1.1.2.1 -r1.1.2.2 --- openacs-4/contrib/packages/project-manager/www/process-instances.tcl 6 Nov 2004 01:21:30 -0000 1.1.2.1 +++ openacs-4/contrib/packages/project-manager/www/process-instances.tcl 29 Apr 2005 17:02:31 -0000 1.1.2.2 @@ -23,7 +23,7 @@ # the unique identifier for this package set package_id [ad_conn package_id] -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] # permissions permission::require_permission -party_id $user_id -object_id $package_id -privilege read Index: openacs-4/contrib/packages/project-manager/www/process-one.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/process-one.tcl,v diff -u -r1.9.2.3 -r1.9.2.4 --- openacs-4/contrib/packages/project-manager/www/process-one.tcl 26 Oct 2004 01:21:11 -0000 1.9.2.3 +++ openacs-4/contrib/packages/project-manager/www/process-one.tcl 29 Apr 2005 17:02:31 -0000 1.9.2.4 @@ -30,7 +30,7 @@ # the unique identifier for this package set package_id [ad_conn package_id] -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] # permissions permission::require_permission -party_id $user_id -object_id $package_id -privilege read Index: openacs-4/contrib/packages/project-manager/www/process-task-add-edit-2.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/process-task-add-edit-2.tcl,v diff -u -r1.6.2.3 -r1.6.2.4 --- openacs-4/contrib/packages/project-manager/www/process-task-add-edit-2.tcl 25 Nov 2004 01:16:07 -0000 1.6.2.3 +++ openacs-4/contrib/packages/project-manager/www/process-task-add-edit-2.tcl 29 Apr 2005 17:02:31 -0000 1.6.2.4 @@ -81,7 +81,7 @@ } -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] set package_id [ad_conn package_id] permission::require_permission -party_id $user_id -object_id $package_id -privilege create Index: openacs-4/contrib/packages/project-manager/www/process-task-add-edit.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/process-task-add-edit.tcl,v diff -u -r1.8.2.4 -r1.8.2.5 --- openacs-4/contrib/packages/project-manager/www/process-task-add-edit.tcl 25 Nov 2004 01:16:07 -0000 1.8.2.4 +++ openacs-4/contrib/packages/project-manager/www/process-task-add-edit.tcl 29 Apr 2005 17:02:31 -0000 1.8.2.5 @@ -60,7 +60,7 @@ # -------------------------------------- set package_id [ad_conn package_id] -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] # ------------------------------------------------------------ # if process_task_id is set, then we are editing process tasks Index: openacs-4/contrib/packages/project-manager/www/process-task-delete-2.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/process-task-delete-2.tcl,v diff -u -r1.2.2.2 -r1.2.2.3 --- openacs-4/contrib/packages/project-manager/www/process-task-delete-2.tcl 2 Jul 2004 23:13:49 -0000 1.2.2.2 +++ openacs-4/contrib/packages/project-manager/www/process-task-delete-2.tcl 29 Apr 2005 17:02:31 -0000 1.2.2.3 @@ -14,7 +14,7 @@ # --------------------------------------------------------------- # # the unique identifier for this package set package_id [ad_conn package_id] -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] # permissions permission::require_permission -party_id $user_id -object_id $package_id -privilege write Index: openacs-4/contrib/packages/project-manager/www/process-task-delete.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/process-task-delete.tcl,v diff -u -r1.2.2.2 -r1.2.2.3 --- openacs-4/contrib/packages/project-manager/www/process-task-delete.tcl 2 Jul 2004 23:13:49 -0000 1.2.2.2 +++ openacs-4/contrib/packages/project-manager/www/process-task-delete.tcl 29 Apr 2005 17:02:31 -0000 1.2.2.3 @@ -27,7 +27,7 @@ # --------------------------------------------------------------- # # the unique identifier for this package set package_id [ad_conn package_id] -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] # terminology set task_term_lower [parameter::get -parameter "taskname" -default "task"] Index: openacs-4/contrib/packages/project-manager/www/process-use.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/process-use.tcl,v diff -u -r1.2.2.2 -r1.2.2.3 --- openacs-4/contrib/packages/project-manager/www/process-use.tcl 2 Jul 2004 23:13:49 -0000 1.2.2.2 +++ openacs-4/contrib/packages/project-manager/www/process-use.tcl 29 Apr 2005 17:02:31 -0000 1.2.2.3 @@ -30,7 +30,7 @@ # --------------------------------------------------------------- # -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] set package_id [ad_conn package_id] # terminology Index: openacs-4/contrib/packages/project-manager/www/processes.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/processes.tcl,v diff -u -r1.7.2.4 -r1.7.2.5 --- openacs-4/contrib/packages/project-manager/www/processes.tcl 6 Nov 2004 01:21:30 -0000 1.7.2.4 +++ openacs-4/contrib/packages/project-manager/www/processes.tcl 29 Apr 2005 17:02:31 -0000 1.7.2.5 @@ -40,7 +40,7 @@ # the unique identifier for this package set package_id [ad_conn package_id] -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] # permissions permission::require_permission -party_id $user_id -object_id $package_id -privilege read Index: openacs-4/contrib/packages/project-manager/www/project-assign-edit-2.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/project-assign-edit-2.tcl,v diff -u -r1.2.2.1 -r1.2.2.2 --- openacs-4/contrib/packages/project-manager/www/project-assign-edit-2.tcl 2 Jul 2004 23:13:49 -0000 1.2.2.1 +++ openacs-4/contrib/packages/project-manager/www/project-assign-edit-2.tcl 29 Apr 2005 17:02:31 -0000 1.2.2.2 @@ -17,7 +17,7 @@ } -errors { } -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] # remove assignments set current_assignees [pm::project::assign_remove_everyone \ Index: openacs-4/contrib/packages/project-manager/www/project-assign-edit.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/project-assign-edit.tcl,v diff -u -r1.3.2.2 -r1.3.2.3 --- openacs-4/contrib/packages/project-manager/www/project-assign-edit.tcl 17 Dec 2004 23:07:30 -0000 1.3.2.2 +++ openacs-4/contrib/packages/project-manager/www/project-assign-edit.tcl 29 Apr 2005 17:02:31 -0000 1.3.2.3 @@ -20,7 +20,7 @@ set package_id [ad_conn package_id] # The id of the person logged in and browsing this page -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] set subsite_id [ad_conn subsite_id] Index: openacs-4/contrib/packages/project-manager/www/task-add-edit-2.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/task-add-edit-2.tcl,v diff -u -r1.1.2.10 -r1.1.2.11 --- openacs-4/contrib/packages/project-manager/www/task-add-edit-2.tcl 14 Jan 2005 18:09:39 -0000 1.1.2.10 +++ openacs-4/contrib/packages/project-manager/www/task-add-edit-2.tcl 29 Apr 2005 17:02:31 -0000 1.1.2.11 @@ -54,7 +54,7 @@ # --------------------------------------------------------------- # Set up # --------------------------------------------------------------- -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] set package_id [ad_conn package_id] set peeraddr [ad_conn peeraddr] Index: openacs-4/contrib/packages/project-manager/www/task-add-edit-3.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/task-add-edit-3.tcl,v diff -u -r1.1.2.4 -r1.1.2.5 --- openacs-4/contrib/packages/project-manager/www/task-add-edit-3.tcl 19 Nov 2004 22:43:22 -0000 1.1.2.4 +++ openacs-4/contrib/packages/project-manager/www/task-add-edit-3.tcl 29 Apr 2005 17:02:31 -0000 1.1.2.5 @@ -53,7 +53,7 @@ # --------------------------------------------------------------- # Set up # --------------------------------------------------------------- -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] set package_id [ad_conn package_id] set peeraddr [ad_conn peeraddr] Index: openacs-4/contrib/packages/project-manager/www/task-add-edit.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/task-add-edit.tcl,v diff -u -r1.27.2.19 -r1.27.2.20 --- openacs-4/contrib/packages/project-manager/www/task-add-edit.tcl 5 Jan 2005 16:08:14 -0000 1.27.2.19 +++ openacs-4/contrib/packages/project-manager/www/task-add-edit.tcl 29 Apr 2005 17:02:31 -0000 1.27.2.20 @@ -39,7 +39,7 @@ # --------------------------------------------------------------- # Set up # --------------------------------------------------------------- -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] set package_id [ad_conn package_id] # use hour units or day units Index: openacs-4/contrib/packages/project-manager/www/task-calendar.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/task-calendar.tcl,v diff -u -r1.1.2.7 -r1.1.2.8 --- openacs-4/contrib/packages/project-manager/www/task-calendar.tcl 3 Nov 2004 20:37:13 -0000 1.1.2.7 +++ openacs-4/contrib/packages/project-manager/www/task-calendar.tcl 29 Apr 2005 17:02:31 -0000 1.1.2.8 @@ -20,7 +20,7 @@ roles:multirow } -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] set date [calendar::adjust_date -date $date -julian_date $julian_date] Index: openacs-4/contrib/packages/project-manager/www/task-link.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/task-link.tcl,v diff -u -r1.1.2.1 -r1.1.2.2 --- openacs-4/contrib/packages/project-manager/www/task-link.tcl 26 Oct 2004 01:21:11 -0000 1.1.2.1 +++ openacs-4/contrib/packages/project-manager/www/task-link.tcl 29 Apr 2005 17:02:31 -0000 1.1.2.2 @@ -17,7 +17,7 @@ } -errors { } -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] set package_id [ad_conn package_id] permission::require_permission \ Index: openacs-4/contrib/packages/project-manager/www/task-one.adp =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/task-one.adp,v diff -u -r1.23.2.14 -r1.23.2.15 --- openacs-4/contrib/packages/project-manager/www/task-one.adp 25 Apr 2005 11:41:57 -0000 1.23.2.14 +++ openacs-4/contrib/packages/project-manager/www/task-one.adp 29 Apr 2005 17:02:31 -0000 1.23.2.15 @@ -3,12 +3,11 @@ @task_term@ #@task_id@: @task_info.task_title;noquote@ @closed_message@ @context;noquote@ - @project_item_id@

(not current, select live version from the task change page)

 - + Index: openacs-4/contrib/packages/project-manager/www/task-one.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/task-one.tcl,v diff -u -r1.24.2.14 -r1.24.2.15 --- openacs-4/contrib/packages/project-manager/www/task-one.tcl 5 Jan 2005 17:49:06 -0000 1.24.2.14 +++ openacs-4/contrib/packages/project-manager/www/task-one.tcl 29 Apr 2005 17:02:31 -0000 1.24.2.15 @@ -92,7 +92,7 @@ # the unique identifier for this package set package_id [ad_conn package_id] set package_url [ad_conn package_url] -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] # permissions Index: openacs-4/contrib/packages/project-manager/www/task-print.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/task-print.tcl,v diff -u -r1.3.2.3 -r1.3.2.4 --- openacs-4/contrib/packages/project-manager/www/task-print.tcl 6 Nov 2004 01:21:30 -0000 1.3.2.3 +++ openacs-4/contrib/packages/project-manager/www/task-print.tcl 29 Apr 2005 17:02:31 -0000 1.3.2.4 @@ -74,7 +74,7 @@ # the unique identifier for this package set package_id [ad_conn package_id] -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] set comments [general_comments_get_comments -print_content_p 1 -print_attachments_p 1 $task_id "[ad_conn url]?task_id=$task_id"] Index: openacs-4/contrib/packages/project-manager/www/task-select-project.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/task-select-project.tcl,v diff -u -r1.2.2.3 -r1.2.2.4 --- openacs-4/contrib/packages/project-manager/www/task-select-project.tcl 26 Oct 2004 01:21:11 -0000 1.2.2.3 +++ openacs-4/contrib/packages/project-manager/www/task-select-project.tcl 29 Apr 2005 17:02:31 -0000 1.2.2.4 @@ -34,7 +34,7 @@ # --------------------------------------------------------------- # -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] set package_id [ad_conn package_id] permission::require_permission -object_id $package_id -privilege write Index: openacs-4/contrib/packages/project-manager/www/tasks-postgresql.xql =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/tasks-postgresql.xql,v diff -u -r1.5.2.10 -r1.5.2.11 --- openacs-4/contrib/packages/project-manager/www/tasks-postgresql.xql 25 Apr 2005 12:44:53 -0000 1.5.2.10 +++ openacs-4/contrib/packages/project-manager/www/tasks-postgresql.xql 29 Apr 2005 17:02:31 -0000 1.5.2.11 @@ -5,12 +5,11 @@ SELECT - ts.task_id, + ts.task_id as task_item_id, ts.task_number, t.task_revision_id, t.title, - t.description, - tst.description as status, + t.description, t.parent_id as project_item_id, proj_rev.logger_project, proj_rev.title as project_name, @@ -33,7 +32,6 @@ r.one_line as role FROM pm_tasks_active ts, - pm_task_status tst, cr_items i, pm_tasks_revisionsx t LEFT JOIN pm_task_assignment ta @@ -47,48 +45,15 @@ pm_projectsx proj_rev WHERE ts.task_id = t.item_id and - tst.status_id = status and i.item_id = t.item_id and t.task_revision_id = i.live_revision and t.parent_id = proj.item_id and proj.live_revision = proj_rev.revision_id and proj.parent_id = f.folder_id and f.package_id = :package_id - [template::list::page_where_clause -and -name "tasks" -key "ts.task_id"] [template::list::filter_where_clauses -and -name tasks] [template::list::orderby_clause -orderby -name tasks] - - - select distinct task_id from ( - SELECT - ts.task_id - FROM - pm_tasks_active ts, - cr_items i, - pm_tasks_revisionsx t - LEFT JOIN pm_task_assignment ta - ON t.item_id = ta.task_id - LEFT JOIN persons p - ON ta.party_id = p.person_id - LEFT JOIN pm_roles r - ON ta.role_id = r.role_id, - cr_items proj, - cr_folders f, - pm_projectsx proj_rev - WHERE - ts.task_id = t.item_id and - i.item_id = t.item_id and - t.task_revision_id = i.live_revision and - t.parent_id = proj.item_id and - proj.live_revision = proj_rev.revision_id - and proj.parent_id = f.folder_id - and f.package_id = :package_id - [template::list::filter_where_clauses -and -name tasks] - [template::list::orderby_clause -orderby -name tasks]) as tasks - - - Index: openacs-4/contrib/packages/project-manager/www/tasks.adp =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/tasks.adp,v diff -u -r1.5.2.3 -r1.5.2.4 --- openacs-4/contrib/packages/project-manager/www/tasks.adp 25 Apr 2005 11:09:05 -0000 1.5.2.3 +++ openacs-4/contrib/packages/project-manager/www/tasks.adp 29 Apr 2005 17:02:31 -0000 1.5.2.4 @@ -4,9 +4,8 @@ @task_term@s@context@ - - @passed_project_item_id@ - + +
Index: openacs-4/contrib/packages/project-manager/www/tasks.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/Attic/tasks.tcl,v diff -u -r1.5.2.21 -r1.5.2.22 --- openacs-4/contrib/packages/project-manager/www/tasks.tcl 25 Apr 2005 12:45:31 -0000 1.5.2.21 +++ openacs-4/contrib/packages/project-manager/www/tasks.tcl 29 Apr 2005 17:02:31 -0000 1.5.2.22 @@ -3,7 +3,6 @@ Main view page for tasks. @author jader@bread.com - @author openacs@sussdorff.de (MS) @creation-date 2003-12-03 @cvs-id $Id$ @@ -24,18 +23,14 @@ {searchterm ""} {mine_p "t"} {status_id ""} - {page ""} - {page_size 25} role_id:optional - project_item_id:optional } -properties { task_term:onevalue context:onevalue tasks:multirow hidden_vars:onevalue } - # if someone clicks on a party, then we want to see those tasks. if {[exists_and_not_null party_id]} { set mine_p "f" @@ -51,13 +46,6 @@ set use_days_p [parameter::get -parameter "UseDayInsteadOfHour" -default "t"] -# Check if a project_item_id was passed in and store it -if [exists_and_not_null project_item_id] { - set passed_project_item_id $project_item_id -} else { - set passed_project_item_id 0 -} - set exporting_vars { status_id party_id orderby mine_p } set hidden_vars [export_vars -form $exporting_vars] # how to get back here @@ -67,12 +55,9 @@ # set up context bar set context [list "Tasks"] -# Get the currently available Status -set status_list [db_list_of_lists get_status_values "select description, status_id from pm_task_status order by status_type desc, description"] - # the unique identifier for this package set package_id [ad_conn package_id] -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] # if mine_p is true, show only my tasks if {[string equal $mine_p t]} { @@ -81,10 +66,7 @@ # status defaults to open if {![exists_and_not_null status_id]} { - set status_where_clause "" -# set status_id [pm::task::default_status_open] -} else { - set status_where_clause {ts.status = :status_id} + set status_id [pm::task::default_status_open] } # permissions @@ -124,11 +106,11 @@ set elements { - task_id { + task_number { label "\#" link_url_col item_url link_html { title "View this project version" } - display_template {@tasks.task_id@} + display_template {@tasks.task_item_id@} } title { label "Subject" @@ -140,73 +122,30 @@ role { label "Role" } + latest_start_pretty { + label "Latest Start" + } + latest_finish_pretty { + label "Latest Finish" + display_template { + @tasks.latest_finish_pretty@ + } + } } -# MS: This assumes that the status of "2" will always be closed. -# It does not make sense to display the latest_start and finished times for already -# Closed tasks - -if {$status_id != 2} { - append elements { - latest_start_pretty { - label "Latest Start" - } - latest_finish_pretty { - label "Latest Finish" - display_template { - @tasks.latest_finish_pretty@ - } - } - } -} - -append elements { - status { - label "Status" - } -} - -# MS: This assumes that the status of "2" will always be closed. -# It does not make sense to display the remaining hours for -# Closed tasks - -if {$status_id != 2} { - - if {[string is true $use_days_p]} { - append elements { - days_remaining { - label "Days work" - html { - align right - } - } - } - } else { - append elements { - hours_remaining { - label "Hours remaining" - html { - align right - } - } - } - } - -} - if {[string is true $use_days_p]} { append elements { - actual_days_worked { - label "Days worked" + days_remaining { + label "Days work" html { align right } } } } else { append elements { - actual_hours_worked { - label "Hours worked" + hours_remaining { + label "Hours remaining" html { align right } @@ -219,21 +158,20 @@ label "Project" display_col project_name link_url_eval {[export_vars -base one {project_item_id $tasks(project_item_id)}]} - hide_p {[ad_decode [exists_and_not_null project_item_id] 1 1 0]} } log_url { label "Log" display_template {L} } percent_complete { - display_template "" + display_template "" } } template::list::create \ -name tasks \ -multirow tasks \ - -key task_id \ + -key task_item_id \ -elements $elements \ -actions [list "Add task" [export_vars -base task-select-project {return_url}] "Add a task"] \ -bulk_actions { @@ -251,43 +189,35 @@ label "Search" where_clause {$search_term_where} } - status_id { - label "Status" - values {$status_list} - where_clause "$status_where_clause" - } - project_item_id { - label "Project" - values {[pm::project::get_list_of_open]} - where_clause { - t.parent_id = :project_item_id - } - } role_id { label "Roles" values {[pm::role::select_list_filter]} where_clause { ta.role_id = :role_id } } - party_id { label "People" values {[pm::task::assignee_filter_select -status_id $status_id]} where_clause { ta.party_id = :party_id } } + status_id { + label "Status" + values {[db_list_of_lists get_status_values "select description, status_id from pm_task_status order by status_type desc, description"]} + where_clause {ts.status = :status_id} + } mine_p { label "Show others' tasks" } } \ -orderby { default_value $default_orderby - task_id { + task_number { label "Task \#" - orderby_desc "ts.task_id desc, p.first_names, p.last_name" - orderby_asc "ts.task_id asc, p.first_names, p.last_name" + orderby_desc "ts.task_number desc, p.first_names, p.last_name" + orderby_asc "ts.task_number asc, p.first_names, p.last_name" default_direction asc } title { @@ -326,27 +256,20 @@ orderby_asc "t.latest_finish, ts.task_id, p.first_names, p.last_name" default_direction asc } - status { - label "Status" - orderby_desc "status desc, t.latest_finish desc, ts.task_id, p.first_names, p.last_name" - orderby_asc "status asc, t.latest_finish desc, ts.task_id, p.first_names, p.last_name" - default_direction asc - } } \ - -page_size_variable_p 1 \ - -page_size $page_size \ - -page_flush_p 0 \ - -page_query_name tasks_pagination \ -orderby_name orderby \ -html { width 100% } + + + db_multirow -extend { item_url latest_start_pretty latest_finish_pretty slack_time log_url hours_remaining days_remaining} tasks tasks { } { - set item_url [export_vars -base "task-one" {{task_id $task_id}}] + set item_url [export_vars -base "task-one" {{task_id $task_item_id}}] - set log_url [export_vars -base "${logger_url}log" {{project_id $logger_project} {pm_task_id $task_id} {pm_project_id $project_item_id} {return_url $return_url}}] + set log_url [export_vars -base "${logger_url}log" {{project_id $logger_project} {pm_task_id $task_item_id} {pm_project_id $project_item_id} {return_url $return_url}}] set latest_start_pretty [lc_time_fmt $latest_start "%x"] set latest_finish_pretty [lc_time_fmt $latest_finish "%x"] @@ -374,8 +297,6 @@ -estimated_hours_work_max $estimated_hours_work_max \ -percent_complete $percent_complete] - set actual_days_worked [expr $actual_hours_worked / 24] - } Index: openacs-4/contrib/packages/project-manager/www/admin/default-project-roles.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/admin/Attic/default-project-roles.tcl,v diff -u -r1.2 -r1.2.2.1 --- openacs-4/contrib/packages/project-manager/www/admin/default-project-roles.tcl 26 Jan 2004 15:39:40 -0000 1.2 +++ openacs-4/contrib/packages/project-manager/www/admin/default-project-roles.tcl 29 Apr 2005 17:02:32 -0000 1.2.2.1 @@ -41,7 +41,7 @@ # the unique identifier for this package set package_id [ad_conn package_id] -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] # permissions permission::require_permission -party_id $user_id -object_id $package_id -privilege read Index: openacs-4/contrib/packages/project-manager/www/admin/index.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/admin/Attic/index.tcl,v diff -u -r1.3.2.1 -r1.3.2.2 --- openacs-4/contrib/packages/project-manager/www/admin/index.tcl 2 Jul 2004 23:13:49 -0000 1.3.2.1 +++ openacs-4/contrib/packages/project-manager/www/admin/index.tcl 29 Apr 2005 17:02:32 -0000 1.3.2.2 @@ -42,7 +42,7 @@ # the unique identifier for this package set package_id [ad_conn package_id] -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] # set up links set categories_link "/categories/cadmin/one-object?object_id=$package_id" Index: openacs-4/contrib/packages/project-manager/www/admin/roles.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/admin/Attic/roles.tcl,v diff -u -r1.2 -r1.2.2.1 --- openacs-4/contrib/packages/project-manager/www/admin/roles.tcl 26 Jan 2004 15:39:40 -0000 1.2 +++ openacs-4/contrib/packages/project-manager/www/admin/roles.tcl 29 Apr 2005 17:02:32 -0000 1.2.2.1 @@ -41,7 +41,7 @@ # the unique identifier for this package set package_id [ad_conn package_id] -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] # permissions permission::require_permission -party_id $user_id -object_id $package_id -privilege read Index: openacs-4/contrib/packages/project-manager/www/admin/workgroups.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/admin/Attic/workgroups.tcl,v diff -u -r1.2 -r1.2.2.1 --- openacs-4/contrib/packages/project-manager/www/admin/workgroups.tcl 26 Jan 2004 15:39:40 -0000 1.2 +++ openacs-4/contrib/packages/project-manager/www/admin/workgroups.tcl 29 Apr 2005 17:02:32 -0000 1.2.2.1 @@ -41,7 +41,7 @@ # the unique identifier for this package set package_id [ad_conn package_id] -set user_id [ad_maybe_redirect_for_registration] +set user_id [auth::require_login] # permissions permission::require_permission -party_id $user_id -object_id $package_id -privilege read Index: openacs-4/contrib/packages/project-manager/www/comments/add.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/comments/Attic/add.tcl,v diff -u -r1.1.2.1 -r1.1.2.2 --- openacs-4/contrib/packages/project-manager/www/comments/add.tcl 21 Sep 2004 00:29:45 -0000 1.1.2.1 +++ openacs-4/contrib/packages/project-manager/www/comments/add.tcl 29 Apr 2005 17:02:32 -0000 1.1.2.2 @@ -13,7 +13,6 @@ title:notnull return_url:notnull {type "task"} - {attach_p "f"} {description:html ""} } -properties { } -validate { @@ -54,12 +53,6 @@ {options {{"Yes" "t"} {"No" "f"}}} } - {attach_p:text(select),optional - {label "Attach a file?"} - {options {{"Yes" "t"} {"No" "f"}}} - {value "f"} - } - } -new_request { set description [template::util::richtext::create "" {}] @@ -70,21 +63,16 @@ set description_body [template::util::richtext::get_property contents $description] set description_format [template::util::richtext::get_property format $description] - set comment_id [pm::util::general_comment_add \ - -object_id $object_id \ - -title "$title" \ - -comment "$description_body" \ - -mime_type "$description_format" \ - -send_email_p $send_email_p \ - -type $type] + pm::util::general_comment_add \ + -object_id $object_id \ + -title "$title" \ + -comment "$description_body" \ + -mime_type "$description_format" \ + -send_email_p $send_email_p \ + -type $type # does not seem to be working for some reason util_user_message -message "Comment: [ad_quotehtml $title] saved" - - if { [string equal $attach_p "f"] && ![empty_string_p $return_url] } { - ad_returnredirect $return_url - } else { - ad_returnredirect "/comments/view-comment?[export_vars { comment_id return_url }]" - } + ad_returnredirect $return_url } Index: openacs-4/contrib/packages/project-manager/www/lib/master.adp =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/lib/Attic/master.adp,v diff -u -r1.2.2.5 -r1.2.2.6 --- openacs-4/contrib/packages/project-manager/www/lib/master.adp 25 Apr 2005 11:09:21 -0000 1.2.2.5 +++ openacs-4/contrib/packages/project-manager/www/lib/master.adp 29 Apr 2005 17:02:32 -0000 1.2.2.6 @@ -18,12 +18,11 @@ @import url(@package_url@style.css) all; - +

- + - Index: openacs-4/contrib/packages/project-manager/www/lib/master.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/lib/Attic/master.tcl,v diff -u -r1.2.2.1 -r1.2.2.2 --- openacs-4/contrib/packages/project-manager/www/lib/master.tcl 25 Apr 2005 11:09:21 -0000 1.2.2.1 +++ openacs-4/contrib/packages/project-manager/www/lib/master.tcl 29 Apr 2005 17:02:32 -0000 1.2.2.2 @@ -3,5 +3,3 @@ set package_url [ad_conn package_url] if { ![info exists header_stuff] } { set header_stuff {} } - -if { ![info exists project_item_id] } { set project_item_id "" } \ No newline at end of file Index: openacs-4/contrib/packages/project-manager/www/lib/nav-bar.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/project-manager/www/lib/Attic/nav-bar.tcl,v diff -u -r1.2.2.5 -r1.2.2.6 --- openacs-4/contrib/packages/project-manager/www/lib/nav-bar.tcl 29 Apr 2005 15:17:30 -0000 1.2.2.5 +++ openacs-4/contrib/packages/project-manager/www/lib/nav-bar.tcl 29 Apr 2005 17:02:32 -0000 1.2.2.6 @@ -20,12 +20,7 @@ if { [ad_conn user_id] != 0} { - if { [empty_string_p $project_item_id] } { - lappend link_list [list "${package_url}tasks"] - } else { - lappend link_list [list [export_vars -base "${package_url}tasks" {{project_item_id}}]] - } - + lappend link_list [list "${package_url}tasks"] lappend link_list {} lappend link_list "Tasks" @@ -41,12 +36,7 @@ lappend link_list {} lappend link_list "Processes" - if [empty_string_p $project_item_id] { - lappend link_list [list "[export_vars -base ${logger_url} {user_id {project_manager_url $package_url}}]"] - } else { - set logger_project_id [pm::project::get_logger_project -project_item_id $project_item_id] - lappend link_list [list "[export_vars -base ${logger_url} {{project_manager_url $package_url} {project_id $logger_project_id}}]"] - } + lappend link_list [list "${logger_url}?user_id=${user_id}"] lappend link_list {} lappend link_list "Logger"