Index: openacs-4/contrib/packages/simulation/lib/cases-admin.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/simulation/lib/Attic/cases-admin.tcl,v diff -u -r1.2 -r1.3 --- openacs-4/contrib/packages/simulation/lib/cases-admin.tcl 8 Jan 2004 14:24:44 -0000 1.2 +++ openacs-4/contrib/packages/simulation/lib/cases-admin.tcl 12 Jan 2004 15:52:44 -0000 1.3 @@ -10,7 +10,7 @@ } } -# TODO: add link to simplay/case for each case +# TODO: add link to simplay/case for each case - LARS: We can't unless we list all the roles as well, 'cause simplay/case requires role_id set package_id [ad_conn package_id] set user_id [auth::get_user_id] Index: openacs-4/contrib/packages/simulation/lib/cases.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/simulation/lib/Attic/cases.tcl,v diff -u -r1.9 -r1.10 --- openacs-4/contrib/packages/simulation/lib/cases.tcl 12 Jan 2004 13:43:14 -0000 1.9 +++ openacs-4/contrib/packages/simulation/lib/cases.tcl 12 Jan 2004 15:52:44 -0000 1.10 @@ -10,9 +10,6 @@ } } -# TODO: add link to simplay/case for each case -# TODO: hide case if not admin - set package_id [ad_conn package_id] set elements { Index: openacs-4/contrib/packages/simulation/lib/object-display.adp =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/simulation/lib/Attic/object-display.adp,v diff -u -r1.6 -r1.7 --- openacs-4/contrib/packages/simulation/lib/object-display.adp 6 Jan 2004 13:05:47 -0000 1.6 +++ openacs-4/contrib/packages/simulation/lib/object-display.adp 12 Jan 2004 15:52:44 -0000 1.7 @@ -12,5 +12,3 @@ Edit

-

TODO: edit_url shouldn't show up if user doesn't have permission to - edit object \ No newline at end of file Index: openacs-4/contrib/packages/simulation/lib/sim-template-tasks.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/simulation/lib/Attic/sim-template-tasks.tcl,v diff -u -r1.29 -r1.30 --- openacs-4/contrib/packages/simulation/lib/sim-template-tasks.tcl 12 Jan 2004 13:43:14 -0000 1.29 +++ openacs-4/contrib/packages/simulation/lib/sim-template-tasks.tcl 12 Jan 2004 15:52:44 -0000 1.30 @@ -33,8 +33,6 @@ #------------------------------------------------------------- # tasks list #------------------------------------------------------------- -# TODO: missing: discription, type -# how is type going to work? open question pending prototyping if { $display_mode == "edit"} { set list_actions [list "Add a Task" [export_vars -base task-edit {workflow_id} ] {}] Index: openacs-4/contrib/packages/simulation/lib/sim-templates.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/simulation/lib/Attic/sim-templates.tcl,v diff -u -r1.15 -r1.16 --- openacs-4/contrib/packages/simulation/lib/sim-templates.tcl 9 Jan 2004 14:40:03 -0000 1.15 +++ openacs-4/contrib/packages/simulation/lib/sim-templates.tcl 12 Jan 2004 15:52:44 -0000 1.16 @@ -5,10 +5,6 @@ @creation-date 2003-11-12 @cvs-id $Id$ } { - display_mode { - allowed_values {edit display} - default_value display - } size { allowed_values {short long} default_value long @@ -22,8 +18,6 @@ set actions [list "Add a template" $add_url {} \ "Import a template" "[apm_package_url_from_id $package_id]simbuild/template-load" {}] -# TODO: make this include honor the display_mode parameter - switch $size { short { set elements { @@ -115,7 +109,7 @@ # a list of templates # ###################################################################### -# TODO: limit this to see only your own templates +# TODO (.25h): limit this to see only your own templates # If you are the admin, show all templates in long mode db_multirow -extend { edit_url view_url delete_url clone_url edit_p } sim_templates select_sim_templates " @@ -148,14 +142,14 @@ " { set description [ad_html_text_convert -from $description_mime_type -maxlen 200 -- $description] - set edit_url [export_vars -base "[apm_package_url_from_id $package_id]simbuild/template-edit" {workflow_id} ] + set edit_url [export_vars -base "[apm_package_url_from_id $package_id]simbuild/template-edit" { workflow_id }] - set view_url [export_vars -base "[apm_package_url_from_id $package_id]simbuild/template-edit" {workflow_id} ] + set view_url [export_vars -base "[apm_package_url_from_id $package_id]simbuild/template-edit" { workflow_id }] - set clone_url [export_vars -base "[apm_package_url_from_id $package_id]simbuild/template-clone" {workflow_id} ] + set clone_url [export_vars -base "[apm_package_url_from_id $package_id]simbuild/template-clone" { workflow_id }] set edit_p [permission::write_permission_p -object_id $workflow_id] - set delete_url [export_vars -base "[apm_package_url_from_id $package_id]simbuild/template-delete" {workflow_id} ] + set delete_url [export_vars -base "[apm_package_url_from_id $package_id]simbuild/template-delete" { workflow_id }] } Index: openacs-4/contrib/packages/simulation/lib/simulations-available.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/simulation/lib/Attic/simulations-available.tcl,v diff -u -r1.2 -r1.3 --- openacs-4/contrib/packages/simulation/lib/simulations-available.tcl 8 Jan 2004 14:24:44 -0000 1.2 +++ openacs-4/contrib/packages/simulation/lib/simulations-available.tcl 12 Jan 2004 15:52:44 -0000 1.3 @@ -12,7 +12,7 @@ set package_id [ad_conn package_id] - # TODO: if invited instead of open, say "accept invitation to enroll" +# TODO (.25h): if invited instead of open, say "accept invitation to enroll" set elements { pretty_name { @@ -40,8 +40,8 @@ -no_data "No simulations available to self-enroll." \ -elements $elements -# TODO: verify that the first half of this query returns the sims to which the user is invited (data model may have changed since this was coded) -# TODO: exclude simulations for which the user is currently enrolled +# TODO (.25h): verify that the first half of this query returns the sims to which the user is invited (data model may have changed since this was coded) +# TODO (.25h): exclude simulations for which the user is currently enrolled db_multirow -extend {enroll_url} avail_sims select_avail_sims " select w.workflow_id, @@ -67,4 +67,4 @@ set enroll_url [export_vars -base "[apm_package_url_from_id $package_id]simplay/enroll" {workflow_id} ] set description [ad_html_text_convert -from $description_mime_type -maxlen 200 -- $description] -} \ No newline at end of file +} Index: openacs-4/contrib/packages/simulation/lib/tasks.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/simulation/lib/Attic/tasks.tcl,v diff -u -r1.9 -r1.10 --- openacs-4/contrib/packages/simulation/lib/tasks.tcl 12 Jan 2004 15:14:36 -0000 1.9 +++ openacs-4/contrib/packages/simulation/lib/tasks.tcl 12 Jan 2004 15:52:44 -0000 1.10 @@ -66,7 +66,6 @@ -no_data "You don't have any tasks." \ -elements $elements -# TODO: Honor role_id db_multirow -extend { task_url } tasks select_tasks " select wcea.enabled_action_id, wa.pretty_name as name, Index: openacs-4/contrib/packages/simulation/lib/yellow-pages.adp =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/simulation/lib/Attic/yellow-pages.adp,v diff -u -r1.1 -r1.2 --- openacs-4/contrib/packages/simulation/lib/yellow-pages.adp 2 Dec 2003 17:29:48 -0000 1.1 +++ openacs-4/contrib/packages/simulation/lib/yellow-pages.adp 12 Jan 2004 15:52:44 -0000 1.2 @@ -1,2 +1,2 @@

-TODO: modify query to use object_type pretty_name + Index: openacs-4/contrib/packages/simulation/lib/yellow-pages.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/simulation/lib/Attic/yellow-pages.tcl,v diff -u -r1.1 -r1.2 --- openacs-4/contrib/packages/simulation/lib/yellow-pages.tcl 2 Dec 2003 17:29:48 -0000 1.1 +++ openacs-4/contrib/packages/simulation/lib/yellow-pages.tcl 12 Jan 2004 15:52:44 -0000 1.2 @@ -29,6 +29,7 @@ object_type { label "Type" orderby upper(ot.pretty_name) + display_col object_type_pretty } title { label "Name" @@ -54,23 +55,29 @@ db_multirow -extend {view_url} objects select_objects " select sl.object_id, sl.object_type, + ot.pretty_name as object_type_pretty, sl.title, sl.mime_type, sl.name, sl.item_id, sl.description - from sim_locationsx sl + from sim_locationsx sl, + acs_object_types ot where in_directory_p = 't' + and ot.object_type = sl.object_type UNION select sc.object_id, sc.object_type, + ot.pretty_name as object_type_pretty, sc.title, sc.mime_type, sc.name, sc.item_id, sc.description - from sim_charactersx sc + from sim_charactersx sc, + acs_object_types ot where in_directory_p = 't' + and ot.object_type = sc.object_type [template::list::orderby_clause -orderby -name "objects"] " { Index: openacs-4/contrib/packages/simulation/tcl/object-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/simulation/tcl/Attic/object-procs.tcl,v diff -u -r1.7 -r1.8 --- openacs-4/contrib/packages/simulation/tcl/object-procs.tcl 15 Dec 2003 15:28:20 -0000 1.7 +++ openacs-4/contrib/packages/simulation/tcl/object-procs.tcl 12 Jan 2004 15:56:58 -0000 1.8 @@ -67,7 +67,7 @@ and ancestor_type = 'content_revision' }] - # LARS TODO: We need to be able to scope this to a package, + # TODO B: We need to be able to scope this to a package, # possibly filter by other things, control the sort order, # we need to be able to control what the label looks like (e.g. include email for users) # and it needs to be intelligent about scaling issues Index: openacs-4/contrib/packages/simulation/tcl/template-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/simulation/tcl/Attic/template-procs.tcl,v diff -u -r1.41 -r1.42 --- openacs-4/contrib/packages/simulation/tcl/template-procs.tcl 12 Jan 2004 11:06:17 -0000 1.41 +++ openacs-4/contrib/packages/simulation/tcl/template-procs.tcl 12 Jan 2004 15:56:58 -0000 1.42 @@ -83,6 +83,7 @@ if { [empty_string_p $row($attr)] } { set $varname [db_null] } else { + # TODO B: need better tests for duration before passing it into the database. set $varname "interval '[db_quote $row($attr)]'" } } @@ -496,11 +497,10 @@ enroll_end, and enroll_start properties to reflect an immediate start and then directly invoking simulation::template::start. - TODO: make sure the sweeper doesn't pick up simulations that - have been forced to start. - @author Peter Marklund } { + # TODO (.25h): make sure the sweeper doesn't pick up simulations that have been forced to start. + simulation::template::get -workflow_id $workflow_id -array simulation db_transaction { @@ -531,10 +531,10 @@ Make a simulation go live. Does enrollment and casting and sets sim_type attribute to live_sim. - TODO: invoke this proc from a sweep - @author Peter Marklund } { + # TODO (.25h): invoke this proc from a sweep + simulation::template::get -workflow_id $workflow_id -array simulation if { ![string equal $simulation(sim_type) "casting_sim"] } { @@ -566,14 +566,12 @@ Takes a mapped simulation template and converts it into a cast simulation with simulation cases. This procedure expects to be called after enrollment is complete. - TODO: agent support - - TODO: taking actor type into account - - TODO: other casting_type values than auto - @author Peter Marklund } { + # TODO: taking actor type into account -- LARS: What is this? Setting to 2h to be safe (I think) + + # TODO: other casting_type values than auto -- LARS: Why would we then do autocast, if casting_type is not auto? + simulation::template::role_party_mappings \ -workflow_id $workflow_id \ -array roles @@ -674,7 +672,7 @@ {-package_key:required} {-object_id:required} } { - Create a new simulation template. TODO: need better tests for duration before passing it into the database. + Create a new simulation template. @return The workflow_id of the created simulation. @@ -831,7 +829,7 @@ } { simulation::template::get -workflow_id $workflow_id -array sim_template - # TODO: Refactor + # TODO (1.5h): Refactor this and the corresponding wizard.tcl/adp page # What we really need to know is whether each step is complete # They're all independent of each other, except for casting, which is dependent on participants. Index: openacs-4/contrib/packages/simulation/www/index.adp =================================================================== RCS file: /usr/local/cvsroot/openacs-4/contrib/packages/simulation/www/Attic/index.adp,v diff -u -r1.28 -r1.29 --- openacs-4/contrib/packages/simulation/www/index.adp 8 Jan 2004 14:24:44 -0000 1.28 +++ openacs-4/contrib/packages/simulation/www/index.adp 12 Jan 2004 15:52:44 -0000 1.29 @@ -2,22 +2,22 @@ @page_title;noquote@ @context;noquote@ - +

CityBuild

 - +

SimBuild

 - +

SimInst

Index: openacs-4/packages/simulation/lib/cases-admin.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/simulation/lib/cases-admin.tcl,v diff -u -r1.2 -r1.3 --- openacs-4/packages/simulation/lib/cases-admin.tcl 8 Jan 2004 14:24:44 -0000 1.2 +++ openacs-4/packages/simulation/lib/cases-admin.tcl 12 Jan 2004 15:52:44 -0000 1.3 @@ -10,7 +10,7 @@ } } -# TODO: add link to simplay/case for each case +# TODO: add link to simplay/case for each case - LARS: We can't unless we list all the roles as well, 'cause simplay/case requires role_id set package_id [ad_conn package_id] set user_id [auth::get_user_id] Index: openacs-4/packages/simulation/lib/cases.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/simulation/lib/cases.tcl,v diff -u -r1.9 -r1.10 --- openacs-4/packages/simulation/lib/cases.tcl 12 Jan 2004 13:43:14 -0000 1.9 +++ openacs-4/packages/simulation/lib/cases.tcl 12 Jan 2004 15:52:44 -0000 1.10 @@ -10,9 +10,6 @@ } } -# TODO: add link to simplay/case for each case -# TODO: hide case if not admin - set package_id [ad_conn package_id] set elements { Index: openacs-4/packages/simulation/lib/object-display.adp =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/simulation/lib/object-display.adp,v diff -u -r1.6 -r1.7 --- openacs-4/packages/simulation/lib/object-display.adp 6 Jan 2004 13:05:47 -0000 1.6 +++ openacs-4/packages/simulation/lib/object-display.adp 12 Jan 2004 15:52:44 -0000 1.7 @@ -12,5 +12,3 @@ Edit

-

TODO: edit_url shouldn't show up if user doesn't have permission to - edit object \ No newline at end of file Index: openacs-4/packages/simulation/lib/sim-template-tasks.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/simulation/lib/sim-template-tasks.tcl,v diff -u -r1.29 -r1.30 --- openacs-4/packages/simulation/lib/sim-template-tasks.tcl 12 Jan 2004 13:43:14 -0000 1.29 +++ openacs-4/packages/simulation/lib/sim-template-tasks.tcl 12 Jan 2004 15:52:44 -0000 1.30 @@ -33,8 +33,6 @@ #------------------------------------------------------------- # tasks list #------------------------------------------------------------- -# TODO: missing: discription, type -# how is type going to work? open question pending prototyping if { $display_mode == "edit"} { set list_actions [list "Add a Task" [export_vars -base task-edit {workflow_id} ] {}] Index: openacs-4/packages/simulation/lib/sim-templates.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/simulation/lib/sim-templates.tcl,v diff -u -r1.15 -r1.16 --- openacs-4/packages/simulation/lib/sim-templates.tcl 9 Jan 2004 14:40:03 -0000 1.15 +++ openacs-4/packages/simulation/lib/sim-templates.tcl 12 Jan 2004 15:52:44 -0000 1.16 @@ -5,10 +5,6 @@ @creation-date 2003-11-12 @cvs-id $Id$ } { - display_mode { - allowed_values {edit display} - default_value display - } size { allowed_values {short long} default_value long @@ -22,8 +18,6 @@ set actions [list "Add a template" $add_url {} \ "Import a template" "[apm_package_url_from_id $package_id]simbuild/template-load" {}] -# TODO: make this include honor the display_mode parameter - switch $size { short { set elements { @@ -115,7 +109,7 @@ # a list of templates # ###################################################################### -# TODO: limit this to see only your own templates +# TODO (.25h): limit this to see only your own templates # If you are the admin, show all templates in long mode db_multirow -extend { edit_url view_url delete_url clone_url edit_p } sim_templates select_sim_templates " @@ -148,14 +142,14 @@ " { set description [ad_html_text_convert -from $description_mime_type -maxlen 200 -- $description] - set edit_url [export_vars -base "[apm_package_url_from_id $package_id]simbuild/template-edit" {workflow_id} ] + set edit_url [export_vars -base "[apm_package_url_from_id $package_id]simbuild/template-edit" { workflow_id }] - set view_url [export_vars -base "[apm_package_url_from_id $package_id]simbuild/template-edit" {workflow_id} ] + set view_url [export_vars -base "[apm_package_url_from_id $package_id]simbuild/template-edit" { workflow_id }] - set clone_url [export_vars -base "[apm_package_url_from_id $package_id]simbuild/template-clone" {workflow_id} ] + set clone_url [export_vars -base "[apm_package_url_from_id $package_id]simbuild/template-clone" { workflow_id }] set edit_p [permission::write_permission_p -object_id $workflow_id] - set delete_url [export_vars -base "[apm_package_url_from_id $package_id]simbuild/template-delete" {workflow_id} ] + set delete_url [export_vars -base "[apm_package_url_from_id $package_id]simbuild/template-delete" { workflow_id }] } Index: openacs-4/packages/simulation/lib/simulations-available.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/simulation/lib/simulations-available.tcl,v diff -u -r1.2 -r1.3 --- openacs-4/packages/simulation/lib/simulations-available.tcl 8 Jan 2004 14:24:44 -0000 1.2 +++ openacs-4/packages/simulation/lib/simulations-available.tcl 12 Jan 2004 15:52:44 -0000 1.3 @@ -12,7 +12,7 @@ set package_id [ad_conn package_id] - # TODO: if invited instead of open, say "accept invitation to enroll" +# TODO (.25h): if invited instead of open, say "accept invitation to enroll" set elements { pretty_name { @@ -40,8 +40,8 @@ -no_data "No simulations available to self-enroll." \ -elements $elements -# TODO: verify that the first half of this query returns the sims to which the user is invited (data model may have changed since this was coded) -# TODO: exclude simulations for which the user is currently enrolled +# TODO (.25h): verify that the first half of this query returns the sims to which the user is invited (data model may have changed since this was coded) +# TODO (.25h): exclude simulations for which the user is currently enrolled db_multirow -extend {enroll_url} avail_sims select_avail_sims " select w.workflow_id, @@ -67,4 +67,4 @@ set enroll_url [export_vars -base "[apm_package_url_from_id $package_id]simplay/enroll" {workflow_id} ] set description [ad_html_text_convert -from $description_mime_type -maxlen 200 -- $description] -} \ No newline at end of file +} Index: openacs-4/packages/simulation/lib/tasks.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/simulation/lib/tasks.tcl,v diff -u -r1.9 -r1.10 --- openacs-4/packages/simulation/lib/tasks.tcl 12 Jan 2004 15:14:36 -0000 1.9 +++ openacs-4/packages/simulation/lib/tasks.tcl 12 Jan 2004 15:52:44 -0000 1.10 @@ -66,7 +66,6 @@ -no_data "You don't have any tasks." \ -elements $elements -# TODO: Honor role_id db_multirow -extend { task_url } tasks select_tasks " select wcea.enabled_action_id, wa.pretty_name as name, Index: openacs-4/packages/simulation/lib/yellow-pages.adp =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/simulation/lib/yellow-pages.adp,v diff -u -r1.1 -r1.2 --- openacs-4/packages/simulation/lib/yellow-pages.adp 2 Dec 2003 17:29:48 -0000 1.1 +++ openacs-4/packages/simulation/lib/yellow-pages.adp 12 Jan 2004 15:52:44 -0000 1.2 @@ -1,2 +1,2 @@

-TODO: modify query to use object_type pretty_name + Index: openacs-4/packages/simulation/lib/yellow-pages.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/simulation/lib/yellow-pages.tcl,v diff -u -r1.1 -r1.2 --- openacs-4/packages/simulation/lib/yellow-pages.tcl 2 Dec 2003 17:29:48 -0000 1.1 +++ openacs-4/packages/simulation/lib/yellow-pages.tcl 12 Jan 2004 15:52:44 -0000 1.2 @@ -29,6 +29,7 @@ object_type { label "Type" orderby upper(ot.pretty_name) + display_col object_type_pretty } title { label "Name" @@ -54,23 +55,29 @@ db_multirow -extend {view_url} objects select_objects " select sl.object_id, sl.object_type, + ot.pretty_name as object_type_pretty, sl.title, sl.mime_type, sl.name, sl.item_id, sl.description - from sim_locationsx sl + from sim_locationsx sl, + acs_object_types ot where in_directory_p = 't' + and ot.object_type = sl.object_type UNION select sc.object_id, sc.object_type, + ot.pretty_name as object_type_pretty, sc.title, sc.mime_type, sc.name, sc.item_id, sc.description - from sim_charactersx sc + from sim_charactersx sc, + acs_object_types ot where in_directory_p = 't' + and ot.object_type = sc.object_type [template::list::orderby_clause -orderby -name "objects"] " { Index: openacs-4/packages/simulation/tcl/object-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/simulation/tcl/object-procs.tcl,v diff -u -r1.7 -r1.8 --- openacs-4/packages/simulation/tcl/object-procs.tcl 15 Dec 2003 15:28:20 -0000 1.7 +++ openacs-4/packages/simulation/tcl/object-procs.tcl 12 Jan 2004 15:56:58 -0000 1.8 @@ -67,7 +67,7 @@ and ancestor_type = 'content_revision' }] - # LARS TODO: We need to be able to scope this to a package, + # TODO B: We need to be able to scope this to a package, # possibly filter by other things, control the sort order, # we need to be able to control what the label looks like (e.g. include email for users) # and it needs to be intelligent about scaling issues Index: openacs-4/packages/simulation/tcl/template-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/simulation/tcl/template-procs.tcl,v diff -u -r1.41 -r1.42 --- openacs-4/packages/simulation/tcl/template-procs.tcl 12 Jan 2004 11:06:17 -0000 1.41 +++ openacs-4/packages/simulation/tcl/template-procs.tcl 12 Jan 2004 15:56:58 -0000 1.42 @@ -83,6 +83,7 @@ if { [empty_string_p $row($attr)] } { set $varname [db_null] } else { + # TODO B: need better tests for duration before passing it into the database. set $varname "interval '[db_quote $row($attr)]'" } } @@ -496,11 +497,10 @@ enroll_end, and enroll_start properties to reflect an immediate start and then directly invoking simulation::template::start. - TODO: make sure the sweeper doesn't pick up simulations that - have been forced to start. - @author Peter Marklund } { + # TODO (.25h): make sure the sweeper doesn't pick up simulations that have been forced to start. + simulation::template::get -workflow_id $workflow_id -array simulation db_transaction { @@ -531,10 +531,10 @@ Make a simulation go live. Does enrollment and casting and sets sim_type attribute to live_sim. - TODO: invoke this proc from a sweep - @author Peter Marklund } { + # TODO (.25h): invoke this proc from a sweep + simulation::template::get -workflow_id $workflow_id -array simulation if { ![string equal $simulation(sim_type) "casting_sim"] } { @@ -566,14 +566,12 @@ Takes a mapped simulation template and converts it into a cast simulation with simulation cases. This procedure expects to be called after enrollment is complete. - TODO: agent support - - TODO: taking actor type into account - - TODO: other casting_type values than auto - @author Peter Marklund } { + # TODO: taking actor type into account -- LARS: What is this? Setting to 2h to be safe (I think) + + # TODO: other casting_type values than auto -- LARS: Why would we then do autocast, if casting_type is not auto? + simulation::template::role_party_mappings \ -workflow_id $workflow_id \ -array roles @@ -674,7 +672,7 @@ {-package_key:required} {-object_id:required} } { - Create a new simulation template. TODO: need better tests for duration before passing it into the database. + Create a new simulation template. @return The workflow_id of the created simulation. @@ -831,7 +829,7 @@ } { simulation::template::get -workflow_id $workflow_id -array sim_template - # TODO: Refactor + # TODO (1.5h): Refactor this and the corresponding wizard.tcl/adp page # What we really need to know is whether each step is complete # They're all independent of each other, except for casting, which is dependent on participants. Index: openacs-4/packages/simulation/www/index.adp =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/simulation/www/index.adp,v diff -u -r1.28 -r1.29 --- openacs-4/packages/simulation/www/index.adp 8 Jan 2004 14:24:44 -0000 1.28 +++ openacs-4/packages/simulation/www/index.adp 12 Jan 2004 15:52:44 -0000 1.29 @@ -2,22 +2,22 @@ @page_title;noquote@ @context;noquote@ - + - + - +