Index: openacs-4/packages/general-comments/tcl/general-comments-procs-oracle.xql
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/general-comments/tcl/general-comments-procs-oracle.xql,v
diff -u -r1.6 -r1.7
--- openacs-4/packages/general-comments/tcl/general-comments-procs-oracle.xql 13 Jan 2005 13:58:21 -0000 1.6
+++ openacs-4/packages/general-comments/tcl/general-comments-procs-oracle.xql 24 Jan 2005 00:29:38 -0000 1.7
@@ -11,8 +11,7 @@
r.mime_type,
o.creation_user,
acs_object.name(o.creation_user) as author,
- to_char(o.creation_date, 'MM-DD-YYYY') as pretty_date,
- to_char(o.creation_date, 'Month DD, YYYY HH12:MI PM') as pretty_date2
+ o.creation_date
$content_select
from general_comments g,
cr_revisions r,
Index: openacs-4/packages/general-comments/tcl/general-comments-procs-postgresql.xql
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/general-comments/tcl/general-comments-procs-postgresql.xql,v
diff -u -r1.6 -r1.7
--- openacs-4/packages/general-comments/tcl/general-comments-procs-postgresql.xql 13 Jan 2005 13:58:21 -0000 1.6
+++ openacs-4/packages/general-comments/tcl/general-comments-procs-postgresql.xql 24 Jan 2005 00:29:38 -0000 1.7
@@ -11,8 +11,7 @@
r.mime_type,
o.creation_user,
acs_object__name(o.creation_user) as author,
- to_char(o.creation_date, 'MM-DD-YYYY') as pretty_date,
- to_char(o.creation_date, 'Month DD, YYYY HH12:MI PM') as pretty_date2
+ o.creation_date
$content_select
from general_comments g,
cr_revisions r,
Index: openacs-4/packages/general-comments/tcl/general-comments-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/general-comments/tcl/general-comments-procs.tcl,v
diff -u -r1.16 -r1.17
--- openacs-4/packages/general-comments/tcl/general-comments-procs.tcl 13 Jan 2005 13:58:21 -0000 1.16
+++ openacs-4/packages/general-comments/tcl/general-comments-procs.tcl 24 Jan 2005 00:29:38 -0000 1.17
@@ -131,6 +131,8 @@
set html ""
db_foreach get_comments {} {
+ set pretty_date [lc_time_fmt $creation_date %x]
+ set pretty_date2 [lc_time_fmt $creation_date "%q %X"]
# call on helper proc to print out comment
append html [general_comments_print_comment $comment_id $title $mime_type \
$creation_user $author $pretty_date $pretty_date2 $content \
Index: openacs-4/packages/general-comments/www/index-oracle.xql
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/general-comments/www/Attic/index-oracle.xql,v
diff -u -r1.1 -r1.2
--- openacs-4/packages/general-comments/www/index-oracle.xql 14 Jun 2001 19:52:22 -0000 1.1
+++ openacs-4/packages/general-comments/www/index-oracle.xql 24 Jan 2005 00:29:38 -0000 1.2
@@ -12,7 +12,7 @@
o.creation_user,
decode(i.live_revision,null,0,1) as live_version_p,
decode(i.live_revision,r.revision_id,1,0) as approved_p,
- to_char(o.creation_date, 'MM-DD-YYYY HH12:MI:AM') as pretty_date
+ o.creation_date
from general_comments g,
cr_items i,
cr_revisions r,
Index: openacs-4/packages/general-comments/www/index-postgresql.xql
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/general-comments/www/Attic/index-postgresql.xql,v
diff -u -r1.2 -r1.3
--- openacs-4/packages/general-comments/www/index-postgresql.xql 15 Nov 2002 11:16:55 -0000 1.2
+++ openacs-4/packages/general-comments/www/index-postgresql.xql 24 Jan 2005 00:29:38 -0000 1.3
@@ -12,7 +12,6 @@
o.creation_user,
case when i.live_revision=null then 0 else 1 end as live_version_p,
case when i.live_revision=r.revision_id then 0 else 1 end as approved_p,
- to_char(o.creation_date, 'MM-DD-YYYY HH12:MI:AM') as pretty_date,
o.creation_date
from general_comments g,
cr_items i,
Index: openacs-4/packages/general-comments/www/index.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/general-comments/www/index.tcl,v
diff -u -r1.4 -r1.5
--- openacs-4/packages/general-comments/www/index.tcl 7 Nov 2002 08:32:49 -0000 1.4
+++ openacs-4/packages/general-comments/www/index.tcl 24 Jan 2005 00:29:38 -0000 1.5
@@ -45,44 +45,23 @@
# ad_table definition
set table_def [list \
- [list num "[_ general-comments.Num]" {} {| $Tcount | }] \
- [list comment_id "[_ general-comments.ID]" {} \
- {$comment_id | }] \
- [list title "[_ general-comments.Title_1]" {} {}] \
- [list approved_p "[_ general-comments.Approved]" {} 01] \
- [list live_version_p "[_ general-comments.Has_live_version]" {} 01] \
- [list pretty_date "[_ general-comments.Last_Modified]" {creation_date $order} {}] \
+ [list num "[_ general-comments.Num]" {} {$Tcount | }] \
+ [list comment_id "[_ general-comments.ID]" {} \
+ {$comment_id | }] \
+ [list title "[_ general-comments.Title_1]" {} {}] \
+ [list approved_p "[_ general-comments.Approved]" {} 01] \
+ [list live_version_p "[_ general-comments.Has_live_version]" {} 01] \
+ [list pretty_date "[_ general-comments.Last_Modified]" {creation_date $order} {[lc_time_fmt $creation_date "%x %X" en_GB] | }] \
]
-
-# sql to retrieve comments
-set sql "
- select g.comment_id,
- r.title,
- acs_object.name(o.creation_user) as author,
- o.creation_user,
- decode(i.live_revision,null,0,1) as live_version_p,
- decode(i.live_revision,r.revision_id,1,0) as approved_p,
- to_char(o.creation_date, 'MM-DD-YYYY HH12:MI:AM') as pretty_date
- from general_comments g,
- cr_items i,
- cr_revisions r,
- acs_objects o
- where g.comment_id = i.item_id and
- r.revision_id = o.object_id and
- r.revision_id = content_item.get_latest_revision(g.comment_id) and
- o.creation_user = :user_id
- [ad_dimensional_sql $dimensional]
- [ad_order_by_from_sort_spec $orderby $table_def]
-"
# create the table to display the comments
set bind_ns_set [ad_tcl_vars_to_ns_set user_id]
set extra_var_list [list return_url $return_url]
set comments_table [ad_table -Torderby $orderby \
- -Tmissing_text "[_ general-comments.lt_No_comments_available]" \
- -Textra_vars $extra_var_list \
- -bind $bind_ns_set \
- comments_select $sql $table_def]
+ -Tmissing_text "[_ general-comments.lt_No_comments_available]" \
+ -Textra_vars $extra_var_list \
+ -bind $bind_ns_set \
+ comments_select {} $table_def]
set page_title "[_ general-comments.General_Comments]"
set context {}