Index: openacs-4/packages/lors-central/tcl/lors-central-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/lors-central/tcl/lors-central-procs.tcl,v diff -u -r1.4 -r1.5 --- openacs-4/packages/lors-central/tcl/lors-central-procs.tcl 9 Feb 2009 03:57:30 -0000 1.4 +++ openacs-4/packages/lors-central/tcl/lors-central-procs.tcl 4 Apr 2018 20:29:27 -0000 1.5 @@ -41,7 +41,7 @@ @check_inst Set it to "t" if you want to check if the user_id that watch's this page is an dotlrn instructor. } { - if { ![info exist user_id] } { + if { ![info exists user_id] } { set user_id [ad_conn user_id] } set package_id [ad_conn package_id] @@ -928,7 +928,7 @@ set item_id [lindex $item 0] set indent [expr [lindex $item 1] + 1] db_foreach get_items { } { - if { ![info exist items_array($ims_item_id)] } { + if { ![info exists items_array($ims_item_id)] } { lappend items_list [list $ims_item_id $indent] set items_array($ims_item_id) $indent incr count Index: openacs-4/packages/lors-central/www/change-lo-version.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/lors-central/www/change-lo-version.tcl,v diff -u -r1.2 -r1.3 --- openacs-4/packages/lors-central/www/change-lo-version.tcl 31 May 2005 22:57:22 -0000 1.2 +++ openacs-4/packages/lors-central/www/change-lo-version.tcl 4 Apr 2018 20:29:27 -0000 1.3 @@ -1,6 +1,6 @@ ad_page_contract { - Change the live revision to revision_id - + Change the live revision to revision_id + @author Miguel Marin (miguelmarin@viaro.net) @author Viaro Networks www.viaro.net @creation_date 28-03-2005 @@ -15,7 +15,7 @@ # Checking privilege over lors-central lors_central::check_permissions -if { ![info exist name] } { +if { ![info exists name] } { set name [db_string get_name { select item_title from ims_cp_items where ims_item_id = :ims_item_id }] } @@ -35,4 +35,4 @@ } } -ad_returnredirect "one-learning-object?ims_item_id=$ims_item_id&man_id=$man_id&name=$name" \ No newline at end of file +ad_returnredirect "one-learning-object?ims_item_id=$ims_item_id&man_id=$man_id&name=$name" Index: openacs-4/packages/lors-central/www/course-add-2.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/lors-central/www/course-add-2.tcl,v diff -u -r1.2 -r1.3 --- openacs-4/packages/lors-central/www/course-add-2.tcl 31 May 2005 22:57:22 -0000 1.2 +++ openacs-4/packages/lors-central/www/course-add-2.tcl 4 Apr 2018 20:29:27 -0000 1.3 @@ -30,7 +30,7 @@ lors_central::check_permissions # To support versions -if { ![info exist man_id] } { +if { ![info exists man_id] } { set man_id "" } Index: openacs-4/packages/lors-central/www/course-dotlrn-assoc.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/lors-central/www/course-dotlrn-assoc.tcl,v diff -u -r1.4 -r1.5 --- openacs-4/packages/lors-central/www/course-dotlrn-assoc.tcl 9 Feb 2009 03:57:30 -0000 1.4 +++ openacs-4/packages/lors-central/www/course-dotlrn-assoc.tcl 4 Apr 2018 20:29:27 -0000 1.5 @@ -14,7 +14,7 @@ set title [_ lors-central.associate_to] # Get the item_id that the manifest_id has associated -if { ![info exist item_id] } { +if { ![info exists item_id] } { set item_id [lors_central::get_item_id -revision_id $man_id] set context [list [list "one-course-associations?man_id=$man_id" [_ lors-central.one_course_assoc]] \ [_ lors-central.associate_to]] Index: openacs-4/packages/lors-central/www/course-versions.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/lors-central/www/course-versions.tcl,v diff -u -r1.2 -r1.3 --- openacs-4/packages/lors-central/www/course-versions.tcl 31 May 2005 22:57:22 -0000 1.2 +++ openacs-4/packages/lors-central/www/course-versions.tcl 4 Apr 2018 20:29:27 -0000 1.3 @@ -13,7 +13,7 @@ lors_central::check_permissions -if { ![info exist item_id ] } { +if { ![info exists item_id ] } { set item_id [lors_central::get_item_id -revision_id $man_id] set context [list [list "one-course?man_id=$man_id" \ [_ lors-central.one_course]] [_ lorsm.lt_one_course_versions]] Index: openacs-4/packages/lors-central/www/index.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/lors-central/www/index.tcl,v diff -u -r1.2 -r1.3 --- openacs-4/packages/lors-central/www/index.tcl 31 May 2005 22:57:22 -0000 1.2 +++ openacs-4/packages/lors-central/www/index.tcl 4 Apr 2018 20:29:27 -0000 1.3 @@ -19,7 +19,7 @@ # To search courses -if { [info exist keyword] } { +if { [info exists keyword] } { if { [string equal $keyword [_ lors-central.please_type]] } { set extra_query "" } else { Index: openacs-4/packages/lors-central/www/one-course-associations.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/lors-central/www/one-course-associations.tcl,v diff -u -r1.4 -r1.5 --- openacs-4/packages/lors-central/www/one-course-associations.tcl 22 Jan 2007 08:09:25 -0000 1.4 +++ openacs-4/packages/lors-central/www/one-course-associations.tcl 4 Apr 2018 20:29:27 -0000 1.5 @@ -15,7 +15,7 @@ lors_central::check_permissions # Get the item_id that the manifest_id has associated -if { ![info exist item_id] } { +if { ![info exists item_id] } { set item_id [lors_central::get_item_id -revision_id $man_id] } Index: openacs-4/packages/lors-central/www/one-course-views.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/lors-central/www/one-course-views.tcl,v diff -u -r1.2 -r1.3 --- openacs-4/packages/lors-central/www/one-course-views.tcl 31 May 2005 22:57:22 -0000 1.2 +++ openacs-4/packages/lors-central/www/one-course-views.tcl 4 Apr 2018 20:29:27 -0000 1.3 @@ -10,7 +10,7 @@ lors_central::check_permissions # Get the item_id that the manifest_id has associated -if { ![info exist item_id] } { +if { ![info exists item_id] } { set item_id [lors_central::get_item_id -revision_id $man_id] } Index: openacs-4/packages/lors-central/www/one-course.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/lors-central/www/one-course.tcl,v diff -u -r1.2 -r1.3 --- openacs-4/packages/lors-central/www/one-course.tcl 31 May 2005 22:57:22 -0000 1.2 +++ openacs-4/packages/lors-central/www/one-course.tcl 4 Apr 2018 20:29:27 -0000 1.3 @@ -5,13 +5,13 @@ man_id:integer,optional } -if { ![info exist item_id] && ![info exist man_id] } { +if { ![info exists item_id] && ![info exists man_id] } { ad_return_complaint 1 "You must pass either item_id or man_id" } else { - if { ![info exist man_id] } { + if { ![info exists man_id] } { set man_id [content::item::get_live_revision -item_id $item_id] } - if { ![info exist item_id] } { + if { ![info exists item_id] } { set item_id [lors_central::get_item_id -revision_id $man_id] } } Index: openacs-4/packages/lors-central/www/lc-admin/grant-permissions.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/lors-central/www/lc-admin/grant-permissions.tcl,v diff -u -r1.1 -r1.2 --- openacs-4/packages/lors-central/www/lc-admin/grant-permissions.tcl 31 May 2005 23:00:53 -0000 1.1 +++ openacs-4/packages/lors-central/www/lc-admin/grant-permissions.tcl 4 Apr 2018 20:29:27 -0000 1.2 @@ -14,7 +14,7 @@ # To search courses -if { [info exist keyword] } { +if { [info exists keyword] } { if { [string equal $keyword [_ lors-central.please_type]] } { set extra_query "" } else { Index: openacs-4/packages/lors-central/www/lc-admin/grant.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/lors-central/www/lc-admin/grant.tcl,v diff -u -r1.1 -r1.2 --- openacs-4/packages/lors-central/www/lc-admin/grant.tcl 31 May 2005 23:00:53 -0000 1.1 +++ openacs-4/packages/lors-central/www/lc-admin/grant.tcl 4 Apr 2018 20:29:27 -0000 1.2 @@ -15,7 +15,7 @@ lors_central::check_permissions -check_inst t -if { [info exist class_com_id] } { +if { [info exists class_com_id] } { # Grant admin privilige to all users in this class or community db_foreach get_all_members { } { permission::grant -party_id $user_id -object_id $man_id -privilege "admin" Index: openacs-4/packages/lors-central/www/lc-admin/revoke.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/lors-central/www/lc-admin/revoke.tcl,v diff -u -r1.1 -r1.2 --- openacs-4/packages/lors-central/www/lc-admin/revoke.tcl 31 May 2005 23:00:53 -0000 1.1 +++ openacs-4/packages/lors-central/www/lc-admin/revoke.tcl 4 Apr 2018 20:29:27 -0000 1.2 @@ -15,7 +15,7 @@ lors_central::check_permissions -check_inst t -if { [info exist class_com_id] } { +if { [info exists class_com_id] } { # Grant admin privilige to all users in this class or community db_foreach get_all_members { } { if { ![lors_central::owner -user_id $user_id -object_id $man_id] } { Index: openacs-4/packages/imsld/tcl/imsld-condition-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/imsld/tcl/imsld-condition-procs.tcl,v diff -u -r1.31 -r1.32 --- openacs-4/packages/imsld/tcl/imsld-condition-procs.tcl 13 Jan 2010 16:07:26 -0000 1.31 +++ openacs-4/packages/imsld/tcl/imsld-condition-procs.tcl 4 Apr 2018 20:29:49 -0000 1.32 @@ -17,7 +17,7 @@ -user_id } { } { - if {![info exist user_id]} { + if {![info exists user_id]} { set user_id [ad_conn user_id] } @@ -44,7 +44,7 @@ } { upvar recursivity_count recursivity_count - if {![info exist user_id]} { + if {![info exists user_id]} { set user_id [ad_conn user_id] } set ifNodes [$condition selectNodes {*[local-name()='if']}] @@ -415,7 +415,7 @@ -user_id } { } { - if {![info exist user_id]} { + if {![info exists user_id]} { set user_id [ad_conn user_id] } foreach expressionNode $expression { @@ -648,7 +648,7 @@ } { upvar recursivity_count recursivity_count - if {![info exist user_id]} { + if {![info exists user_id]} { set user_id [ad_conn user_id] } ns_log Debug "statement::execute with user_id: $user_id" Index: openacs-4/packages/imsld/tcl/imsld-gsi-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/imsld/tcl/imsld-gsi-procs.tcl,v diff -u -r1.3 -r1.4 --- openacs-4/packages/imsld/tcl/imsld-gsi-procs.tcl 28 Mar 2018 23:36:17 -0000 1.3 +++ openacs-4/packages/imsld/tcl/imsld-gsi-procs.tcl 4 Apr 2018 20:29:49 -0000 1.4 @@ -73,7 +73,7 @@ where gt.gsi_trigger_id=gfu.gsi_trigger_id and gt.trigger_type=:trigger }] - if {[info exist run_id]} { + if {[info exists run_id]} { set services_in_run [imsld::gsi::get_services_in_run -run_id $run_id] if {[llength $full_actions_list] && [llength $services_in_run]} { set actions_list [db_list get_matching_actions " @@ -839,7 +839,7 @@ @param gservice_id "The service_id to be configured" } { - if {![info exist gservice_id]} { + if {![info exists gservice_id]} { #FIXME:we can obtain gservice_id because all of them belongs to the same service, obviously there's only one service #what happens when more than a service appear? #just an idea (I have no time to think more on this): a db_list and a foreach can solve the problem @@ -851,7 +851,7 @@ group by gservice_id" } - if {![info exist multiplicity]} { + if {![info exists multiplicity]} { db_1row get_service_multiplicity { select c.multiplicity as multiplicity from imsld_gsi_services s, @@ -861,7 +861,7 @@ } } - if {![info exist plugin_URI]} { + if {![info exists plugin_URI]} { db_1row get_plugin_URI { select plugin_uri as plugin_URI from imsld_gsi_service_status @@ -897,10 +897,10 @@ Receive a node external-value dom node and a run_id and call the proper plugin to obtain the value from the service. The meaning of the attributes depends on the handler plugin } { - if {![info exist user_id]} { + if {![info exists user_id]} { set user_id [ad_conn user_id] } - if {![info exist gservice_id]} { + if {![info exists gservice_id]} { #Given the serviceref, whe can obtain the service_id, since we also have the run_id #Note: there can be more than one service with the same identifier (form different UoLs), # so the run_id is used to guarantee uniqueness @@ -913,7 +913,7 @@ } } - if {![info exist multiplicity]} { + if {![info exists multiplicity]} { db_1row get_service_multiplicity { select c.multiplicity as multiplicity from imsld_gsi_services s, @@ -923,7 +923,7 @@ } } - if {![info exist plugin_URI]} { + if {![info exists plugin_URI]} { db_1row get_plugin_URI { select plugin_uri as plugin_URI from imsld_gsi_service_status Index: openacs-4/packages/imsld/tcl/imsld-parse-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/imsld/tcl/imsld-parse-procs.tcl,v diff -u -r1.85 -r1.86 --- openacs-4/packages/imsld/tcl/imsld-parse-procs.tcl 29 Mar 2018 22:49:53 -0000 1.85 +++ openacs-4/packages/imsld/tcl/imsld-parse-procs.tcl 4 Apr 2018 20:29:49 -0000 1.86 @@ -718,7 +718,7 @@ # This callback gets the href of the imported content (if some package imported it) #revoke permissions until first usage of resources - if {[info exist acs_object_id]} { + if {[info exists acs_object_id]} { permission::set_not_inherit -object_id $acs_object_id } @@ -1765,7 +1765,7 @@ } #revoke read permissions until first usage - if {[info exist acs_object_id]} { + if {[info exists acs_object_id]} { permission::set_not_inherit -object_id $acs_object_id } return $acs_object_id @@ -2124,7 +2124,7 @@ # an error happened, abort and return the list whit the error return $item_list } - if { ![info exist role_id] } { + if { ![info exists role_id] } { set role_id ""; } # create the monitor service Index: openacs-4/packages/imsld/tcl/imsld-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/imsld/tcl/imsld-procs.tcl,v diff -u -r1.125 -r1.126 --- openacs-4/packages/imsld/tcl/imsld-procs.tcl 27 Mar 2018 17:08:50 -0000 1.125 +++ openacs-4/packages/imsld/tcl/imsld-procs.tcl 4 Apr 2018 20:29:49 -0000 1.126 @@ -4724,7 +4724,7 @@ @author Luis de la Fuente Valentín (lfuente@it.uc3m.es) } { - if {[info exist play_id] & ![info exist imsld_id]} { + if {[info exists play_id] & ![info exists imsld_id]} { set imsld_id [db_string get_imsld_id_from_play { select iii.item_id from imsld_imsldsi iii, Index: openacs-4/packages/imsld/tcl/imsld-roles-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/imsld/tcl/imsld-roles-procs.tcl,v diff -u -r1.19 -r1.20 --- openacs-4/packages/imsld/tcl/imsld-roles-procs.tcl 17 Jun 2009 08:00:01 -0000 1.19 +++ openacs-4/packages/imsld/tcl/imsld-roles-procs.tcl 4 Apr 2018 20:29:50 -0000 1.20 @@ -39,7 +39,7 @@ #map role with group set rel_id [relation_add imsld_role_group_rel $role_item_id $group_id] #map group with his parent (composition_rel) - if {[info exist parent_group_id] } { + if {[info exists parent_group_id] } { relation_add composition_rel $parent_group_id $group_id } #map group with the run @@ -272,7 +272,7 @@ Returns a list with all the roles_id from which the user are member. If run_id is given, restrict the list to the roles of the run. } { set roles_list [list] - if {[info exist run_id]} { + if {[info exists run_id]} { set roles_list [db_list get_user_roles_list {}] } else { set roles_list [db_list get_raw_user_roles_list {}] @@ -287,7 +287,7 @@ Returns a list with all the users in a role. If run_id is given, restrict the list to the roles of the run. } { - if {[info exist run_id]} { + if {[info exists run_id]} { set groups_list [db_list get_groups_in_run { select ar1.object_id_two as groups from acs_rels ar1, @@ -334,7 +334,7 @@ } { Returns the role_id which has a given ref in a run or imsld, 0 if no matches found. } { - if {[info exist imsld_id]} { + if {[info exists imsld_id]} { if { [db_0or1row select_role_id_from_imsld { select role_id from imsld_roles ir, @@ -345,7 +345,7 @@ }]} { return $role_id } - } elseif { [info exist run_id] } { + } elseif { [info exists run_id] } { if { [db_0or1row select_role_id_from_run { select iri.role_id from imsld_rolesi iri, @@ -418,7 +418,7 @@ set role_item_id [content::revision::item_id -revision_id $role_id] set rel_id [relation_add imsld_role_group_rel $role_item_id $group_id] #map group with his parent (composition_rel) - if {[info exist parent_group_id] } { + if {[info exists parent_group_id] } { relation_add composition_rel $parent_group_id $group_id } #map group with the run Index: openacs-4/packages/imsld/tcl/imsld-runtime-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/imsld/tcl/imsld-runtime-procs.tcl,v diff -u -r1.24 -r1.25 --- openacs-4/packages/imsld/tcl/imsld-runtime-procs.tcl 28 Mar 2018 23:36:17 -0000 1.24 +++ openacs-4/packages/imsld/tcl/imsld-runtime-procs.tcl 4 Apr 2018 20:29:50 -0000 1.25 @@ -483,7 +483,7 @@ mark an environment as shown or hidden. NOTE: not recursively } { - if {![info exist user_id]} { + if {![info exists user_id]} { set user_id [ad_conn user_id] } # according to the spec, the environments doesn't have any isvisible attribute @@ -532,7 +532,7 @@ } { mark an activity structure as show or hidden. } { - if {![info exist user_id]} { + if {![info exists user_id]} { set user_id [ad_conn user_id] } Index: openacs-4/packages/imsld/www/admin/imsld-create-instance.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/imsld/www/admin/imsld-create-instance.tcl,v diff -u -r1.6 -r1.7 --- openacs-4/packages/imsld/www/admin/imsld-create-instance.tcl 17 Apr 2008 17:17:54 -0000 1.6 +++ openacs-4/packages/imsld/www/admin/imsld-create-instance.tcl 4 Apr 2018 20:29:50 -0000 1.7 @@ -28,7 +28,7 @@ ad_script_abort } -if {[info exist parent_group_id] } { +if {[info exists parent_group_id] } { set new_instance [imsld::roles::create_instance -role_id $role -parent_group_id $parent_group_id -run_id $run_id] ad_returnredirect [export_vars -base imsld-admin-roles {{role $role} {imsld_id $imsld_id} {run_id $run_id} {group_instance $new_instance}}] } elseif { ![db_0or1row has_role_parent_p {}] } { Index: openacs-4/packages/imsld/www/admin/imsld-role-members.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/imsld/www/admin/imsld-role-members.tcl,v diff -u -r1.12 -r1.13 --- openacs-4/packages/imsld/www/admin/imsld-role-members.tcl 29 Oct 2009 11:09:59 -0000 1.12 +++ openacs-4/packages/imsld/www/admin/imsld-role-members.tcl 4 Apr 2018 20:29:50 -0000 1.13 @@ -35,7 +35,7 @@ set group_title [group::title -group_id $group_instance] if {![string eq $group_instance "0"] && [db_0or1row has_role_parent_p {}]} { - if {![info exist members_list]} { + if {![info exists members_list]} { set members_list [db_list get_members_list_2 {}] } if {![llength $members_list]} { @@ -49,7 +49,7 @@ } else { - if {![info exist members_list]} { + if {![info exists members_list]} { set members_list [db_list get_members_list {}] }