Index: openacs-4/packages/photo-album/tcl/photo-album-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/photo-album/tcl/photo-album-procs.tcl,v diff -u -r1.27 -r1.28 --- openacs-4/packages/photo-album/tcl/photo-album-procs.tcl 9 May 2018 15:33:33 -0000 1.27 +++ openacs-4/packages/photo-album/tcl/photo-album-procs.tcl 14 Aug 2018 19:46:26 -0000 1.28 @@ -79,7 +79,7 @@ # grant default permissions to new root folder - # default permissions stored in package parmeter as a list of grantee privilege pairs + # default permissions stored in package parameter as a list of grantee privilege pairs # the grantee can be anything that is or returns a party_id such as an integer, a subquery, # or a function @@ -568,7 +568,7 @@ link {what {}} } { - given a current photo_id and and an ordered list of all the photo_id in an album + given a current photo_id and an ordered list of all the photo_id in an album creates an html fragment that allows user to navigate to any photo by number next/previous } { @@ -655,7 +655,7 @@ set type "Unknown type" } - # DRB: on Mac OS X the "verify" option to tar appears to return the file + # DRB: on macOS the "verify" option to tar appears to return the file # list on stderr rather than stdout, causing the catch to trigger. Non-GNU # versions of tar don't understand fancy options (those starting with --) Index: openacs-4/packages/photo-album/tcl/photo-album-search-procs.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/photo-album/tcl/photo-album-search-procs.tcl,v diff -u -r1.2 -r1.3 --- openacs-4/packages/photo-album/tcl/photo-album-search-procs.tcl 26 Jul 2004 13:07:42 -0000 1.2 +++ openacs-4/packages/photo-album/tcl/photo-album-search-procs.tcl 14 Aug 2018 19:46:26 -0000 1.3 @@ -39,7 +39,7 @@ } ad_proc -private photo_album::search::album::url { album_id } { - returns a url for a message to the search package + returns a URL for a message to the search package @param album_id - either a revision_id or an item_id for an album @@ -116,7 +116,7 @@ } ad_proc -private photo_album::search::photo::url { photo_id } { - returns a url for a message to the search package + returns a URL for a message to the search package @param photo_id - either a revision_id or an item_id for an album Index: openacs-4/packages/photo-album/www/doc/design.adp =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/photo-album/www/doc/design.adp,v diff -u -r1.4 -r1.5 --- openacs-4/packages/photo-album/www/doc/design.adp 26 May 2017 18:05:37 -0000 1.4 +++ openacs-4/packages/photo-album/www/doc/design.adp 14 Aug 2018 19:46:26 -0000 1.5 @@ -142,7 +142,7 @@ two different content types (pa_photos and pa_images). The linkage between the binaries and the attribute info is maintained as a relationship between the two content_items. This decision was made -so the the number of image sizes per photo could be changed with +so the number of image sizes per photo could be changed with minor code revision and no datamodel changes. This flexibility comes at a cost, the queries to retrieve and serve the appropriate version of a photo need to join in several tables to do so. There @@ -381,23 +381,17 @@ folder_id {package_id ""} Returns "t" if folder_id is a folder that is a child of the root folder for the package, else "f". If package_id is not given procedure -uses value from - [ad_conn -package_id].

  • +uses value from [ad_conn package_id].

  • pa_is_album_p album_id {package_id ""} Returns "t" if album_id is a album that is a child of the root folder for the package, else "f" If package_id is not given procedure -uses value from - [ad_conn -package_id].

  • +uses value from [ad_conn package_id].

  • pa_is_photo_p photo_id {package_id ""} Returns "t" if photo_id is a photo that is a child of the root folder for the package, else "f" If package_id is not given procedure -uses value from - [ad_conn -package_id].

  • +uses value from [ad_conn package_id].

  • pa_grant_privilege_to_creator object_id {user_id ""} Grants a set of default privileges stored in parameter PrivilegeForCreator on object id to user_id. If user_id @@ -407,7 +401,7 @@ height in pixels of filename. Sets height to the variable named in height_var in the calling level. Sets width_var to the variable named in width_var in the calling level. I Use ImageMagick instead -of aolsever funcition because it can handle more than just gifs and +of AOLserver function because it can handle more than just gifs and jpegs.

  • pa_make_new_image base_image new_image max_width {max_height ""} Uses @@ -438,7 +432,7 @@ total_pages Returns html table fragament for navigating pages of an album.

  • pa_photo_number_links cur_id all_ids Given a -current photo_id and and an ordered list of all the photo_id in an +current photo_id and an ordered list of all the photo_id in an album, creates an html fragment that allows user to navigate to any photo by number, or next/previous. Pulls url from connection so should work on page showing a single photo based on photo_id (such @@ -529,7 +523,7 @@

    If set to "t", the images/index.vuh file runs a query to check if user has read access to photo prior to serving it. Note, setting to "t" can impact -performance on high volume sites. The urls for images also change +performance on high volume sites. The URLs for images also change depending on this parameter. If "t" url contains the pa_image_id, else contains the path to the pa_image in file-system.

    Default: f

    Index: openacs-4/packages/photo-album/www/doc/design.html =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/photo-album/www/doc/design.html,v diff -u -r1.2 -r1.3 --- openacs-4/packages/photo-album/www/doc/design.html 26 May 2017 18:05:37 -0000 1.2 +++ openacs-4/packages/photo-album/www/doc/design.html 14 Aug 2018 19:46:26 -0000 1.3 @@ -360,7 +360,7 @@ two different content types (pa_photos and pa_images). The linkage between the binaries and the attribute info is maintained as a relationship between the two content_items. This decision was made - so the the number of image sizes per photo could be changed with minor + so the number of image sizes per photo could be changed with minor code revision and no datamodel changes. This flexibility comes at a cost, the queries to retrieve and serve the appropriate version of a photo need to join in several tables to do so. There also is not @@ -781,7 +781,7 @@ Sets height to the variable named in height_var in the calling level. Sets width_var to the variable named in width_var in the calling level. - I Use ImageMagick instead of aolsever funcition because it can handle more than + I Use ImageMagick instead of AOLserver function because it can handle more than just gifs and jpegs.

    • pa_photo_number_links cur_id all_ids - Given a current photo_id and and an ordered list of all the photo_id in an album, + Given a current photo_id and an ordered list of all the photo_id in an album, creates an html fragment that allows user to navigate to any photo by number, or next/previous. Pulls url from connection so should work on page showing a single photo based on photo_id (such as viewer size display page or base size display page). @@ -1132,7 +1132,7 @@ CLASS="listitem" > If set to "t", the images/index.vuh file runs a query to check if user has read access to photo prior to serving it. Note, setting to - "t" can impact performance on high volume sites. The urls for images + "t" can impact performance on high volume sites. The URLs for images also change depending on this parameter. If "t" url contains the pa_image_id, else contains the path to the pa_image in file-system.

  • Minor revisions to plsql packages to improve compatibility with acs-content-repository.

  • Added more detailed documentation in both html and docbook format.

  • Fixed name conflicts with photo album lite.

    • -

    Besides upgrading the rest of your acs intall to 4.1.1, you will -need to mannually run photo-album/sql/plsql-packages.sql through +

    Besides upgrading the rest of your acs install to 4.1.1, you will +need to manually run photo-album/sql/plsql-packages.sql through sqlplus to update the packages inside oracle when upgrading from the beta to final version of the photo-album.

    Index: openacs-4/packages/photo-album/www/doc/release-notes.html =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/photo-album/www/doc/release-notes.html,v diff -u -r1.2 -r1.3 --- openacs-4/packages/photo-album/www/doc/release-notes.html 26 May 2017 18:05:37 -0000 1.2 +++ openacs-4/packages/photo-album/www/doc/release-notes.html 14 Aug 2018 19:46:26 -0000 1.3 @@ -147,7 +147,7 @@ >

    Besides upgrading the rest of your acs intall to 4.1.1, you will need to mannually run +>Besides upgrading the rest of your acs install to 4.1.1, you will need to manually run photo-album/sql/plsql-packages.sql