Index: openacs-4/packages/assessment/lib/assessment.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/lib/assessment.tcl,v
diff -u -r1.34 -r1.35
--- openacs-4/packages/assessment/lib/assessment.tcl	3 Sep 2024 15:37:35 -0000	1.34
+++ openacs-4/packages/assessment/lib/assessment.tcl	9 Oct 2024 14:21:40 -0000	1.35
@@ -448,11 +448,9 @@
     set max_time_to_complete [as::assessment::pretty_time -seconds $max_time_to_complete]
 
     if {$presentation_type eq "rb" || $presentation_type eq "cb"} {
-        array set item [as::item::item_data -as_item_id $as_item_id]
-        array set type [as::item_display_$presentation_type\::data -type_id $item(display_type_id)]
-        set choice_orientation $type(choice_orientation)
-        array unset item
-        array unset type
+        set item [as::item::item_data -as_item_id $as_item_id]
+        set type [as::item_display_$presentation_type\::data -type_id [dict get $item display_type_id]]
+        set choice_orientation [dict get $type choice_orientation]
     } else {
         set choice_orientation ""
     }
Index: openacs-4/packages/assessment/lib/section-items.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/lib/section-items.tcl,v
diff -u -r1.21 -r1.22
--- openacs-4/packages/assessment/lib/section-items.tcl	9 Oct 2024 12:53:35 -0000	1.21
+++ openacs-4/packages/assessment/lib/section-items.tcl	9 Oct 2024 14:21:40 -0000	1.22
@@ -37,7 +37,7 @@
     if {$presentation_type eq "fitb"} {
         regsub -all -line -nocase -- {<textbox as_item_choice_id=} $title "<input name=response_to_item.${as_item_id}_" html
     }
-    array set item [as::item::item_data -as_item_id $as_item_id]
+    set item [as::item::item_data -as_item_id $as_item_id]
 
     set item_edit_url [export_vars -base item-edit-general {as_item_id section_id assessment_id return_url}]
     set item_copy_url [export_vars -base item-copy {as_item_id section_id assessment_id return_url {after $sort_order}}]
@@ -50,17 +50,13 @@
     set checks_admin_url [export_vars -base "../asm-admin/checks-admin" {section_id assessment_id {item_id $as_item_id}}]
 
     if {$presentation_type eq "rb" || $presentation_type eq "cb"} {
-        array set type [as::item_display_$presentation_type\::data -type_id $item(display_type_id)]
-        set choice_orientation $type(choice_orientation)
-        #        set allow_other_p $item(allow_other_p)
-        array unset type
+        set type [as::item_display_$presentation_type\::data -type_id [dict get $item display_type_id]]
+        set choice_orientation [dict get $type choice_orientation]
     } else {
         set choice_orientation ""
-        #        set allow_other_p "f"
     }
 
-    set item_type $item(item_type)
-    array unset item
+    set item_type [dict get $item item_type]
 
     if {$points eq ""} {
         set points 0
Index: openacs-4/packages/assessment/lib/session-items.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/lib/session-items.tcl,v
diff -u -r1.26 -r1.27
--- openacs-4/packages/assessment/lib/session-items.tcl	3 Sep 2024 15:37:35 -0000	1.26
+++ openacs-4/packages/assessment/lib/session-items.tcl	9 Oct 2024 14:21:40 -0000	1.27
@@ -68,7 +68,7 @@
     set results_edit_url [export_vars -base "${admin_package_url}results-edit" {session_id section_id as_item_id}]
 
     set default_value [as::item_data::get -subject_id $subject_id -as_item_id $as_item_id -session_id $session_id]
-    array set item [as::item::item_data -as_item_id $as_item_id]
+    set item [as::item::item_data -as_item_id $as_item_id]
 
     set presentation_type [as::item_form::add_item_to_form -name session_results_$section_id -section_id $section_id -item_id $as_item_id -session_id $session_id -default_value $default_value -show_feedback $show_feedback -random_p $assessment_data(random_p)]
 
@@ -83,9 +83,8 @@
     }
 
     if {$presentation_type eq "rb" || $presentation_type eq "cb"} {
-        array set type [as::item_display_$presentation_type\::data -type_id $item(display_type_id)]
-        set choice_orientation $type(choice_orientation)
-        array unset type
+        set type [as::item_display_$presentation_type\::data -type_id [dict get $item display_type_id]]
+        set choice_orientation [dict get $type choice_orientation]
     } else {
         set choice_orientation ""
     }
@@ -95,10 +94,8 @@
     }
     set max_time_to_complete [as::assessment::pretty_time -seconds $max_time_to_complete]
     if {$default_value ne ""} {
-        array set values $default_value
-        set result_points $values(points)
-        set item_data_id $values(item_data_id)
-        array unset values
+        set result_points [dict get $default_value points]
+        set item_data_id  [dict get $default_value item_data_id]
         set answered_p t
         #ns_log notice "points = $points result_points= $result_points"
         if { $points != 0 } {
@@ -201,7 +198,6 @@
         set answered_p f
     }
 
-#    set content [as::assessment::display_content -content_id $item(content_rev_id) -filename $item(content_filename) -content_type $item(content_type)]
     set content $question_text
 
     if { $has_feedback_p == 1 } {
Index: openacs-4/packages/assessment/tcl/as-item-type-mc-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/tcl/as-item-type-mc-procs.tcl,v
diff -u -r1.30 -r1.31
--- openacs-4/packages/assessment/tcl/as-item-type-mc-procs.tcl	3 Sep 2024 15:37:35 -0000	1.30
+++ openacs-4/packages/assessment/tcl/as-item-type-mc-procs.tcl	9 Oct 2024 14:21:40 -0000	1.31
@@ -160,10 +160,9 @@
 
     set defaults ""
     if {$default_value ne ""} {
-        array set values $default_value
-        set defaults $values(choice_answer)
+        set defaults [dict get $default_value choice_answer]
         if {$allow_other_p} {
-            set defaults [list $defaults $values(clob_answer)]
+            set defaults [list $defaults [dict get $default_value clob_answer]]
         }
     }
     if {$session_id ne ""} {
@@ -290,7 +289,7 @@
         for {set position 1} {$position <= $max_pos} {incr position} {
             if {[info exists fixed_pos($position)]} {
                 lappend display_choices $fixed_pos($position)
-                array unset fixed_pos $position
+                unset fixed_pos($position)
             } elseif {[llength $open_positions] > 0} {
                 lappend display_choices [lindex $open_positions 0]
                 set open_positions [lreplace $open_positions 0 0]
@@ -336,42 +335,42 @@
     @author Timo Hentschel (timo@timohentschel.de)
     @creation-date 2004-12-11
 } {
-    array set type [util_memoize [list as::item_type_mc::data -type_id $type_id]]
-    array set choices $type(choices)
-    if {[info exists type(correct_choices)]} {
-        array set correct_choices $type(correct_choices)
+    set type [util_memoize [list as::item_type_mc::data -type_id $type_id]]
+    set choices [dict get $type choices]
+    if {[dict exists $type correct_choices]} {
+        set correct_choices [dict get $type correct_choices]
     }
 
-    if {$type(increasing_p) == "t"} {
+    if {[dict get $type increasing_p] == "t"} {
     # if not all correct answers are given, award fraction of the points
         set percent 0
         foreach choice_id $response {
-            incr percent $choices($choice_id)
+            incr percent [dict get $choices $choice_id]
         }
     } else {
     # award 100% points if and only if all correct answers are given
         set count_correct 0
-        if {[array exists correct_choices] && [lsort -integer $response] == [lsort -integer [array names correct_choices]]} {
+        if {[info exists correct_choices] && [lsort -integer $response] == [lsort -integer [dict keys $correct_choices]]} {
             set points $max_points
-        } elseif {[array size correct_choices] > 0} {
+        } elseif {[llength $correct_choices] > 0} {
         # FIXME !! create setting for partial credit or use existing one
             foreach elm $response {
-                if {[lsearch [array names correct_choices] $elm] > -1} {
+                if {[dict exists $correct_choices $elm]} {
                     incr count_correct
                 }
             }
-            set points [expr {$count_correct / (0.0 + [array size correct_choices]) * $max_points}]
+            set points [expr {$count_correct / (0.0 + [dict size $correct_choices]) * $max_points}]
         } else {
             set points 0
         }
     }
 
-    if {$type(allow_negative_p) == "f" && $points < 0} {
+    if {[dict get $type allow_negative_p] == "f" && $points < 0} {
         # don't allow negative percentage
         set points 0
     }
 
-    if {$type(allow_other_p)} {
+    if {[dict get $type allow_other_p]} {
         # this is a pain we need display type to get the value
         set widget [as::item_type_mc::form_widget -type_id $type_id]
         set response_value [template::util::${widget}_text::get_property ${widget}_value $response]
@@ -414,16 +413,13 @@
 
     db_foreach check_choices {} {
         if {$correct_answer_p == "t"} {
-            set correct_choices($choice_id) $percent_score
+            lappend type(correct_choices) \
+                $choice_id $percent_score
         }
-        set choices($choice_id) $percent_score
+        lappend type(choices) \
+            $choice_id $percent_score
     }
 
-    set type(choices) [array get choices]
-    if {[array exists correct_choices]} {
-        set type(correct_choices) [array get correct_choices]
-    }
-
     return [array get type]
 }
 
@@ -439,23 +435,21 @@
     @creation-date 2005-01-26
 } {
 
+    set results [dict create]
+
     db_foreach get_results {} {
         if {$text_value eq ""} {
-            lappend results($session_id) [as::assessment::quote_export -text $title]
+            dict lappend results $session_id [as::assessment::quote_export -text $title]
         } else {
-            lappend results($session_id) [as::assessment::quote_export -text $text_value]
+            dict lappend results $session_id [as::assessment::quote_export -text $text_value]
         }
     }
 
-    foreach session_id [array names results] {
-        set results($session_id) [join $results($session_id) ","]
+    foreach {session_id result} $results {
+        dict set results $session_id [join $result ","]
     }
 
-    if {[array exists results]} {
-        return [array get results]
-    } else {
-        return
-    }
+    return $results
 }
 
 ad_proc -private as::item_type_mc::add_choices_to_form {
@@ -528,19 +522,16 @@
     @author Dave Bauer (dave@solutiongrove.com)
     @creation-date 2006-10-25
 } {
-    array set choice $choices
-    array set correct $correct_choices
-
     set num_answers 0
     set num_correct_answers 0
 
-    foreach c [array names choice] {
-        if {$choice($c) ne ""} {
+    foreach {c v} $choices {
+        if {$v ne ""} {
             incr num_answers
         }
     }
-    foreach c [array names correct] {
-        if {$correct($c) == "t"} {
+    foreach {c v} $correct_choices {
+        if {$v == "t"} {
             incr num_correct_answers
         }
     }
@@ -580,17 +571,17 @@
     }
 
     set count 0
-    foreach i [lsort -integer [array names choice]] {
-        if {$choice($i) ne ""} {
+    foreach i [lsort -integer [dict keys $choices]] {
+        if {[dict get $choices $i] ne ""} {
             incr count
             set choice_id [as::item_choice::new -mc_id $mc_id \
-                               -title $choice($i) \
+                               -title [dict get $choices $i] \
                                -numeric_value "" \
                                -text_value "" \
                                -content_value "" \
                                -feedback_text "" \
                                -selected_p "" \
-                               -correct_answer_p [expr {[info exists correct($i)] ? "t" : "f"}] \
+                               -correct_answer_p [expr {[dict exists $correct_choices $i] ? "t" : "f"}] \
                                -sort_order $count \
                                -percent_score ""]
 
Index: openacs-4/packages/assessment/www/asm-admin/catalog-item-add.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/www/asm-admin/catalog-item-add.tcl,v
diff -u -r1.9 -r1.10
--- openacs-4/packages/assessment/www/asm-admin/catalog-item-add.tcl	29 Jun 2018 17:27:18 -0000	1.9
+++ openacs-4/packages/assessment/www/asm-admin/catalog-item-add.tcl	9 Oct 2024 14:21:40 -0000	1.10
@@ -84,11 +84,9 @@
         regsub -all -line -nocase -- {<textbox as_item_choice_id=} $title "<input name=response_to_item.${as_item_id}_" html
     }
     if {$presentation_type eq "rb" || $presentation_type eq "cb"} {
-	array set item [as::item::item_data -as_item_id $as_item_id]
-	array set type [as::item_display_$presentation_type\::data -type_id $item(display_type_id)]
-	set choice_orientation $type(choice_orientation)
-	array unset type
-	array unset item
+	set item [as::item::item_data -as_item_id $as_item_id]
+	set type [as::item_display_$presentation_type\::data -type_id [dict get $item display_type_id]]
+	set choice_orientation [dict get $type choice_orientation]
     } else {
 	set choice_orientation ""
     }
Index: openacs-4/packages/assessment/www/asm-admin/results-export.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/assessment/www/asm-admin/results-export.tcl,v
diff -u -r1.19 -r1.20
--- openacs-4/packages/assessment/www/asm-admin/results-export.tcl	11 Sep 2024 06:15:49 -0000	1.19
+++ openacs-4/packages/assessment/www/asm-admin/results-export.tcl	9 Oct 2024 14:21:40 -0000	1.20
@@ -97,15 +97,14 @@
 		if {$item_type eq "mc"} {
 		    lappend mc_item_list $as_item_id		    
 		} else {
-		    array set results [as::item_type_$item_type\::results -as_item_item_id $as_item_id -section_item_id $section_item_id -data_type $data_type -sessions $session_list]
+		    set results [as::item_type_$item_type\::results -as_item_item_id $as_item_id -section_item_id $section_item_id -data_type $data_type -sessions $session_list]
 		    foreach session_id $session_list {
-			if {[info exists results($session_id)]} {
-			    set csv_${section_id}_${as_item_id}($session_id) [as::assessment::quote_export -text $results($session_id)]
+			if {[dict exists $results $session_id]} {
+			    set csv_${section_id}_${as_item_id}($session_id) [as::assessment::quote_export -text [dict get $results $session_id]]
 			} else {
 			    set csv_${section_id}_${as_item_id}($session_id) ""
 			}
 		    }
-		    array unset results
 		}
 	    }
 
@@ -128,7 +127,6 @@
 			}
 		    }
 		}
-		array unset results
 	    }
 	}
     }