Index: openacs-4/packages/news/www/item-create-3.tcl =================================================================== RCS file: /usr/local/cvsroot/openacs-4/packages/news/www/item-create-3.tcl,v diff -u -r1.16 -r1.17 --- openacs-4/packages/news/www/item-create-3.tcl 6 Sep 2013 17:06:05 -0000 1.16 +++ openacs-4/packages/news/www/item-create-3.tcl 30 Sep 2013 10:51:35 -0000 1.17 @@ -34,7 +34,7 @@ set approval_policy [parameter::get -parameter ApprovalPolicy -default "wait"] # the news_admin or an open approval policy allow immediate publishing -if { $news_admin_p == 1 || [string equal $approval_policy "open"] } { +if { $news_admin_p == 1 || $approval_policy eq "open" } { set approval_user [ad_conn "user_id"] set approval_ip [ad_conn "peeraddr"] @@ -52,7 +52,7 @@ # RAL: This was missing and allows the user to "never expire" a news # item. -if {[string equal $permanent_p "t"] } { +if {$permanent_p eq "t"} { set archive_date_ansi [db_null] } @@ -81,7 +81,7 @@ if { !$news_admin_p } { - if { ![string equal "open" [parameter::get -parameter ApprovalPolicy -default "wait"]] } { + if { "open" ne [parameter::get -parameter ApprovalPolicy -default "wait"] } { # case: user submitted news item, is returned to a Thank-you page set title "[_ news.News_item_submitted]" set context [list $title]