Index: openacs-4/packages/acs-content-repository/tcl/content-folder-procs.tcl
===================================================================
RCS file: /usr/local/cvsroot/openacs-4/packages/acs-content-repository/tcl/content-folder-procs.tcl,v
diff -u -r1.20 -r1.21
--- openacs-4/packages/acs-content-repository/tcl/content-folder-procs.tcl	23 Apr 2018 16:58:39 -0000	1.20
+++ openacs-4/packages/acs-content-repository/tcl/content-folder-procs.tcl	3 Sep 2024 15:37:31 -0000	1.21
@@ -81,7 +81,7 @@
     @creation-date 2004-05-28
 
     @param folder_id item_id of the content_folder
-    @param cascade_p if true delete all children, if false, return error if folder is non-empty
+    @param cascade_p if true delete all children, if false, return error if folder is nonempty
 
     @return
 
@@ -314,24 +314,42 @@
         content_folder is_sub_folder]
 }
 
-ad_proc content::folder::get_folder_from_package {
+ad_proc -deprecated content::folder::get_folder_from_package {
     -package_id:required
 } {
     @author Timo Hentschel (timo@timohentschel.de)
     @creation-date 2005-01-06
 
     Returns the folder_id of the package instance. Cached
+
+    DEPRECATED: this proc assumes there will be just one folder for
+                each package, which is not true in general!
+
+    @see other packages as file-storage or xowiki define the concept
+         of a root_folder. This is explicitly meant to be unique for
+         each package. If your package can guarantee there will only
+         be one folder per package, you should write your own api for
+         it.
 } {
     return [util_memoize [list content::folder::get_folder_from_package_not_cached -package_id $package_id]]
 }
 
-ad_proc -private content::folder::get_folder_from_package_not_cached {
+ad_proc -deprecated content::folder::get_folder_from_package_not_cached {
     -package_id:required
 } {
     @author Timo Hentschel (timo@timohentschel.de)
     @creation-date 2005-01-06
 
     Returns the folder_id of the package instance
+
+    DEPRECATED: this proc assumes there will be just one folder for
+                each package, which is not true in general!
+
+    @see other packages as file-storage or xowiki define the concept
+         of a root_folder. This is explicitly meant to be unique for
+         each package. If your package can guarantee there will only
+         be one folder per package, you should write your own api for
+         it.
 } {
     return [db_string get_folder_id {
         select folder_id from cr_folders where package_id = :package_id