form-processing-procs.tcl

  • last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
fix typos

ad_form reform:

- use actual flags instead of parsing arguments all the time

- retrieve proc flags from ad_proc definition (TODO: have some api for this?)

- follow the thread of peculiar ad_form logic to fix new csrf signing feature

- improve documentation using @param instead of manual formatting

- leave some note to travellers in the code

    • -243
    • +229
    ./form-processing-procs.tcl
reflow overlong lines in comments

ad_form: Add optional parameter -csrf_protection_p (defaults to false)

white space changes

simplify code

improve security of ad_forms by binding request to a user

fix bracket in last commit

use usual idioms, white space changes

Greatly reduce complexity of code required to support -export flag for ad_form:

instead of juggle variables around to mimick export_vars, just set -export flag

value as a form property, then use the real export_vars on it later when form

is rendered. This will support all current features (e.g. :multiple, :sign, :array)

more reliably and reduce code duplication.

  1. … 1 more file in changeset.
improve wording

  1. … 7 more files in changeset.
make spelling of names more consistent

  1. … 5 more files in changeset.
Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 475 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 71 more files in changeset.
Fix typos

  1. … 34 more files in changeset.
Fix typos

  1. … 14 more files in changeset.
Use consistently ad_script_abort after ad_return_error.

Removed incorrectly placed "--" between named parameter and its value

Bug fix: avoid confusion between command argument and option, when argument starts with "-"

  1. … 81 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7834 more files in changeset.
ad_form: completed support for -export parameter. Now the same syntax used

for "vars" argument in export_vars proc can be used. In particular

one can specify :multiple, :array and :sign flags on variables.

This change required modification to template::widget::hidden: now, when

specifying both -value and -values flags, if -values is non-empty this will

have the precedence over -value, and this widget will me multiple.

  1. … 1 more file in changeset.
- handle cases, where __new_p is not set in form

- validate contents of __new_p

- use tcl8.5 idioms

Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

  1. … 2547 more files in changeset.
1. Changed trigger functions from "opaque" to "trigger" to get rid of the

warnings during initial install (only for acs-kernel, there are a lot

elsewhere!)

2. Added "embeds" for postgresql and partially for oracle.

3. Added global parameters for postgresql and partially for oracle.

(oracle will be forthcoming shortly)

  1. … 29 more files in changeset.
Added a missing subst in ad_set_form_values

undo escaped changes

  1. … 2 more files in changeset.
ensure that charset is always included in content type for text/* media types.

  1. … 3 more files in changeset.
Merged the 5.3 branch with HEAD. Look for tags with the pattern

drb-*-20070513

  1. … 324 more files in changeset.
Normalizing string comparison operations into tcl 8.4 operations, enabling byte-code compilation for expressions and many conditionals

  1. … 367 more files in changeset.