• last updated 9 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Removed inline js events into explicit handlers. Test and revamp of plugin to functional state.

Uniform cache for chat room infos to the established nomenclature.

Increase size so that 1000 maximum entries would fit in the cache.

    • -6
    • +7
- provide partial times to statistics (if available)

- add long-calls to navigation structure

- bump version number to 0.48

Some more Tcl cleanup

- use curly brackes to enable byte code compilation

- don't use "[expr ...]" when not needed

- prefer "incr i -1" over "set i [expr {$i - 1}] "

- set live and latest revision on one sweep (use is_latests setting when setting live_revision)

Reduced generation of dead tuples in postgres.

Background: In the old version, the fields latest and live

revisions were updated always via two separate dmlDML statements.

Every update causes in PostgreSQL (tested to pg 9.6) one more dead

tuple, such that on busy systems, we see 30k + dead tuples per

hour. These dead tuples in turn cause more auto vacuum operations

and can lead to abandoned query plans.

This change can reduce the number of dead tuples on cr_items into

half, by allowing both fields to be set in one operation (namely

content_item__set_live_revision). This function has an optional 4th

argument that can cause this optimization. For legacy applications,

nothing changes.

Btw: since all commonly used applications use the live revision, the

fallback of the latest_revision is unused. One can consider to

remove the cr_revision_latest_tr, at least on on certain


bump revision to 5.1.9d23

file upgrade-5.9.1d22-5.9.1d23.sql was initially added on branch oacs-5-9.

- make upgrade script more robust

- replace regular expression by ad_html_qualify_links

- bum version number to 5.9.1d2

- imporve ad_html_qualify_links in various ways (better argument name, better comments, removed superflous slashes, ...

    • -2
    • +2
- turn relative links during notifications into absolute links

    • -3
    • +3
- add a function ad_html_qualify_links to make e.g. relative URL handing in notifications easier

- use the right variable name

Add index on ad_locale_user_prefs for foreign key user_id

file upgrade-5.9.1d1-5.9.1d2.sql was initially added on branch oacs-5-9.

- fix code for making urls absolute. regexps like [^(http|https|mailto:)] don't work, as the author expected.

Allow messages starting with a dash

Avoid logging every message sent to reduce IO

Removed unnecessary decoding of received messages, fixed encoding of sent messages so special characters are properly urlencoded.

    • -4
    • +5
- use :form_field_index for adding names recursively to the index

- provide more detailed debugging info

    • -2
    • +1
    • -2
    • +10
Handle in a human way when lookup of a key fails (but keep reporting in the logs)

- remove commented out "if disabled" code; otherwise, the controls are also shown when viewing the items

    • -24
    • +24
Fix typo

    • -2
    • +2
- add repeat container to debugging output

    • -1
    • +5
- add debugging aids in case creation of nested formfields fails

    • -4
    • +6
    • -2
    • +13
- detect when repeat fields are used in input mode: as long we have no js-support, max repeat count form fields have to be created in advance

- avoid duplicate generations for form fields in some cases

    • -3
    • +14
    • -1
    • +5
- move CSP generation to rendering section

- allow the repeat fields to be sent in arbitrary order from the browser

    • -6
    • +19
Added catalog file of new message keys

Allow user to specify how far in the past people connecting to the chat will see.

This is important on Learn@WU because people joining the chat room later want to

see the full conversation and before this was not settable from the UI. (Now defaults

to 4 hours) Useful also when somebody accidentally refreshes the chat after the

timewindow has passed.

Took this chance to ease a bit every future development: removed stored procedures

slowing greatly any change on the data model in favor of plain sql statements.

Incremented usage of cache.

Removed duplicated database operation when managing transcripts.

Fixed transcript name not being shown when deleting.

    • -27
    • +51
    • -12
    • +69
    • -50
    • +60
    • -13
    • +12