• last updated 3 hours ago
Constraints: committers
Constraints: files
Constraints: dates
add missing spaces

add missing spaces

fix condition: blob can either be null or the size of blob is below the threshold

use localized_text for folders and links

no need to subst

resolve message keys in titles

    • -0
    • +3
reduce verbosity

factor out script wrappers

    • -26
    • +18
fix typo

undo recent changes on too global localizations

The new form-field class localized_text text solves the goals

of for providing a formfield interface to message keys in a

loca fashion rather than altering the behavior of all form

field and of all property interfaces.

    • -35
    • +5
New form-field class: localized_text

This class can be used to provide an interface for specifying

internationalized text strings saved in message keys via input

from a form. When editing the content provided via the input field

is saved together with an item-specific message keys in the

message key tables via lang::util::convert_to_i18n.

This formfield class is especially useful for xowiki items which

have no language-prefix (e.g. folders or links). In other cases it

is probably still a better idea to create same named pages with

different language prefixes.

    • -2
    • +2
improve spelling

Keep nsv variable "rp_properties request_count"

The nsv "rp_properties request_count" is still needed for bootstart loader.

Set it at the end of rp initialization

remove misleading comment. there should be no re-init

search the form also in the site_wide_pages

    • -0
    • +1
Disable any conversion on the _name property (:name Page instance variable): this property is special and receives already its necessary conversion at validation time, happening before conversion time and should not be overridden

Implement 'language_specific' formfields and 'localized' FormPage properties:

- properties can be stored and retrieved specifying a -localized flag: this flag will make transparently store and retrieve the property value from a custom message key created in the acs-translations package referencing the FormPage. This localization mechanism is additional to that of language-prefixed pages and can address the need of multi-language content for non-prefixable objects such as folders

- via specifying language_specific in the formfield spec, one can enable this new localization mechanism when interacting with the FormPage via a xowiki::Form

TODO: handle export/import of pages (e.g. serializing available translation and generate the new message keys for the imported page), add some nicer UI to make the user aware of e.g. current translation context

    • -3
    • +31
Reduce the threshold for images to be considered black:

in the wild it has happened that borderline-legitimate pictures of 7kbytes have triggered the check.

Fix missing column in sql statement

prefer db_0or1row +"where exists" over db_string + "select case"

send also HEAD requests to the request monitor

reduce usage of idiom "select 1 from dual where exists" when not necessary

some packages have high number of instances: no need to aggregate over these

Pass missing object_id flag

Do not insert object_ids that do not exist in acs_object (leftover group message keys)

Replace limit with portable idiom

prefer ad_try, since it is silent, when action is ended by a script_abort

    • -2
    • +4
Fix oracle query as for most recent version limit is not supported

Go straight to the database with a portable query

Improve sql portability, reduce number of statements