• last updated 14 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
add missing upgrade directory

as it seems, there was never one, therefore there were no sql upgrade scripts performed

file upgrade-5.10.0d1-5.10.0d2.sql was initially added on branch oacs-5-10.

provide named arguments for stored procedures to reduce warnings with recent versions of OpenACS

Whitespace changes

Do not assume a package is installed only if it has an entry in the 'apm_package_types' table. This fixes the issue of package upgrade prompting, in not installed packages, that still have an entry in 'apm_package_types'

use "ad_log" instead of "ns_log" in "obscure case"

Allow to undelete a message from acs-lang 'edit-localized-message', instead of showing the option to delete it whatever the state is

Refactor acs-lang 'admin/index' page, adding the new columns 'total' and 'deleted' to the listing, and reworking the query so it is faster (53ms -> 7ms), correct (number of messages by state are computed coherently with other acs-lang pages) and gives more information

file index.xql was initially added on branch oacs-5-10.

    • -0
    • +0
    /openacs-4/packages/acs-lang/www/admin/index.xql
improve spelling

Improve proc documentation

Refactor acs-lang 'message-list', using a single query for counting the different message states instead of one per state, and simplifying tcl logic

Fix xotcl-core cr-items test: modifying IP comes in fact from the cr_item's acs_object (it is also on the revision, but on the items seems to take into account e.g. proxying)

Fix 3 inconsistent log messages in the test

Fix typo

improve spelling

    • -1
    • +1
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
improve spelling

  1. … 3 more files in changeset.
Rework acs-lang 'package-list' query 'packages_locale_status' query (89ms -> 4ms)

Rework acs-lang 'package-list' query 'packages_locale_status_default' query (48ms -> 2ms)

Prefer portable current_timestamp idiom to NOW()

Exploit existing acs::test::user::create api

Normalize indentation, add editor hints

    • -10
    • +17
    /openacs-4/packages/xolp/tcl/xolp-iri-procs.tcl
    • -0
    • +7
    /openacs-4/packages/xolp/tcl/xolp-procs.tcl
    • -31
    • +38
    /openacs-4/packages/xolp/tcl/xolp-user-procs.tcl
    • -10
    • +17
    /openacs-4/packages/xolp/tcl/xolp-util-procs.tcl
Modernize XoTcl idioms

    • -12
    • +11
    /openacs-4/packages/xolp/tcl/xolp-iri-procs.tcl
Use xotcl-core indentation convention

    • -95
    • +96
    /openacs-4/packages/xolp/tcl/xolp-apm-procs.tcl
Whitespace cleanup, normalize indentation, add editor hints

    • -94
    • +100
    /openacs-4/packages/xolp/tcl/xolp-apm-procs.tcl
Use xotcl db idioms

Rollback tests or they will interfere with the others

Reimplement query to obtain user competencies to fix xolp.user_get_competencies automated test

Personal perplexities:

- why do we specify the competency_set_id on the indicator facts? If one fact can be e.g. an exam, this might be related with multiple competency sets

- should we take into account also the validity of an activity?

    • -14
    • +36
    /openacs-4/packages/xolp/tcl/xolp-user-procs.tcl
Add deleted column to acs-lang 'package-list', and fixed number of messages depending on status, making it coherent with 'message-list'. Also fixed translated/untranslated count on default locale in 'message-list'. Version bump.

file package-list.xql was initially added on branch oacs-5-10.

    • -0
    • +0
    /openacs-4/packages/acs-lang/www/admin/package-list.xql