Activity OpenACS/

5:01 pm

antoniop

Reimplement the news admin index page to use the template system and behave consistently with the rest of the graphics

One reason to have custom markup here was the bulk-actions pointing to the same URL differentiated only via URL parameters. This limitation has been overcome in the previous commit.

- -62
- +1
/openacs-4/packages/news/www/admin/index.adp
- History
- Source
- Diff
/openacs-4/packages/news/.../admin/index.adp
- -21
- +103
/openacs-4/packages/news/www/admin/index.tcl
- History
- Source
- Diff
/openacs-4/packages/news/.../admin/index.tcl

4:53 pm

allow to have URL parameters specified in the bulk-action URL, so that the same URL can be used to serve multiple bulk actions differentiated via different flags. The URL parameters override completely every attribute with the same name specified on the form.

- -5
- +51
/openacs-4/packages/acs-subsite/www/resources/core.js
- History
- Source
- Diff
/openacs-4/packages/.../resources/core.js

1:57 pm

antoniop

Be Bootstrap 5 friendly

- -1
- +1
/openacs-4/packages/proctoring-support/www/proctored-index.adp
- History
- Source
- Diff
/openacs-4/packages/.../proctored-index.adp

1:15 pm

gustafn

bootstrap5 bulkactions: move "ul" element to one level higher

Many thanks to Monika Andergassen for the change

- -20
- +23
/openacs-4/packages/xowiki/tcl/bootstrap-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../bootstrap-procs.tcl

1:05 pm

gustafn

bootstrap5 dropt down menu item: add "disabled" class to the anchor element as well

Many thanks to Monika Andergassen for the suggestion

- -3
- +4
/openacs-4/packages/xowiki/tcl/bootstrap-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../bootstrap-procs.tcl

12:35 pm

gustafn

use for bootstrap5 for select input form-select instead of form-control

Many thanks to Monika Andergassen for noting

- -1
- +4
/openacs-4/packages/xowiki/tcl/package-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/package-procs.tcl

12:31 pm

gustafn

fix indentation

- -2
- +2
/openacs-4/packages/xowiki/tcl/form-field-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../form-field-procs.tcl

7:30 pm

antoniop

Space the save button a bit

- -0
- +1
/openacs-4/packages/proctoring-support/lib/proctoring-display.adp
- History
- Source
- Diff
/openacs-4/.../proctoring-display.adp

7:26 pm

antoniop

Truncate timestamp to the seconds

- -0
- +2
/openacs-4/packages/proctoring-support/lib/proctoring-display.tcl
- History
- Source
- Diff
/openacs-4/.../proctoring-display.tcl

7:20 pm

antoniop

Apply the Boostrap classes also to the other buttons for consistency

- -2
- +2
/openacs-4/packages/proctoring-support/lib/proctoring-display.adp
- History
- Source
- Diff
/openacs-4/.../proctoring-display.adp

7:17 pm

antoniop

Be Bootstrap5 friendly on the buttons formerly known as "default"

- -4
- +4
/openacs-4/packages/proctoring-support/lib/proctoring-display.adp
- History
- Source
- Diff
/openacs-4/.../proctoring-display.adp

7:10 pm

antoniop

Fix typo

- -1
- +1
/openacs-4/packages/proctoring-support/lib/proctoring-display.adp
- History
- Source
- Diff
/openacs-4/.../proctoring-display.adp

7:04 pm

antoniop

Modernize JavaScript:

- Be specific about the scope and lifetime of variables via const and let

- Always prefer "for" loops to iterators

- Cleanup obsolete wrappers

- Use single and double quotes consistently

- Use the equals operator consistently

- -197
- +190
/openacs-4/packages/proctoring-support/lib/proctoring-display.adp
- History
- Source
- Diff
/openacs-4/.../proctoring-display.adp

6:20 pm

antoniop

Prefer modal implementation from acs-templating to the various approaches used so far

- -7
- +8
/openacs-4/packages/proctoring-support/lib/proctored-page.adp
- History
- Source
- Diff
/openacs-4/packages/.../proctored-page.adp
- -44
- +11
/openacs-4/packages/proctoring-support/lib/proctoring-display.adp
- History
- Source
- Diff
/openacs-4/.../proctoring-display.adp
- -9
- +18
/openacs-4/packages/proctoring-support/www/resources/proctored-page.js
- History
- Source
- Diff
/openacs-4/packages/.../proctored-page.js

4:57 pm

antoniop

Add acknowledgment

- -0
- +2
/openacs-4/packages/acs-templating/www/resources/tooltip.css
- History
- Source
- Diff
/openacs-4/packages/.../resources/tooltip.css

4:57 pm

antoniop

Fix navigation

- -1
- +1
/openacs-4/packages/acs-templating/www/doc/gadgets/tooltip.adp
- History
- Source
- Diff
/openacs-4/packages/.../gadgets/tooltip.adp

4:56 pm

antoniop

Provide a zero-dependency Modal implementation

This uses CSS and little JavaScript. The goal is to provide a Modal implementation that is independend from frameworks such as Boostrap. This is actually very possible in modern CSS and JavaScript.

Documentation with examples is included.

- -3
- +6
/openacs-4/packages/acs-templating/www/doc/gadgets/index.adp
- History
- Source
- Diff
/openacs-4/packages/.../gadgets/index.adp
- -0
- +172
/openacs-4/packages/acs-templating/www/doc/gadgets/modal.adp
- History
- Source
- Diff
/openacs-4/packages/.../gadgets/modal.adp
- -0
- +31
/openacs-4/packages/acs-templating/www/resources/modal.css
- History
- Source
- Diff
/openacs-4/packages/.../resources/modal.css
- -0
- +65
/openacs-4/packages/acs-templating/www/resources/modal.js
- History
- Source
- Diff
/openacs-4/packages/.../resources/modal.js

4:56 pm

antoniop

More
MAIN:antoniop:20230802145640
deleted 1 file
MAIN

file modal.adp was initially added on branch oacs-5-10.

- -0
- +0
/openacs-4/packages/acs-templating/www/doc/gadgets/modal.adp
- History
- Source
/openacs-4/packages/.../gadgets/modal.adp

4:56 pm

antoniop

More
MAIN:antoniop:20230802145640:2
deleted 1 file
MAIN

file modal.js was initially added on branch oacs-5-10.

- -0
- +0
/openacs-4/packages/acs-templating/www/resources/modal.js
- History
- Source
/openacs-4/packages/.../resources/modal.js

4:56 pm

antoniop

More
MAIN:antoniop:20230802145640:1
deleted 1 file
MAIN

file modal.css was initially added on branch oacs-5-10.

- -0
- +0
/openacs-4/packages/acs-templating/www/resources/modal.css
- History
- Source
/openacs-4/packages/.../resources/modal.css

4:24 pm

gustafn

replaced complex and error-prone test with a more sane version

Actually, this test should be in acs-tcl, since all kernel behavior is already

there, and the directory "tcl" was left intentionally empty.

- -45
- +4
/openacs-4/packages/acs-kernel/tcl/test/acs-kernel-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../acs-kernel-procs.tcl

3:25 pm

gustafn

don't send messages to other threads during shutdown

The threads might be gone already, causing error log entries

- -3
- +4
/openacs-4/packages/xotcl-core/tcl/40-thread-mod-procs.tcl
- History
- Source
- Diff
/openacs-4/.../40-thread-mod-procs.tcl

4:59 pm

antoniop

Provide a zero-dependency Tooltip implementation

This uses CSS and little JavaScript. The goal is to provide a Tooltip implementation that is independend from frameworks such as Boostrap. This is actually very possible in modern CSS and JavaScript.

Documentation with examples is included.