• last updated 23 mins ago
Constraints: committers
Constraints: files
Constraints: dates
Prevent Javascript in the comment content

Note that this check is additional to that coming from e.g. allowed tags or similar

Do not allow markup in the portlet name

Localize error message

Use a better regexp to reimplement ad_looks_like_html_p, use the improved api to port downstream feature: an ad_form datatype validator that won't allow to insert markup

Many thanks to Günter Ernst

Cleanup reference to deprecated api

Quote name, as this will be shown in the error message

    • -2
    • +2
Do not allow data URLs

Use modern HTML and OpenACS features for date input, which do not require rendering via a custom widget api and cumbersome validation

Deprecate dt_widget_calendar_year

Cleanup dt_widget_calendar_navigation documentation

Deprecate dt_widget_calendar_navigation

Test dt_no_time_p

Deprecate ad_ns_set_to_tcl_vars, which can always be replaced with simple tcl idioms

Update uninstall callback:

- avoid convoluted idioms

- improve documentation

- use cross dbms api

Deprecate ad_user_class_description, private proc used nowhere in upstream codebase

dt_ansi_to_list already trims the zeros, no need to create an ns_set, not need to upvar everything twice just to have the variables in our scope

harden page_contract

Test dt_get_info, fix documentation according to long standing behavior

do not show grading_table if grading is "none"

Port of downstream feature:

check that no Portlet with the same name exists on the same portal and page before trying to enter the data.

Fix applet mountpoint:

.LRN UI expects the static portlet applet to be mounted under the /dotlrn/applets site node and this is also the case at the WU installation. However, upstream .LRN mounts the applet under /dotlrn, causing dead links in the UI. Rectify the situation and provide an automated test that will enforce this condition from now on.

file apm-callback-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
handle the case when instantiate_includelet is not returning an object (e.g. invalid top_includelet via user input)

    • -2
    • +2
For the file-storage portlet to support the "showcasing use case", instead of hacking the UI as done before, we just point it to the user folder, that should exist for everyone

Handle here as well the case, that we are just showcasing the portlet for "Portal Templates"

Handle here as well the case when this portlet is rendered in "Portal Templates"

Handle the case of "Portal Templates", when the portlet is only showcased and should not be interacted with

make check more robust

harden page_contract

Format code in a way to avoid false positives where a column name is taken as a deprecated proc

    • -9
    • +6