• last updated 33 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix long standing regression

After https://cvs.openacs.org/changelog/OpenACS?cs=MAIN%3Adaveb%3A20080908165252, in template::list::write_csv we started looping through the list "elements", rather than the "display_elements". This prevents specifying different sets of columns to be returned depending on the "-formats" and "-selected_format" options in template::list::create. Many thanks to Oasi Software that customized this proc a long time ago, so that I could realize where the problem was.

Fix blind spot when setting the return_url

    • -9
    • +10
    /openacs-4/packages/news/www/item-create-3.tcl
Do not abort the script until we are done with e.g. notifications and such

    • -5
    • +4
    /openacs-4/packages/news/www/item-create-3.tcl
Whitespace cleanup

    • -4
    • +4
    /openacs-4/packages/news/www/item-create.tcl
    • -13
    • +13
    /openacs-4/packages/news/www/preview.tcl
Fix typo

    • -2
    • +2
    /openacs-4/packages/news/tcl/news-procs.tcl
Refactor query to go over the fs hierachy, rather than the permission one, add remarks

Recover logic went missing after refactoring (with some remarks)

Comment deprecated proc, which was before defined as private, because of a false positive in acs-api-browser.callgraph__bad_library_calls: the "Authenticate" operation in the spec of auth::authentication::create_contract is mistakenly interpreted as the deprecated proc

Make proc public, as was intended

passing "-debug" flag explicitly to nsf::proc

whitespace changes

fix last commit (many thanks to Thomas Renner)

made includelet "categories" folder aware (on can pass "parent" in form of a page-ref to the includelet)

refactored some of the code to increase reusability

    • -30
    • +1
    /openacs-4/packages/xowiki/tcl/folder-procs.tcl
make treeview more compact

Deprecated trivial private ad_user_login wrapper, which is already a public api

Promote logics in auth::authentication::Authenticate to a public api, which unfortunately cannot be the same due to the inconsistent naming, hence we have to create a new alias

Rationale:

- the proc provides some value to the user by choosing the right contract implementation depending on the authority

- we found occurrences in other packages downstream, and as internally this proc is calling only public api, one could just duplicate the whole thing and be compliant with our standards, which is not an improvement IMO

- the proc was already tested and documented

Update doc following the acs_named_objects phasing out, this escaped the commit back in the days

Remove leftover

Refactoring, as proctoring files are not only pictures, make api public, write automated test

break overlong lines

stick to content-repository API instead of duplicating code here.

Use better timing idiom

Fixed var name and add warning for 'cr_file_name' being empty (the latter ported from downstream, originally made by Günter Ernst)

new function: ::content::revision::export_to_filesystem

This change moves functionality from file-storage to acs-content-repository.

all application packages should be free of internals, such as the storage

type. Storage_type should be handeled in the content-repository package.

We are not yet done, there is still more to do in this respect in

the file-storage package.

break overlong lines

improve comments

make actions changed from the background state-safe

    • -3
    • +3
    /openacs-4/packages/xowf/lib/inclass-exam.wf
Implement a checksum + cache mechanism to check whether user is sending the same file multiple times:

this is needed to address the problem of timeouts, where the server might process a request even when the client has given up and rescheduled the upload. We now store the latest checksum that has been received and compare it with the new picture.

file proctoring-support-init.tcl was initially added on branch oacs-5-10.

Whitespace changes + Editor hints