OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 18
Total Committers: 146
Last Commit: 28 Nov
Commits this week: 18
Total Lines of Code (LoC): 7,560,946
Net change in LoC this week: 3

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 03 Sep 2020
3:41 pm

antoniop

Implement 'language_specific' formfields and 'localized' FormPage properties:

- properties can be stored and retrieved specifying a -localized flag: this flag will make transparently store and retrieve the property value from a custom message key created in the acs-translations package referencing the FormPage. This localization mechanism is additional to that of language-prefixed pages and can address the need of multi-language content for non-prefixable objects such as folders

- via specifying language_specific in the formfield spec, one can enable this new localization mechanism when interacting with the FormPage via a xowiki::Form

TODO: handle export/import of pages (e.g. serializing available translation and generate the new message keys for the imported page), add some nicer UI to make the user aware of e.g. current translation context

Options
    • -20
    • +31
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
    • -3
    • +31
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
2:58 pm

antoniop

Reduce the threshold for images to be considered black:

in the wild it has happened that borderline-legitimate pictures of 7kbytes have triggered the check.

Options
    • -1
    • +1
    /openacs-4/packages/proctoring-support/lib/proctored-page.adp
2:33 pm

antoniop

Fix missing column in sql statement

Options
    • -1
    • +1
    /openacs-4/packages/xotcl-core/tcl/ical-procs.tcl
11:16 am

gustafn

prefer db_0or1row +"where exists" over db_string + "select case"

Options
    • -12
    • +14
    /openacs-4/packages/acs-authentication/tcl/authentication-procs.tcl
    • -5
    • +3
    /openacs-4/packages/acs-subsite/tcl/attribute-procs.tcl
    • -8
    • +10
    /openacs-4/packages/dotlrn/tcl/test/community-procs.tcl
    • -10
    • +10
    /openacs-4/packages/new-portal/tcl/portal-procs.tcl
11:12 am

gustafn

send also HEAD requests to the request monitor

Options
    • -0
    • +2
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-init.tcl
10:42 am

gustafn

reduce usage of idiom "select 1 from dual where exists" when not necessary

Options
    • -11
    • +7
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
10:41 am

gustafn

some packages have high number of instances: no need to aggregate over these

Options
    • -1
    • +2
    /openacs-4/packages/xotcl-core/tcl/06-param-procs.tcl
Wednesday 02 Sep 2020
6:48 pm

antoniop

Pass missing object_id flag

Options
    • -2
    • +4
    /openacs-4/packages/acs-lang/tcl/lang-util-procs.tcl
1:25 pm

antoniop

Do not insert object_ids that do not exist in acs_object (leftover group message keys)

Options
    • -1
    • +2
    /openacs-4/packages/acs-lang/sql/oracle/upgrade/upgrade-5.10.0d13-5.10.0d14.sql
    • -1
    • +2
    /openacs-4/packages/acs-lang/sql/postgresql/upgrade/upgrade-5.10.0d13-5.10.0d14.sql
1:04 pm

antoniop

Replace limit with portable idiom

Options
    • -4
    • +5
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
12:52 pm

gustafn

prefer ad_try, since it is silent, when action is ended by a script_abort

Options
    • -2
    • +4
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
Tuesday 01 Sep 2020
7:59 pm

antoniop

Fix oracle query as for most recent version limit is not supported

Options
    • -4
    • +8
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
7:56 pm

antoniop

Go straight to the database with a portable query

Options
    • -4
    • +6
    /openacs-4/packages/xotcl-core/tcl/06-param-procs.tcl
7:49 pm

antoniop

Improve sql portability, reduce number of statements

Options
    • -16
    • +12
    /openacs-4/packages/news-aggregator/tcl/subscription-procs.tcl
7:37 pm

antoniop

Improve sql portability

Options
    • -9
    • +11
    /openacs-4/packages/acs-service-contract/tcl/acs-service-contract-procs.tcl
    • -5
    • +7
    /openacs-4/packages/acs-subsite/tcl/attribute-procs.tcl
    • -4
    • +6
    /openacs-4/packages/acs-subsite/tcl/group-procs.tcl
    • -6
    • +10
    /openacs-4/packages/acs-subsite/tcl/group-type-procs.tcl
    • -3
    • +6
    /openacs-4/packages/acs-subsite/tcl/subsite-procs.tcl
    • -12
    • +15
    /openacs-4/packages/acs-subsite/tcl/test/acs-subsite-procs.tcl
7:35 pm

antoniop

Cleanup leftover query

Options
    • -6
    • +1
    /openacs-4/packages/acs-content-repository/tcl/content-revision-procs.xql
7:32 pm

antoniop

Whitespace cleanup

Options
    • -4
    • +4
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
7:24 pm

antoniop

Improve sql portability

Options
    • -22
    • +22
    /openacs-4/packages/acs-lang/tcl/test/acs-lang-localization-procs.tcl
    • -4
    • +6
    /openacs-4/packages/acs-tcl/tcl/apm-procs.tcl
    • -2
    • +5
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
    • -4
    • +5
    /openacs-4/packages/file-storage/www/folder-chunk.tcl
    • -2
    • +4
    /openacs-4/packages/forums/www/admin/subscribe-others-2.tcl
    • -2
    • +11
    /openacs-4/packages/new-portal/tcl/portal-procs.tcl
    • -12
    • +0
    /openacs-4/packages/new-portal/tcl/portal-procs.xql
7:16 pm

antoniop

Fix missing end

Options
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/tcl/test/content-extlink-procs.tcl
    • -2
    • +2
    /openacs-4/packages/dotlrn/tcl/dotlrn-security-procs.tcl
    • -2
    • +2
    /openacs-4/packages/dotlrn/tcl/test/community-procs.tcl
7:14 pm

antoniop

Im prove sql portability

Options
    • -5
    • +5
    /openacs-4/packages/dotlrn/tcl/test/community-procs.tcl
7:11 pm

antoniop

Improve sql portability

Options
    • -4
    • +4
    /openacs-4/packages/acs-admin/www/apm/parameter-add.tcl
    • -11
    • +11
    /openacs-4/packages/acs-content-repository/tcl/test/content-extlink-procs.tcl
    • -4
    • +4
    /openacs-4/packages/dotlrn/tcl/dotlrn-security-procs.tcl
    • -5
    • +5
    /openacs-4/packages/dotlrn/www/communities-chunk.tcl
    • -2
    • +4
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
7:09 pm

antoniop

Improve sql portability: oracle cannot select a boolean directly using exists

Options
    • -3
    • +4
    /openacs-4/packages/acs-authentication/tcl/authentication-procs.tcl
6:40 pm

antoniop

Whitespace cleanup

Options
    • -2
    • +2
    /openacs-4/packages/news-aggregator-portlet/www/news-aggregator-portlet.tcl
6:39 pm

antoniop

Make sql portable

Options
    • -1
    • +5
    /openacs-4/packages/news-aggregator-portlet/www/news-aggregator-portlet.tcl
5:19 pm

antoniop

Improve sql portability

Options
    • -4
    • +7
    /openacs-4/packages/forums/www/admin/subscribe-others-2.tcl
5:11 pm

antoniop

Replace limit idiom with portable idiom

Options
    • -8
    • +0
    /openacs-4/packages/assessment/tcl/as-apm-action-procs-oracle.xql
    • -10
    • +0
    /openacs-4/packages/assessment/tcl/as-apm-action-procs-postgresql.xql
    • -1
    • +5
    /openacs-4/packages/assessment/tcl/as-apm-action-procs.tcl
4:40 pm

antoniop

Avoid the not portable limit idiom, just kill the recursive part using the flag instead

...although one should point out that Oracle does not support the boolean type...

Options
    • -5
    • +4
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
4:35 pm

antoniop

Improve portability of test code

Options
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/test/db-proc-test-procs.tcl
4:32 pm

antoniop

Replace limit with a portable idiom

Options
    • -5
    • +5
    /openacs-4/packages/acs-subsite/tcl/group-procs.tcl
4:28 pm

antoniop

Improve sql portability

Options
    • -2
    • +3
    /openacs-4/packages/acs-mail-lite/tcl/email-inbound-procs.tcl
    • -2
    • +3
    /openacs-4/packages/acs-mail-lite/tcl/imap-inbound-procs.tcl