• last updated 12 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix missing end

Im prove sql portability

Improve sql portability

Improve sql portability: oracle cannot select a boolean directly using exists

Whitespace cleanup

Make sql portable

Improve sql portability

Replace limit idiom with portable idiom

Avoid the not portable limit idiom, just kill the recursive part using the flag instead

...although one should point out that Oracle does not support the boolean type...

Improve portability of test code

Replace limit with a portable idiom

Improve sql portability

Replace limit (pg only) with fetch idiom, which should be portable on "modern" Oracle

Reduce divergencies between oracle and postgres codebase

Reduce divergency between oracle and postgres codebase

Improve portability, fetch idiom should be supported by "modern Oracle"

Rewrite idiom to be portable (limit is psql only)

Pass check_active_p from the including page

Disable proctored-session expiration check based on proctoring-support datamodel using the new flag, enable preview as before (upstream code has it disabled by default), disable examination statement as intended

    • -5
    • +4
    /openacs-4/packages/xowf/lib/inclass-exam.wf
Pass the check_active_p flag down to the backend from the proctored page, update doc

Add semicolon (just for consistency, code was working before as well)

Add a new flag to disable check on proctoring start/end time for applications that do not store this info in the package datamodel, improve doc

Fix retrieving the template

    • -2
    • +2
    /openacs-4/packages/xowf/lib/inclass-exam.wf
Add 'dotlrn_chat__applet_portlet' test case, covering 'dotlrn_chat::add_applet', 'dotlrn_chat::add_portlet', 'dotlrn_chat::add_portlet_helper', 'dotlrn_chat::remove_portlet' and 'dotlrn_chat::remove_applet'

Implement the 'dotlrn_applet::remove_applet_from_dotlrn' proc, called from different remove_applet procs, but never implemented

    • -0
    • +17
    /openacs-4/packages/dotlrn/tcl/applets-procs.tcl
    • -0
    • +19
    /openacs-4/packages/dotlrn/tcl/applets-procs.xql
Replace xowf proctoring implementation with that coming from proctoring-support

TODO: nicer detection of whether proctoring-support package is actually installed

    • -7
    • +9
    /openacs-4/packages/xowf/lib/inclass-exam.wf
    • -239
    • +0
    /openacs-4/packages/xowf/lib/proctored-page.adp
    • -208
    • +0
    /openacs-4/packages/xowf/lib/proctored-page.tcl
    • -67
    • +0
    /openacs-4/packages/xowf/lib/proctoring-upload.tcl
prefer SQL max() function over sort and limit 1

    • -3
    • +4
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
Make apm callbacks private and move them together with the others

Maintain also the has_child cache when mounting a package

Fix typo