• last updated 15 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Pass the check_active_p flag down to the backend from the proctored page, update doc

Add semicolon (just for consistency, code was working before as well)

Add a new flag to disable check on proctoring start/end time for applications that do not store this info in the package datamodel, improve doc

Fix retrieving the template

    • -2
    • +2
Add 'dotlrn_chat__applet_portlet' test case, covering 'dotlrn_chat::add_applet', 'dotlrn_chat::add_portlet', 'dotlrn_chat::add_portlet_helper', 'dotlrn_chat::remove_portlet' and 'dotlrn_chat::remove_applet'

Implement the 'dotlrn_applet::remove_applet_from_dotlrn' proc, called from different remove_applet procs, but never implemented

    • -0
    • +17
    • -0
    • +19
Replace xowf proctoring implementation with that coming from proctoring-support

TODO: nicer detection of whether proctoring-support package is actually installed

    • -7
    • +9
    • -239
    • +0
    • -208
    • +0
    • -67
    • +0
prefer SQL max() function over sort and limit 1

    • -3
    • +4
Make apm callbacks private and move them together with the others

Maintain also the has_child cache when mounting a package

Fix typo

Make installation procs private

When a new group is created, flush all the group::get_id caches with the same name so that the new group has a chance to be retrieved

Note that it is wrong to assume a group_name will be unique, although this is normally not far from the truth in our everyday practice

Cover more group api

this also exposes a potential problem with group::get_id when a group is created, deleted, and then a new one is created with the same name (e.g. executing the test multiple times). As the memoize cache is not maintained, the returned group_id will be incorrect.

Increase proc coverage

Reinstate lost queries for content::item::content_is_null

file content-item-procs-oracle.xql was initially added on branch oacs-5-10.

file content-item-procs-postgresql.xql was initially added on branch oacs-5-10.

Move examination statement acceptance as last step of the proctoring wizard, localize the accept button, bind ajax logging of acceptance to the actual clicking of the accept button

Improve test

New test for lang::util::convert_to_i18n pinpointing some expected behaviors of this proc

Upgrade CKEditor to 4.14.1

Improve doc and minor refactoring to reduce the diff with possible upcoming change

    • -10
    • +42
Fix typo

cache method "has_children" to avoid frequent (but cheap) DB calls

improve handling of errors, which are triggerd by the error template

acs-lang reform:

when calling lang::util::convert_to_i18n, do not always register a en_US translation, which will be otherwise always overridden. Instead, let lang::message::register make sure that a en_US message exists and create it only when needed as a fallback. Before, lang::message::register would return an error when e.g. a new message keys was registered for de_DE and no en_US was there. Now the en_US will be just created on the fly.

This does not break current automated tests

remove unnecessary parameter package_id

    • -2
    • +1
fix comment and missing arguemnt

use package based instantiate_forms method