• last updated 18 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Deprecate with_finally and with_catch, superseded by e.g. try idioms in tcl 8.6

They would also not comply with OpenACS naming convention

Whitespace cleanup

Whitespace cleanup

Rename get_survey_info, survey_answer_summary_display, survey_copy, survey_decode_boolean_answer, survey_display_types, survey_do_notifications, survey_get_score, survey_question_copy and survey_question_display to comply with OpenACS naming convention (all brought to the survey:: namespace), create deprecated wrappers, replace occurrences

    • -22
    • +140
    /openacs-4/packages/survey/tcl/survey-procs.tcl
    • -24
    • +24
    /openacs-4/packages/survey/tcl/survey-procs.xql
    • -4
    • +4
    /openacs-4/packages/survey/www/admin/one.tcl
  1. … 22 more files in changeset.
Whitespace cleanup

Whitespace cleanup

    • -42
    • +42
    /openacs-4/packages/survey/tcl/survey-procs.tcl
Fix typo

Bring sql inline, streamline sql idiom

Whitespace cleanup

Rename subsite_callback to comply with OpenACS naming convention, reduce divergency between oracle and postgres codebase

bump version number of ckeditor to 4.13.1

re-enable source_dependent operation (not clear, why this was commented out)

Rename string_truncate and string_truncate_middle to comply with OpenACS naming convention, create deprecated wrappers, replace occurrences

As string_truncate_middle was defined in xotcl-request-monitor, bring it to acs-tcl instead

Whitespace cleanup

Bring stack_dump in the templating:: namespace to comply with OpenACS naming convention, create deprecated wrapper

Rename ReturnHeaders proc to comply with OpenACS naming convention, create deprecated wrapper, replace occurrences

Rename proc remove_nulls_from_ns_set to comply with OpenACS naming convention, create deprecated wrapper

Fix typo

Doc formatting changes

Keep supporting previously undocumented use cases for lc_time_fmt:

- database timestamps e.g. "2019-12-16 12:58:10.370124+01"

- short timestamps without seconds e.g. "2019-12-16 12:58"

Improved documentation and extended test cases

Make sure, variable you_are_really is initialized

Adapt clock format for the now stricter 'lc_time_fmt'

Address lc_time_fmt shortcomings:

- use clock scan to enforce supported date formats, 'YYYY-MM-DD' (undocumented, but explicitly checked for in the code) and 'YYYY-MM-DD HH:MM:SS'

- leverage clock scan capabilities to correctly handle 'impossible dates' such as 1999-02-29

- leverage clock format to obtain the correct week day

- leverage clock api to correctly handle gregorian/julian dates

- implement documented formats that had an empty entry in format array (%W, u, %U, %j)

allow empty "correct_when" field

add minutes string to exam protocol

add support for multi-line entries in short_text answers

minor refactoring to general handling of printing minutes per question

    • -12
    • +11
    /openacs-4/packages/xowf/lib/online-exam-answer.wf
support multiple lines in text_fields (as used by sort-text questions)

Deprecate a bunch of date widget procs: they use hardcoded markup, lack localization, don't leverage existing tcl capabilities and most importantly are not in use anywhere in current codebase

Whitespace cleanup

Move CR search callbacks to new namespace in compliance with OpenACS naming convention, create deprecated wrappers, update service contract tables

file upgrade-5.10.0d7-5.10.0d8.sql was initially added on branch oacs-5-10.