• last updated 14 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Innova totally broke the servlet when moving queries from the tcl file to

a new xql file as part of the port to oracle effort. These changes were

committed WITHOUT TESTING and it took me HOURS TO FIND THE PROBLEMS, some

of which were easy to fix, some not. At the "some not" point, I decided to

just remove Innova's work because CHANGES NEED TO BE TESTED BEFORE BEING

COMMITTED. Innova can continue their work and commit after they've tested

it.

Hint: When there are several dynamic queries built up in a tcl string named

"todo" then executed as "db_dml todo $todo" you can NOT replace all of these

with one static query in the query file named "todo".

Sigh.

    • -467
    • +410
    /openacs-4/packages/lorsm/www/delivery/servlet.tcl
- bump version number

- extended interface to compound form fields (get_named_sub_component_value,generate_fieldnames)

- removed need for __refresh_instance_attributes

    • -3
    • +3
    /openacs-4/packages/xowiki/xowiki.info
Safari 3 parser didn't like the white space in javascript strings (showed up

in the error console).

Since template query files are executed in the global /templates context,

the query names must reflect this.

Typo in parameter description.

    • -1
    • +1
    /openacs-4/packages/xowiki/xowiki.info
- better CSS configuability for form-fields

Needed to qualify query names in the xql file

Fixed typo in new query added by daveb (I think)

Moved dotlrn permission kludges into a permission kludge callback, with

an implementation in dotlrn-lorsm. This keeps lorsm free of the dotlrn

specific permissions kludges while maintaining them within dotlrn (the only

supported way to add lorsm to a community or class is through the dotlrn-lorsm

applet package)

    • -2
    • +5
    /openacs-4/packages/lorsm/tcl/lorsm-procs.tcl
Changed stupid dotlrn_users reference to users

Added "-include_self" boolean to the application group package search

procs.

Include the current dotlrn instance in the application group search, since

portlets run in that context and need their community id.

    • -5
    • +34
    /openacs-4/packages/lors/tcl/lors-procs.tcl
Fixed broken IMG SRC attribute URLs to the "completed" status flag icons.

Someone put white space in them, leading to the safari "blue ?" image not

found being displayed. Fortunately this was new on HEAD, not in 2.4.1.

    • -15
    • +8
    /openacs-4/packages/lorsm/lib/user-lorsm.tcl
Changed constraint to fit our convention for abbreviation

Package extends change.

Moving to app group community id stuff (so lorsm can work outside .lrn), some

of this got committed accidently in an earlier bug fix commit.

    • -4
    • +4
    /openacs-4/packages/lorsm/lib/user-lorsm.tcl
    • -5
    • +3
    /openacs-4/packages/lorsm/tcl/lorsm-procs.tcl
    • -10
    • +0
    /openacs-4/packages/lorsm/tcl/lorsm-procs.xql
  1. … 20 more files in changeset.
Fixed broken URL for admin'ing course permissions. This was broken as far

back as 2.4.1 for sure (UNED tested on their instance, too).

    • -3
    • +3
    /openacs-4/packages/lorsm/www/admin/index.tcl
  1. … 3 more files in changeset.
Partially fixed assessment for oracle.

Jeffd's new constraints had names too long for oracle.

Fixed daveb's connect by and nextval, for initial install and upgrade (change

to acs_group.new)

- fix typo in method-name 'value_if_nothing_is_returned_from_form'

- improve indexing, when a large number of tags is used

    • -1
    • +4
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Update put the index creation before the table creation.

don't omit nls_language in forms when creating new pages

typo

use content::extlink instead of the deprecated content_extlink:: api, add content::extlink::edit function

the arg is -paramter not -name to parameter::get_from_package_key, not sure how this ever worked...

improve documentation

use parameter::get rather than ad_parameter

    • -2
    • +2
    /openacs-4/packages/search/lib/navbar.tcl
    • -2
    • +2
    /openacs-4/packages/search/tcl/search-procs.tcl
    • -6
    • +6
    /openacs-4/packages/search/www/search.tcl
get rid of the rest of the proc_doc calls

    • -1
    • +1
    /openacs-4/contrib/misc/db-cache-procs.tcl
  1. … 5 more files in changeset.
- fixing string range parameter

- iterate over input and textarea

    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl