OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 7
Total Committers: 146
Last Commit: 16:34
Commits this week: 7
Total Lines of Code (LoC): 7,561,347
Net change in LoC this week: 337

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Saturday 01 Dec 2001
4:41 pm

donb

After importing openacs.org users, forums and messages I discovered that it

took literally several minutes to load the APM's home page. This was due

to a rather stupid subselect of the form:

select count(*)

from content_revisions r

where r.revision_id = content_item.get_latest_revision(item_id)

where item_id comes from the package versions table.

It's stupid in both PG and Oracle because get_latest_revision already

joins the latest_revision_id value from cr_items with the content

revisions table thus a simple check for a null return by get_latest_revision

would be sufficient.

It's *really* stupid in Oracle because Oracle won't use the index on

revision_id when checking NULLs so we get two sequential scans of the

cr_revisions table tucked into that one itty-bitty subquery (itself called

once for each package version in ths system).

Which explains why I hadn't noticed it while working on scalability testing

in PG - PG uses the index because its btree index structure handles NULLs.

Meaning this query only fell apart at a rate of O(log2(R)) rather than O(R)

as in Oracle (R being the number of revision objects in the system).

My solution was to rewrite the subselect using "case" rather than "count(*)"

and also to speed up get_latest_revision by having it check for NULL and

return NULL immediately rather than execute the query (in PG this is

accomplished by declaring the function "isstrict", and the executor won't

even call the function if the argument's NULL, making it REALLY fast!).

Options
    • -3
    • +5
    /openacs-4/packages/acs-admin/www/apm/index-oracle.xql
    • -3
    • +5
    /openacs-4/packages/acs-admin/www/apm/index-postgresql.xql
    • -1
    • +5
    /openacs-4/packages/acs-content-repository/sql/oracle/content-item.sql
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/sql/postgresql/content-item.sql
Friday 30 Nov 2001
7:21 pm

oracle

ToCommunity update

Options
    • -2
    • +19
    /openacs-4/packages/dotlrn-news/tcl/dotlrn-news-procs.tcl
7:14 pm

oracle

ToCommunity updates

Options
    • -0
    • +18
    /openacs-4/packages/dotlrn-fs/sql/oracle/dotlrn-fs-create.sql
    • -2
    • +19
    /openacs-4/packages/dotlrn-fs/tcl/dotlrn-fs-procs.tcl
    • -0
    • +18
    /openacs-4/packages/dotlrn-news/sql/oracle/dotlrn-news-create.sql
7:12 pm

oracle

_to_community updates

Options
    • -2
    • +19
    /openacs-4/packages/dotlrn-faq/tcl/dotlrn-faq-procs.tcl
6:58 pm

oracle

ToCommunity update

Options
    • -0
    • +18
    /openacs-4/packages/dotlrn-faq/sql/oracle/dotlrn-faq-create.sql
6:56 pm

oracle

to_community updates

Options
    • -2
    • +20
    /openacs-4/packages/dotlrn-dotlrn/tcl/dotlrn-dotlrn-procs.tcl
6:42 pm

oracle

add to_community stuff

Options
    • -0
    • +21
    /openacs-4/packages/dotlrn-dotlrn/sql/oracle/dotlrn-dotlrn-create.sql
6:56 am

andrewg

Saving changes.

Options
    • -0
    • +15
    /openacs-4/packages/rss-support/sql/postgresql/rss-generation-create.sql
    • -1
    • +1
    /openacs-4/packages/rss-support/tcl/rss-generation-init.tcl
    • -24
    • +57
    /openacs-4/packages/rss-support/tcl/rss-generation-service-procs.tcl
    • -14
    • +19
    /openacs-4/packages/rss-support/www/subscr-ae.tcl
    • -0
    • +12
    /openacs-4/packages/rss-support/www/subscr-run.tcl
    • -4
    • +5
    /openacs-4/packages/rss-support/www/admin/subscrs.adp
    • -2
    • +12
    /openacs-4/packages/rss-support/www/admin/subscrs.tcl
5:06 am

ben

fixed an oracle XQL bug

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs-oracle.xql
4:41 am

ben

moved things to package_instantiate_object

Options
    • -3
    • +3
    /openacs-4/packages/dotlrn/sql/oracle/dotlrn-community-memberships-create.sql
    • -3
    • +3
    /openacs-4/packages/dotlrn/sql/oracle/dotlrn-init.sql
    • -76
    • +31
    /openacs-4/packages/dotlrn/tcl/class-procs.tcl
    • -0
    • +6
    /openacs-4/packages/dotlrn/tcl/class-procs.xql
    • -3
    • +2
    /openacs-4/packages/dotlrn/tcl/community-procs-oracle.xql
    • -15
    • +102
    /openacs-4/packages/dotlrn/tcl/community-procs.tcl
    • -0
    • +6
    /openacs-4/packages/dotlrn/tcl/community-procs.xql
    • -0
    • +20
    /openacs-4/packages/dotlrn/tcl/dotlrn-procs.tcl
    • -1
    • +1
    /openacs-4/packages/dotlrn/www/admin/class-instance-new.tcl
    • -1
    • +1
    /openacs-4/packages/dotlrn/www/admin/class-new-2.tcl
1:50 am

donb

Check the comments in postgresql.sql - my previous commit didn't quite work

as expected.

I also removed an ugly assumption made in the PG port in bboard-procs.tcl.

Options
    • -5
    • +7
    /openacs-4/contrib/obsolete-packages/bboard/tcl/bboard-procs-postgresql.xql
    • -15
    • +10
    /openacs-4/contrib/obsolete-packages/bboard/tcl/bboard-procs.tcl
    • -11
    • +16
    /openacs-4/packages/acs-kernel/sql/postgresql/postgresql.sql
12:11 am

oracle

updates

Options
    • -12
    • +52
    /openacs-4/packages/dotlrn-calendar/tcl/dotlrn-calendar-procs.tcl
Thursday 29 Nov 2001
11:51 pm

oracle

add applet/user update

Options
    • -0
    • +18
    /openacs-4/packages/dotlrn-calendar/sql/oracle/dotlrn-calendar-create.sql
11:49 pm

oracle

add user/applet updates

Options
    • -2
    • +22
    /openacs-4/packages/dotlrn-bboard/tcl/dotlrn-bboard-procs.tcl
11:46 pm

oracle

add applet/user updates

Options
    • -0
    • +21
    /openacs-4/packages/dotlrn-bboard/sql/oracle/dotlrn-bboard-create.sql
11:32 pm

oracle

Changed operations "AddApplet" and "AddUser" to refer to one time init

operations. The new ops "AddAppletToCommunity" and

"AddUserToCommunity" will replace the old ops.

Options
    • -4
    • +47
    /openacs-4/packages/dotlrn/sql/oracle/dotlrn-applet-sc-create.sql
11:19 pm

donb

Added "tree_left" and "tree_right" in order to optimize tree queries, which

I did for the bboard package. "LIKE (tree_sortkey || %)" never uses the

index as we thought it did, as it turns out ... see postgresql.sql for

example queries that do.

Options
    • -1
    • +3
    /openacs-4/contrib/obsolete-packages/bboard/sql/postgresql/bboard-create.sql
    • -3
    • +5
    /openacs-4/contrib/obsolete-packages/bboard/sql/postgresql/bboard-views.sql
    • -8
    • +30
    /openacs-4/packages/acs-kernel/sql/postgresql/postgresql.sql
9:14 pm

oracle

minor UI cleanup

Options
    • -6
    • +6
    /openacs-4/packages/new-portal/www/template-place-element.adp
8:58 am

ben

fixed an Oracle bug in ad_permission_grant query

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/acs-permissions-procs-oracle.xql
8:00 am

ben

fixed a few things

Options
    • -1
    • +1
    /openacs-4/packages/dotlrn/tcl/community-procs.tcl
8:00 am

ben

fixed bugs

Options
    • -3
    • +9
    /openacs-4/packages/dotlrn-bboard/tcl/dotlrn-bboard-procs.tcl
8:00 am

ben

added support for multiple param values

Options
    • -19
    • +12
    /openacs-4/packages/bboard-portlet/tcl/bboard-portlet-procs.tcl
    • -1
    • +59
    /openacs-4/packages/new-portal/tcl/portal-procs.tcl
7:05 am

ben

fixed breadcrumbs and stuff

Options
    • -2
    • +2
    /openacs-4/packages/dotlrn/sql/oracle/dotlrn-security-create.sql
    • -23
    • +14
    /openacs-4/packages/dotlrn/tcl/community-procs.tcl
    • -0
    • +2
    /openacs-4/packages/dotlrn/tcl/dotlrn-procs.tcl
    • -5
    • +37
    /openacs-4/packages/dotlrn/tcl/navigation-procs.tcl
    • -1
    • +1
    /openacs-4/packages/dotlrn/www/community-applets.tcl
    • -0
    • +1
    /openacs-4/packages/dotlrn/www/community-user-add.adp
    • -0
    • +1
    /openacs-4/packages/dotlrn/www/community-user-add.tcl
    • -1
    • +2
    /openacs-4/packages/dotlrn/www/admin/class-instance-new.adp
    • -0
    • +7
    /openacs-4/packages/dotlrn/www/admin/class-instance-new.tcl
    • -0
    • +1
    /openacs-4/packages/dotlrn/www/admin/class-new.adp
    • -1
    • +1
    /openacs-4/packages/dotlrn/www/admin/class-new.tcl
    • -0
    • +1
    /openacs-4/packages/dotlrn/www/admin/classes.adp
    • -0
    • +1
    /openacs-4/packages/dotlrn/www/admin/classes.tcl
    • -0
    • +1
    /openacs-4/packages/dotlrn/www/admin/index.adp
    • -0
    • +1
    /openacs-4/packages/dotlrn/www/admin/index.tcl
  16. … 7 more files in changeset.
6:10 am

ben

added rel segments creation

Options
    • -1
    • +5
    /openacs-4/packages/dotlrn/tcl/class-procs.tcl
    • -0
    • +56
    /openacs-4/packages/dotlrn/tcl/community-procs.tcl
    • -8
    • +4
    /openacs-4/packages/dotlrn/tcl/community-procs.xql
    • -3
    • +26
    /openacs-4/packages/dotlrn/tcl/dotlrn-security-procs.tcl
5:46 am

ben

fixed a bug in the calendar naming

Options
    • -2
    • +2
    /openacs-4/packages/dotlrn-calendar/tcl/dotlrn-calendar-procs.tcl
5:33 am

ben

fixed nasty non-user situation

Options
    • -0
    • +5
    /openacs-4/packages/dotlrn/www/index-not-a-user.adp
    • -0
    • +2
    /openacs-4/packages/dotlrn/www/index.tcl
5:01 am

ben

more security updates

Options
    • -0
    • +2
    /openacs-4/packages/dotlrn/sql/oracle/dotlrn-create.sql
4:44 am

ben

added privilege creation

Options
    • -0
    • +56
    /openacs-4/packages/dotlrn/sql/oracle/dotlrn-security-create.sql
3:34 am

oracle

log all ds errors

Options
    • -4
    • +3
    /openacs-4/packages/new-portal/www/render-element.tcl
3:28 am

oracle

pass the portal_template_id along

Options
    • -0
    • +3
    /openacs-4/packages/dotlrn/sql/oracle/dotlrn-classes-create.sql