• last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Add documentation for public procs (fixes automated tests), uniform indentation, uniform documentation style

    • -1158
    • +1156
    /openacs-4/packages/assessment/tcl/as-install-procs.tcl
Add documentation to public procs (fixes automated tests), simplify idioms, exploit current api

    • -12
    • +0
    /openacs-4/packages/news/tcl/news-procs-oracle.xql
    • -42
    • +55
    /openacs-4/packages/news/tcl/news-procs.tcl
Add documentation to public api (fixes automated tests), indentation changes

    • -4
    • +11
    /openacs-4/packages/views/tcl/views-procs.tcl
Add documentation for public procs (fixes automated tests), replace faq with forum

Add documentation for public proc (fixes automated tests), feed user_id from arguments to permission api, explicitly default to current user (as called procs would do anyway)

Uniform documentation style, add documentation for public proc (fixes automated tests)

Deprecate (former) service contract implementations

Their body was always empty according to the cvs history and there is no mention of them in the code.

Their counterpart in the forum::notification namespace takes care of both forums and messages, therefore supersedes them.

Clearly separate callback hooks from callback implementations, uniform documentation style, remove duplicated callback implementation definitions, uniform indentation, add documentation to public procs (fixes automated tests)

Add documentation to public procs (fixes automated tests)

Uniform documentation style

Move callback hooks definitions together with their siblings, add documentation to public procs (fixes automated tests)

Add documentation for public procs (fixes automated tests)

Add documentation for public procs (fixes tests), normalize indentation

    • -129
    • +142
    /openacs-4/packages/faq/tcl/test/tclwebtest-procs.tcl
Add missing documentation for public proc, small refactoring to exploit current api

    • -44
    • +36
    /openacs-4/packages/faq/tcl/q-and-a-procs.tcl
    • -23
    • +0
    /openacs-4/packages/faq/tcl/q-and-a-procs.xql
Add documentation to public callback hook (fixes automated tests)

reduce verbosity

    • -3
    • +7
    /openacs-4/packages/xowiki/tcl/import-procs.tcl
Fix acs_attribute type to match that of the database table (fixes test)

Remove leftover acs_attribute definitions with no database table counterpart (fixes tests)

Fix mismatched acs_attribute datatype with respect to related table (fixes automated tests)

Skip test for those applets associated with a package_id of 0 (happens when no community with this applet is on the system, verified that for 'real' applets this is fine)

Set package_id explicitly as the main subsite package, as ad_conn package_id could not be properly initialized when a system was freshly restarted

Set package_id explicitly as the main subsite package, as ad_conn package_id could not be properly initialized for tests when a system was freshly restarted

Fix regression test by recreating test file: as it seems, put operation destroys it

Simplify idioms, handle also the case where multiple results might come from the query, as the datamodel doesn't state it clearly and we also had a suspicious orderby

Skip test when tclwebtest is not available

Fix News automated tests:

- rename tests using underscore instead of '-' or links in UI would not work

- remove duplicated SQL

- fix awkward hardcoded dates that were supposed to be in the future for test to work

Put cache flushing logics into procs and use them when forum info needs to be updated (fixes automated tests)

    • -2
    • +19
    /openacs-4/packages/forums/tcl/forums-procs.tcl
Add documentation and a fallback body for this deprecated proc

    • -2
    • +11
    /openacs-4/packages/forums/tcl/forums-procs.tcl
revive xo::list_to_values as it is used by the forthcoming caldav package

Fix test on system having 0.0.0.0 as IPv4 address in the config file