• last updated 3 hours ago
Constraints: committers
Constraints: files
Constraints: dates
move "-destroy_on_cleanup" towards the end of the parameter list

This change improves protection about ambiguous user input

  1. … 8 more files in changeset.
use CSSclass "form-range" for Bootstrap5

more fixups fr bootstrap5

use for bootstrap5 for select input form-select instead of form-control

Many thanks to Monika Andergassen for noting

improved spelling

  1. … 2 more files in changeset.
intensify validation of form variables

  1. … 1 more file in changeset.
improved parameter checking

  1. … 3 more files in changeset.
Factor out Package->process_init_parameter into package-custom-procs

This change makes it easier to provide instance specific customization.

In general, these package-custom-procs could also be kept in other


  1. … 4 more files in changeset.
Provide some means to change the behavior of a single package instance

- New package parameter: PackageInitParameter

When set to some value other than empty, the package "init" method

(e.g. of xowiki::Package, or one of the subclasses) can handle

this separately.

- This submit adds a handler for the value "swa-only", and returns

a user-friendly message in this case. Of course, we could achieve

something similar via permissions as well, but this allows us

to tailor the behavior in more details.

- In general, this mechanism can also be used to provide some hints

about some specific packages, or tailor these in some other ways.

- Currently, this new package parameter is not added to the

.info file, so configure it via parameter pages.

  1. … 1 more file in changeset.
Value checkers will let empty values pass through

E.g. for a query like "?popular=&summary=1", the checker won't complain for "popular" being empty. Make sure empty values are normalized to false.

increased value checking for paramter that might be influenced by user input

  1. … 8 more files in changeset.
Strip the possible validation constraint after the first colon character when building the cache key for a parameter, so that the value is stored correctly regardless of the format used to query the parameter

Fixes xowiki.xowiki_test_cases automated test

improved checking of parameter values, which might be influenced via query parameters

  1. … 6 more files in changeset.
improve field validation

  1. … 3 more files in changeset.
Added support for passing parameter_name:value_constraint to xowiki::Package->get_parameter

- The get_parameter method can get values from query-parameters, therefore

we have to validate these.

- Use the new feature at several places (especially for boolean values)

- Still, more places should be checked

- bumped xowiki to 5.10.1d37

- bumped xotcl-core to 5.10.1d14

  1. … 10 more files in changeset.
improve spelling

  1. … 7 more files in changeset.
improve spacing on inline radio boxes in bootstrap5 (many thanks to Monika Andergassen)

  1. … 1 more file in changeset.
new proc "ad_log_deprecated": unified interface for logging deprecated usages

The existing code used a larger variety of different messages to

denote invocations of deprecated procs and other

artifacts. "ad_log_deprecated" provides a unified interface, and

provides a usage hint what to use instead based on the API-doc

definitions in the log-file.

  1. … 11 more files in changeset.
rename "iconified file" to "thumbnail file"

  1. … 3 more files in changeset.
Generalized handling of local_return_url

I am not fully happy with the handlings of "return_url" in exam workflows.

Maybe this can be reworked in a way such that "local_return_url" is not

neccsessary in the future.

  1. … 1 more file in changeset.
Improved support for composite questions and bootstrap 5

This fixes a bug when composite questions were generated with

bootstrap3 and rendered later with bootstrap5.

  1. … 1 more file in changeset.
improve bootstrap5 compatibility for inclass exam

  1. … 1 more file in changeset.
undo recent change, which is not sufficiently general (and solve the issue by db means, next commit)

  1. … 1 more file in changeset.
Address the cornercase of form pages having their template stored in the same folder: when deleting items containing such a setup, cleanup these formpages first

Addresses a consequence of https://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Agustafn%3A20220613165033

  1. … 1 more file in changeset.
fix typo

Styling changes for minimal setups

This change is necessary for minimal setups, e.g. for plain installs

during regression test, when no bootstrap packages are available.

- define yui as last-resort fallback for "toolkit"

- handle CSS class composition for YUI as well

(merge of class-specific and item specific CSS classes,

used for color management for publish status button)

- remove underline for publish-status in YUI mode

  1. … 2 more files in changeset.
provide basic support to make bootstrap3 and 5 switchable

bumped version to 5.10.1d25

  1. … 3 more files in changeset.
Alignments for Bootstrap 5

Also, use form.form for creating forms from the menubar instead of

old-strle ::xowiki::Forms. Aligned as well regression test to use


Bump version number to 5.10.1d24

  1. … 9 more files in changeset.
Perform stricter checking of parent_ids

bump version number of xowiki to 5.10.1d22

  1. … 3 more files in changeset.
prefer global variable over proc

  1. … 6 more files in changeset.