OpenACS / openacs-4 / packages / xowiki / tcl

form-field-procs.tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 9
Last Commit: 20 Jan 19
Commits this week: 0
Total Lines of Code (LoC): 4,137
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 29 Aug
11:51 am

antoniop

Use existing api to tell whether a formfield is disabled or not and to set/unset disabled on a field, handle the case of checkboxes and select fields, where the attribute should not be set whe it is false (e.g. disabled=0 == disabled)

This fixes upstream automated tests on xowiki and xowf

Options
    • -21
    • +31
    ./form-field-procs.tcl
  2. … 1 more file in changeset.
Thursday 25 Aug
11:53 am

gustafn

Fixed serious bug killing at least short-text questions in inclass exam

The bug was introduced in [1], by testing for the existence of the

disabled attribute, and when it exists, it was omitting values

reading. The problem is that when form-fields are reset, the

"disabled" attribute is set to 0, leading the exists check to

succeed. In essence, This change sets now the default value of the

form-field to "0", such that it is safe to test it everywhere.

Originally, it was not set by default to save resources (memory and

processing power), but this requires a more careful analysis when

changes happen.

[1] https://fisheye.openacs.org/browse/OpenACS/openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl?r1=1.368.2.125&r2=1.368.2.126

Options
    • -2
    • +2
    ./form-field-procs.tcl
  2. … 1 more file in changeset.
Tuesday 23 Aug
4:53 pm

antoniop

Port of downstream hotfix: questions defined with an empty scoring might later fail the score calculations

One might consider preventing empty scores altogether via validation

Options
    • -3
    • +3
    ./form-field-procs.tcl
Wednesday 06 Jul
6:14 pm

gustafn

fix compatibility with tdom 0.9.3

Options
    • -2
    • +2
    ./form-field-procs.tcl
Monday 09 May
7:29 pm

gustafn

fix for old-style ad_form based forms with radio or checkbox controls for bootstrap 5

These controls were used with a bootstrap3 classes, which had the consequence

that no input was possible for these fields. Probably, similar changes

are as well necessary in other situations as well.

Options
    • -2
    • +11
    ./form-field-procs.tcl
Thursday 05 May
9:11 am

trenner

escape also brackets

Options
    • -2
    • +2
    ./form-field-procs.tcl
Thursday 14 Apr
12:04 pm

gustafn

prefer variable over method invocation

Options
    • -3
    • +4
    ./form-field-procs.tcl
Wednesday 13 Apr
6:03 pm

gustafn

improve wording

Options
    • -3
    • +3
    ./form-field-procs.tcl
Sunday 03 Apr
4:42 pm

gustafn

provide basic support to make bootstrap3 and 5 switchable

bumped version to 5.10.1d25

Options
    • -14
    • +30
    ./form-field-procs.tcl
  2. … 3 more files in changeset.
Friday 01 Apr
3:47 pm

gustafn

Alignments for Bootstrap 5

Also, use form.form for creating forms from the menubar instead of

old-strle ::xowiki::Forms. Aligned as well regression test to use

form.form.

Bump version number to 5.10.1d24

Options
    • -9
    • +3
    ./form-field-procs.tcl
  2. … 9 more files in changeset.
Thursday 31 Mar
4:16 pm

trenner

increase robustness

Options
    • -5
    • +9
    ./form-field-procs.tcl
Friday 25 Mar
8:13 pm

gustafn

use preferred idioms to use btn-default/btn-secondary for bootstrap3/bootstrap5

Options
    • -2
    • +2
    ./form-field-procs.tcl
  2. … 2 more files in changeset.
Tuesday 15 Mar
12:53 pm

gustafn

refine form.form and validation errors

Options
    • -10
    • +35
    ./form-field-procs.tcl
  2. … 1 more file in changeset.
Monday 14 Mar
1:25 pm

gustafn

align instance variable values of formfield "form" with "textarea" to make subclassing simpler

Options
    • -2
    • +3
    ./form-field-procs.tcl
Wednesday 09 Mar
5:50 pm

gustafn

reduce level of verboseness

Options
    • -3
    • +9
    ./form-field-procs.tcl
5:48 pm

gustafn

fix bug: tcl clock format %e returns in current versions single digit values with leading whitespace, which are invalid values for the options field.

Since non of the date-component fields is supposed to contain leading (or trailing) white-space,

this is now trimmed.

Options
    • -5
    • +16
    ./form-field-procs.tcl
  2. … 1 more file in changeset.
Sunday 06 Mar
7:00 pm

gustafn

Extend randomization of multiple alternatives for cases, where one alternative must be "true"

Certain evaluation schemes for multiple choice questions require that

at least one alternative must be true. Otherwise, a division by 0

might appear. This is an issue, when a subset of alternatives is used

(e.g. 3 out of 10 alternatives). The version know evaluation schemes

with such a requirement and makes sure that in the resulting set, at

least one correct alternative is correct. Note: this change does not

make sure that the full set of alternatives contains at least one

correct alternative.

Options
    • -6
    • +36
    ./form-field-procs.tcl
Saturday 05 Mar
10:27 am

gustafn

include field name in debug message

Options
    • -2
    • +2
    ./form-field-procs.tcl
Friday 04 Mar
10:11 pm

gustafn

add canvas evaluation scheme of MC questions

Options
    • -4
    • +6
    ./form-field-procs.tcl
  2. … 3 more files in changeset.
3:55 pm

antoniop

Treat disabled form fields as they are: fields that the browser would not send to us and need to be treated "internally"

Options
    • -11
    • +2
    ./form-field-procs.tcl
  2. … 1 more file in changeset.
11:30 am

gustafn

fix typo

Options
    • -2
    • +2
    ./form-field-procs.tcl
Thursday 03 Mar
8:37 pm

gustafn

Delete CKEditor 3 (which was replaced by CKEditor 4 in 2012)

CKEditor 4 is continued to be supported.

Options
    • -188
    • +1
    ./form-field-procs.tcl
  2. … 605 more files in changeset.
8:00 pm

gustafn

comment recent smelly change

+CVS: ----------------------------------------------------------------------

Options
    • -1
    • +10
    ./form-field-procs.tcl
7:40 pm

gustafn

Support specification of allowed tags/attributes/protocols via global package parameters.

This change makes it possible to define for a package values for

AllowedTags, AllowedAttributes, or AllowedProtocols. If (some of)

these exist, use these for configuring "ad_html_security_check". If +

not, fall back to the default (site wide) definition.

This change is fully backward compatible and effects on sites defining

such global parameters. This change was induced by the need of large

sites, where it is not feasible to set these parameters on the package

instance level, since this site has 830000 packages instances.

Bump version number to 5.10.1d19

Options
    • -4
    • +25
    ./form-field-procs.tcl
  2. … 2 more files in changeset.
Wednesday 02 Mar
3:03 pm

antoniop

Actually not enforce options validation on disabled formfields

Options
    • -2
    • +2
    ./form-field-procs.tcl
Friday 18 Feb
4:19 pm

antoniop

The reorder_box must always be treated as a multiple field

Options
    • -1
    • +9
    ./form-field-procs.tcl
1:14 pm

antoniop

Explicitly set the :plugin <variable>

Options
    • -2
    • +2
    ./form-field-procs.tcl
11:14 am

antoniop

Support the extraPlugins attribute the same as the CKEditor4 richtext formfield, as some places in xowiki assume it

Options
    • -2
    • +5
    ./form-field-procs.tcl
Tuesday 01 Feb
10:07 pm

gustafn

issue error for unexpected value

Options
    • -5
    • +4
    ./form-field-procs.tcl
6:03 pm

antoniop

date formfield does not need special conversion when converting to external, its value is already converted when rendered

Options
    • -1
    • +9
    ./form-field-procs.tcl