OpenACS / openacs-4 / packages / xowiki / tcl

form-field-procs.tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 9
Last Commit: 20 Jan 19
Commits this week: 0
Total Lines of Code (LoC): 4,137
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 14 Sep
12:26 am

gustafn

move "-destroy_on_cleanup" towards the end of the parameter list

This change improves protection about ambiguous user input

Options
    • -8
    • +12
    ./form-field-procs.tcl
  2. … 8 more files in changeset.
Thursday 03 Aug
12:31 pm

gustafn

fix indentation

Options
    • -2
    • +2
    ./form-field-procs.tcl
Tuesday 25 Jul
11:54 am

gustafn

minor change in comment

Options
    • -2
    • +2
    ./form-field-procs.tcl
Friday 19 May
7:46 pm

gustafn

fix for short-text-questions

for short-text-questions, correct when is empty (an empty

list) when multiple subquestions exists. The old code

did not handle this case and checked just for the existance

of the variable.

many thanks to markus moser for the fix.

Options
    • -8
    • +15
    ./form-field-procs.tcl
Wednesday 19 Apr
7:31 pm

gustafn

improved parameter checking

Options
    • -2
    • +2
    ./form-field-procs.tcl
  2. … 3 more files in changeset.
Saturday 11 Mar
11:56 am

gustafn

revert escaped change

Options
    • -2
    • +2
    ./form-field-procs.tcl
Monday 27 Feb
7:42 pm

gustafn

rename helper form-field to avoid potential confusion with value checkers

Options
    • -5
    • +5
    ./form-field-procs.tcl
Wednesday 22 Feb
1:57 pm

gustafn

increased value checking for paramter that might be influenced by user input

Options
    • -6
    • +6
    ./form-field-procs.tcl
  2. … 8 more files in changeset.
Tuesday 24 Jan
12:28 pm

antoniop

Protect against malicious inputs, where the value won't be a list

Options
    • -3
    • +3
    ./form-field-procs.tcl
Thursday 22 Dec 2022
3:51 am

gustafn

improve strictness of tests

Options
    • -3
    • +5
    ./form-field-procs.tcl
  2. … 8 more files in changeset.
Thursday 15 Dec 2022
2:17 pm

gustafn

improve field validation

Options
    • -2
    • +2
    ./form-field-procs.tcl
  2. … 3 more files in changeset.
Saturday 12 Nov 2022
6:05 pm

gustafn

Added support for drag&drop on reorder items for mobile devices

Additionally, provided a minimal width for drag items (there is probably a better solution for this)

Options
    • -2
    • +5
    ./form-field-procs.tcl
  2. … 2 more files in changeset.
Tuesday 08 Nov 2022
2:24 pm

gustafn

Added support for passing parameter_name:value_constraint to xowiki::Package->get_parameter

- The get_parameter method can get values from query-parameters, therefore

we have to validate these.

- Use the new feature at several places (especially for boolean values)

- Still, more places should be checked

- bumped xowiki to 5.10.1d37

- bumped xotcl-core to 5.10.1d14

Options
    • -2
    • +2
    ./form-field-procs.tcl
  2. … 10 more files in changeset.
Tuesday 25 Oct 2022
1:10 pm

trenner

add information how many pages are currently selected in dnd mode

Options
    • -5
    • +5
    ./form-field-procs.tcl
  2. … 1 more file in changeset.
Monday 24 Oct 2022
11:00 am

gustafn

use the highcharts package if available

Options
    • -3
    • +13
    ./form-field-procs.tcl
  2. … 1 more file in changeset.
Wednesday 19 Oct 2022
8:29 pm

gustafn

added support for pie chart statistics (deactivated by default)

Options
    • -12
    • +38
    ./form-field-procs.tcl
Tuesday 18 Oct 2022
2:58 pm

trenner

implement optional bulk operations for candidate_box_select in dnd mode

Options
    • -1
    • +26
    ./form-field-procs.tcl
  2. … 1 more file in changeset.
Thursday 06 Oct 2022
7:27 pm

gustafn

improve spacing on inline radio boxes in bootstrap5 (many thanks to Monika Andergassen)

Options
    • -3
    • +3
    ./form-field-procs.tcl
  2. … 1 more file in changeset.
Wednesday 05 Oct 2022
11:51 am

gustafn

Styling improvements for exam answering workflows (many thanks to Monika Andergassen)

- provide explicit text to "next" and "previous" buttons in pagination menu

- align appearance of "next" and "previous" buttons in pagination menu with GitHub

- removed class "input-group" for compound fields to improve appearance

- bumped version number of xowf to 5.10.1d48

Options
    • -2
    • +2
    ./form-field-procs.tcl
  2. … 4 more files in changeset.
Monday 29 Aug 2022
11:51 am

antoniop

Use existing api to tell whether a formfield is disabled or not and to set/unset disabled on a field, handle the case of checkboxes and select fields, where the attribute should not be set whe it is false (e.g. disabled=0 == disabled)

This fixes upstream automated tests on xowiki and xowf

Options
    • -21
    • +31
    ./form-field-procs.tcl
  2. … 1 more file in changeset.
Thursday 25 Aug 2022
11:53 am

gustafn

Fixed serious bug killing at least short-text questions in inclass exam

The bug was introduced in [1], by testing for the existence of the

disabled attribute, and when it exists, it was omitting values

reading. The problem is that when form-fields are reset, the

"disabled" attribute is set to 0, leading the exists check to

succeed. In essence, This change sets now the default value of the

form-field to "0", such that it is safe to test it everywhere.

Originally, it was not set by default to save resources (memory and

processing power), but this requires a more careful analysis when

changes happen.

[1] https://fisheye.openacs.org/browse/OpenACS/openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl?r1=1.368.2.125&r2=1.368.2.126

Options
    • -2
    • +2
    ./form-field-procs.tcl
  2. … 1 more file in changeset.
Tuesday 23 Aug 2022
4:53 pm

antoniop

Port of downstream hotfix: questions defined with an empty scoring might later fail the score calculations

One might consider preventing empty scores altogether via validation

Options
    • -3
    • +3
    ./form-field-procs.tcl
Wednesday 06 Jul 2022
6:14 pm

gustafn

fix compatibility with tdom 0.9.3

Options
    • -2
    • +2
    ./form-field-procs.tcl
Monday 09 May 2022
7:29 pm

gustafn

fix for old-style ad_form based forms with radio or checkbox controls for bootstrap 5

These controls were used with a bootstrap3 classes, which had the consequence

that no input was possible for these fields. Probably, similar changes

are as well necessary in other situations as well.

Options
    • -2
    • +11
    ./form-field-procs.tcl
Thursday 05 May 2022
9:11 am

trenner

escape also brackets

Options
    • -2
    • +2
    ./form-field-procs.tcl
Thursday 14 Apr 2022
12:04 pm

gustafn

prefer variable over method invocation

Options
    • -3
    • +4
    ./form-field-procs.tcl
Wednesday 13 Apr 2022
6:03 pm

gustafn

improve wording

Options
    • -3
    • +3
    ./form-field-procs.tcl
Sunday 03 Apr 2022
4:42 pm

gustafn

provide basic support to make bootstrap3 and 5 switchable

bumped version to 5.10.1d25

Options
    • -14
    • +30
    ./form-field-procs.tcl
  2. … 3 more files in changeset.
Friday 01 Apr 2022
3:47 pm

gustafn

Alignments for Bootstrap 5

Also, use form.form for creating forms from the menubar instead of

old-strle ::xowiki::Forms. Aligned as well regression test to use

form.form.

Bump version number to 5.10.1d24

Options
    • -9
    • +3
    ./form-field-procs.tcl
  2. … 9 more files in changeset.
Thursday 31 Mar 2022
4:16 pm

trenner

increase robustness

Options
    • -5
    • +9
    ./form-field-procs.tcl