• last updated 13 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
fix boolean adp expression

  1. … 5 more files in changeset.
Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 475 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 225 more files in changeset.
- fix and standardize quoting in template properties

  1. … 174 more files in changeset.
- standardize url construction to protect against injection attacks

  1. … 18 more files in changeset.
overhaul of package:

- favor tcl-compilable string comparisons

- don't use numeric comparison operator for non-numeric arguments

- brace expressions

- replace depreacted "ad_parameter" by parameter::get

- use "in" or "ni" expression instead of "lsearch"

- use tcl 8.5 extended index format for "string range"

  1. … 19 more files in changeset.
- use "lassign" instead of "util_unlist"

- use <property name="doc(title)">

  1. … 48 more files in changeset.
- replace deprecated calls

  1. … 3 more files in changeset.
- added victor's patch to omit deprecated messages of "ns_info tcllib". Background: naviserver supports multiple (virtual) servers, which might have different tcllibs. Therefore, the preferred command to query this was moved to "ns_server ?-server s? tcllib" and "ns_info tcllib" was deprecated. From the OpenACS point of view, one wants to locate the actual library. Since the variable does not change, it is fine to store it in a per-thread variable which can be efficiently accessed.

  1. … 21 more files in changeset.
1. Merge 2.4.1 to HEAD other than assessment, imsld, lorsm, and views.

2. Bump version numbers to 2.5.0d1.

  1. … 379 more files in changeset.
Checkpoint 3.7 (level AA): Mark up quotations. Do not use quotation markup for formatting effects such as indentation.

  1. … 73 more files in changeset.
Made larsblogger use HTML notifications

  1. … 10 more files in changeset.
First shot at merging oacs-5-2 apps used in .LRN to HEAD.

  1. … 2464 more files in changeset.
Message key of list-template actions used the '_' function and were not correctly displayed. Replaced with #..#

commit to OACS-5-2 merge of changes on OACS-5-1

(using tag vg-merge-dotlrn-2-1-20050922) for packages under dotlrn-all

  1. … 25 more files in changeset.
Missing permission URL

I18N Fixes

  1. … 9 more files in changeset.
I18N of Weblogger

  1. … 14 more files in changeset.
Added permission link

fix missing rdbms things and a few oracle or postgresisms that snuck in the wrong files

  1. … 54 more files in changeset.
Add a CategoryContainer parameter which defaults to package_id but can

be subsite_id (when lars-blogger should use the same catagory trees as the subsite,

might make sense to support mainsite as well).

Categories now display with counts and indented to reflect structure,

currently omits empty categories.

bump version for paramter, bump dependency for categories since it uses

category_tree::get_multirow now.

  1. … 4 more files in changeset.
Ported from postgres.

    • -0
    • +42
    ./blogroll-ae-oracle.xql
    • -0
    • +11
    ./blogroll-delete-oracle.xql
  1. … 2 more files in changeset.
Got rid of old weblogs_ping parameters

    • -0
    • +11
    ./ping-url-add-api.tcl
  1. … 4 more files in changeset.
Removed entry-edit from admin yet again

Commiting integration of Site Wide Categories into Weblogger. While

implementing this I've also fixed numerous random bugs.

Some comments off the top of my head regarding this implementation:

* Weblogger currently doesn't take advantage of nested categories. You

can use trees that are nested but categories in those trees are

treated as if they were all flat.

* I've provided a migration script from old to new categories. The

script just copies data and doesn't delete anything. It is written

in Tcl so that it can take advantage of the APIs.

* I left the legacy categories in system. There are several reasons

for that:

- Site-Wide categories don't have short names and thus speaking

URLs are not implemented. Some people might prefer to keep

speaking URLs, especially if they don't want to break them

after migration

- Blogger-specific categories are simpler and thus easier to use.

- Having both solutions available for a while makes transition less

painful.

* I had lots of problems with Oracle port. At first I thought just

that it is slightly instable because we are working on HEAD and

categories are in flux... Only after having fixed a lot of bugs I

realized that LEGACY CATEGOIRIES NEVER WORKED IN ORACLE. At that

point it was easier to make them actually work in oracle :-)

* Actually it seems that the whole Weblogger never worked in Oracle, I

was fixing bugs such as broken filtering by date (because Oracle's

trunc() uses different format strings from PostgreSQL's date_trunc()

etc. etc.

* Juggling pieces of Tcl from .tcl to .xql (via variable and command

substitution) and pieces of SQL from .xql to .tcl (via db_map) was

fun :-)

* Implementing nested multirows (to show all categories one object is

in), in combination with included templates thought me a lot about

the templating system. One of the lessons: <multirow name="@foo@">

with variable could actually work if a bunch of bugs with variable

substitution were fixed in templating system. Until then using:

template::multirow -local -ulevel 1 upvar $foo myfoo will be

necessary.

* Some extensions for db_multirow, <multiple> and friends to support

grouping and tables-within-tables would be really useful. I didn't

dare do such large-scale hacks on db_multirow

* one-entry{tcl,adp} should be replaced with blog{tcl,adp} - after all

getting one entry is just a special case of getting many entries.

    • -0
    • +89
    ./migrate-categories-1.tcl
    • -0
    • +19
    ./migrate-categories.adp
    • -0
    • +18
    ./migrate-categories.tcl
  1. … 12 more files in changeset.
Hooking in site-wide categories to admin pages.

ul.action-links

  1. … 2 more files in changeset.
Use edit/delete gifs and standard location

Title 'Administration'