• last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Replace deprecated 'can_read_forum_p' by 'permission::permission_p'

Replace deprecated procs with 'permission::require_permission'

    • -14
    • +14
    ./www/admin/subscribe-others-2.tcl
  1. … 3 more files in changeset.
Deprecate wrappers for 'permission::permission_p' and permission::require_permission.

  1. … 4 more files in changeset.
Create 'ad_include_contract' for forums portlet

Prefer literal in adp expressions + Whitespace changes

  1. … 6 more files in changeset.
Exploit users cache, simplify SQL

    • -2
    • +16
    ./lib/forums/forums-history-chunk.tcl
    • -12
    • +0
    ./lib/forums/forums-history-chunk.xql
Shorten expression, exploit cache

use more consistent spelling of names

Prefer individual 'set' operations over 'lassign' in these particular cases

  1. … 6 more files in changeset.
Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 473 more files in changeset.
unify spelling of URL

  1. … 1 more file in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 224 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 204 more files in changeset.
Rework variable assignment (set -> lassign)

  1. … 10 more files in changeset.
Fix typos

  1. … 7 more files in changeset.
remove parens

improve spelliing

  1. … 2 more files in changeset.
Fix typos

  1. … 61 more files in changeset.
fix more typos

  1. … 5 more files in changeset.
Fix typos

  1. … 7 more files in changeset.
Fix typos

  1. … 3 more files in changeset.
fix typo

- fix inconsistency between updated versions and new intallations: check always the message format

- add text/markdown to accepted formats

    • -0
    • +11
    ./sql/postgresql/upgrade/upgrade-1.3.1d4-1.3.1d5.sql
delete unreferenced .xql queries

    • -35
    • +0
    ./lib/search/search-chunk-oracle.xql
Make termination after connection closing commands explicit

  1. … 1 more file in changeset.
Fix boolean expressions in -adp files, make termination after connection closing commands explicit

  1. … 18 more files in changeset.
add ad_script_abort after ad_returnredirect to make termination intent explicit

  1. … 7 more files in changeset.
Reduce divergencies between oracle and postgres codebase

    • -10
    • +0
    ./lib/forums/forums-chunk-oracle.xql
    • -11
    • +0
    ./lib/forums/forums-chunk-postgresql.xql
    • -0
    • +15
    ./lib/forums/forums-chunk.xql
  1. … 3 more files in changeset.
Reduce divergencies between oracle and postgres codebase

    • -29
    • +0
    ./lib/message/threads-chunk-oracle.xql
    • -32
    • +0
    ./lib/message/threads-chunk-postgresql.xql
Make forum::use_ReadingInfo_p more robust when UseReadingInfo parameter in forums is not set