OpenACS / openacs-4 / packages

forums

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 61
Last Commit: 28 Nov
Commits this week: 0
Total Lines of Code (LoC): 22,611
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 25 Jun 2018
11:26 am

antoniop

Fix regression when checking if user can anonimously post

Options
    • -2
    • +2
    ./tcl/forums-security-procs.tcl
11:15 am

antoniop

Fix regressions in forums when user is not logged in

Options
    • -7
    • +23
    ./lib/forums/forums-history-chunk.tcl
    • -3
    • +8
    ./lib/message/post.tcl
    • -2
    • +3
    ./lib/message/row.adp
    • -4
    • +10
    ./lib/message/row.tcl
    • -8
    • +13
    ./lib/message/threads-chunk.tcl
    • -5
    • +11
    ./tcl/messages-procs.tcl
Monday 18 Jun 2018
4:22 pm

antoniop

Disambiguate table reference in subquery

Options
    • -13
    • +13
    ./tcl/messages-procs-oracle.xql
    • -13
    • +13
    ./tcl/messages-procs-postgresql.xql
Friday 15 Jun 2018
10:55 pm

antoniop

Avoid two times the same query just because we might filter by forum

Options
    • -20
    • +2
    ./lib/search/search-chunk-oracle.xql
    • -20
    • +2
    ./lib/search/search-chunk-postgresql.xql
    • -12
    • +10
    ./lib/search/search-chunk.tcl
10:50 pm

antoniop

Pass user_name through the message array, as message-view expects it there

Options
    • -2
    • +2
    ./lib/message/row.adp
    • -4
    • +4
    ./lib/message/row.tcl
10:26 pm

antoniop

This obscure script doesn't do much (basically, displays the content of a message), but nevertheless was passing arrays, defining queries, duplicating code... streamlined to the bones

Options
    • -46
    • +0
    ./lib/message/content-updater-oracle.xql
    • -51
    • +0
    ./lib/message/content-updater-postgresql.xql
    • -8
    • +0
    ./lib/message/content-updater.adp
    • -45
    • +0
    ./lib/message/content-updater.tcl
    • -4
    • +1
    ./www/load-message-content.adp
    • -3
    • +9
    ./www/load-message-content.tcl
9:59 pm

antoniop

Remove redundant variables, dead code and bring variables closer to where they are actually used... still room for improvement here

Options
    • -3
    • +8
    ./lib/message/row.adp
    • -16
    • +5
    ./lib/message/row.tcl
    • -2
    • +0
    ./lib/message/thread-chunk-oracle.xql
    • -10
    • +4
    ./lib/message/thread-chunk-postgresql.xql
    • -19
    • +15
    ./lib/message/thread-chunk.tcl
6:46 pm

antoniop

Use more api to streamline queries and reduce divergency between oracle and postgres codebase

Options
    • -22
    • +4
    ./tcl/messages-procs-oracle.xql
    • -28
    • +6
    ./tcl/messages-procs-postgresql.xql
    • -7
    • +22
    ./tcl/messages-procs.tcl
Tuesday 12 Jun 2018
12:04 am

gustafn

move template cacheing function "cache" into template namespace (resulting in template::cache)

Options
    • -2
    • +2
    ./tcl/forums-procs.tcl
  2. … 2 more files in changeset.
Monday 11 Jun 2018
4:31 pm

antoniop

Reduce divergencies between oracle and postgres codebase, reduce the need for joins and stored procedures

Options
    • -41
    • +0
    ./lib/message/threads-chunk-oracle.xql
    • -41
    • +0
    ./lib/message/threads-chunk-postgresql.xql
    • -5
    • +12
    ./lib/message/threads-chunk.tcl
    • -6
    • +24
    ./lib/message/threads-chunk.xql
4:04 pm

antoniop

Centralize templating cache "black magic"

Use the new proc into forum api

Options
    • -5
    • +1
    ./lib/message/post.tcl
    • -4
    • +21
    ./tcl/forums-procs.tcl
Thursday 07 Jun 2018
8:08 pm

hectorr

Replace deprecated 'forum::security::can_moderate_forum_p' by 'permission::permission_p'

Options
    • -21
    • +21
    ./lib/message/post.tcl
    • -8
    • +16
    ./tcl/forums-security-procs.tcl
    • -6
    • +6
    ./www/message-post.tcl
7:53 pm

hectorr

Replace deprecated 'can_read_forum_p' by 'permission::permission_p'

Options
    • -3
    • +4
    ./tcl/forums-security-procs.tcl
7:09 pm

hectorr

Replace deprecated procs with 'permission::require_permission'

Options
    • -14
    • +14
    ./www/admin/subscribe-others-2.tcl
  2. … 3 more files in changeset.
6:52 pm

hectorr

Deprecate wrappers for 'permission::permission_p' and permission::require_permission.

Options
    • -11
    • +19
    ./tcl/forums-security-procs.tcl
  2. … 4 more files in changeset.
Wednesday 06 Jun 2018
4:34 pm

hectorr

Create 'ad_include_contract' for forums portlet

Options
    • -1
    • +1
    ./lib/forums-portlet.adp
    • -41
    • +29
    ./lib/forums-portlet.tcl
Tuesday 22 May 2018
7:07 pm

hectorr

Prefer literal in adp expressions + Whitespace changes

Options
    • -31
    • +31
    ./lib/forums-portlet.adp
  2. … 6 more files in changeset.
5:59 pm

antoniop

Exploit users cache, simplify SQL

Options
    • -2
    • +16
    ./lib/forums/forums-history-chunk.tcl
    • -12
    • +0
    ./lib/forums/forums-history-chunk.xql
5:27 pm

antoniop

Shorten expression, exploit cache

Options
    • -6
    • +2
    ./lib/search/search-chunk.tcl
Thursday 17 May 2018
9:41 am

gustafn

use more consistent spelling of names

Options
    • -2
    • +2
    ./lib/message/thread-chunk.tcl
12:04 am

hectorr

Prefer individual 'set' operations over 'lassign' in these particular cases

Options
    • -2
    • +3
    ./lib/message/attachment-list.tcl
  2. … 6 more files in changeset.
Wednesday 09 May 2018
5:33 pm

hectorr

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

Options
    • -2
    • +2
    ./lib/forums/forums-chunk.tcl
    • -2
    • +2
    ./lib/message/threads-chunk.tcl
    • -2
    • +2
    ./tcl/forums-sc-procs.tcl
  4. … 473 more files in changeset.
Monday 30 Apr 2018
11:07 am

gustafn

unify spelling of URL

Options
    • -3
    • +3
    ./tcl/forums-callback-procs.tcl
    • -2
    • +2
    ./tcl/forums-sc-procs.tcl
    • -1
    • +1
    ./tcl/test/tclwebtest-procs.tcl
  4. … 1 more file in changeset.
Thursday 26 Apr 2018
10:56 am

hectorr

Prefer '{}' to '[list]' when creating empty lists

Options
    • -2
    • +2
    ./lib/forums/forums-chunk.tcl
    • -2
    • +2
    ./lib/message/threads-chunk.tcl
  3. … 224 more files in changeset.
Wednesday 25 Apr 2018
9:47 pm

hectorr

Prefer '{}' to '[list]' when creating empty lists

Options
    • -2
    • +2
    ./tcl/forums-sc-procs.tcl
  2. … 204 more files in changeset.
Tuesday 24 Apr 2018
4:28 pm

hectorr

Rework variable assignment (set -> lassign)

Options
    • -7
    • +4
    ./lib/forums-portlet.tcl
    • -3
    • +2
    ./lib/message/attachment-list.tcl
    • -8
    • +6
    ./www/admin/subscribe-others.tcl
  4. … 10 more files in changeset.
Thursday 19 Apr 2018
12:25 am

hectorr

Fix typos

Options
    • -7
    • +7
    ./tcl/messages-procs.tcl
  2. … 7 more files in changeset.
Saturday 07 Apr 2018
9:07 pm

gustafn

remove parens

Options
    • -2
    • +2
    ./lib/forums/admin-forums-chunk.tcl
    • -2
    • +2
    ./lib/forums/forums-chunk.tcl
    • -1
    • +1
    ./lib/forums/forums-history-chunk.tcl
    • -2
    • +2
    ./lib/message/delete.tcl
    • -2
    • +2
    ./lib/message/messages-table.tcl
    • -2
    • +2
    ./lib/message/pending-list-chunk.tcl
    • -2
    • +2
    ./lib/message/threads-chunk.tcl
    • -2
    • +2
    ./lib/search/search-chunk.tcl
    • -4
    • +8
    ./www/moderate/move-thread-thread.tcl
Wednesday 04 Apr 2018
6:18 am

gustafn

improve spelliing

Options
    • -2
    • +2
    ./sql/postgresql/forums-messages-package-create.sql
    • -1
    • +1
    ./sql/postgresql/upgrade/upgrade-1.2d1-1.2d2.sql
  3. … 2 more files in changeset.
Thursday 29 Mar 2018
5:03 pm

hectorr

Fix typos

Options
    • -1
    • +1
    ./sql/postgresql/upgrade/upgrade-1.3.1d2-1.3.1d3.sql
  2. … 61 more files in changeset.