OpenACS / openacs-4 / packages / forums

tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 39
Last Commit: 28 Nov
Commits this week: 0
Total Lines of Code (LoC): 3,775
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 20 Mar 2023
2:17 pm

antoniop

Increase proc coverage

Options
    • -9
    • +44
    ./test/forums-procs.tcl
Friday 24 Feb 2023
2:19 pm

antoniop

Give priority to the information provided explicitly to the api (the forum_id) in order to determine the package id and fallback to the connection context only when this is not available

Options
    • -12
    • +37
    ./forums-procs.tcl
Thursday 31 Mar 2022
6:33 pm

antoniop

Replace the lame template::util::get_opts with some homemade utility that will parse arguments reliably, adjust the one upstream use case where arguments other than those documented might be passed to the element creation, introduce a warning when this happens somewhere else

Options
    • -5
    • +4
    ./form-procs.tcl
  2. … 1 more file in changeset.
Monday 03 Jan 2022
1:58 pm

antoniop

Replace reference to long-missing message key

Options
    • -3
    • +3
    ./messages-procs.tcl
Thursday 02 Sep 2021
8:29 pm

gustafn

fix recent editing bug

Options
    • -2
    • +2
    ./messages-procs.tcl
6:40 pm

gustafn

improve spelling

Options
    • -3
    • +3
    ./messages-procs.tcl
  2. … 42 more files in changeset.
Sunday 29 Aug 2021
4:48 pm

gustafn

fixed categorization of test case

Options
    • -2
    • +2
    ./test/forums-procs.tcl
Wednesday 23 Jun 2021
11:24 am

hectorr

Add 'forum_enable_disable' test case, covering 'forum::enable' and 'forum::disable'

Options
    • -1
    • +50
    ./test/forums-procs.tcl
Friday 30 Apr 2021
11:05 am

antoniop

Fix typo

Options
    • -2
    • +2
    ./forums-callback-procs.tcl
Thursday 29 Apr 2021
4:03 pm

antoniop

Handle correctly the indexing of moderated messages in fulltext search:

so far the fulltext search would also include unapproved messages and threads. With this reform we address this by:

- making sure unapproved threads are deleted from the index

- making sure new threads are added to the index only when the are approved

- making sure we unindex or reindex a thread whenever the approval state changes

- not fetching unapproved messages in the datasource callback, hence excluding them from the index

Note that Oracle has not been targeted by the reform. However, the situation improves for Oracle as well, because we won't render unmoderated messages in the datasource callback anymore.

Options
    • -1
    • +4
    ./forums-callback-procs.tcl
  2. … 3 more files in changeset.
Wednesday 31 Mar 2021
3:13 pm

gustafn

improve listing of procs covered by regression test

Options
    • -11
    • +44
    ./test/forums-procs.tcl
  2. … 2 more files in changeset.
Wednesday 03 Mar 2021
3:53 pm

hectorr

Prefer using 'user_info' over 'user_id' when calling 'acs::test::http'

Options
    • -5
    • +5
    ./test/forums-procs.tcl
    • -1
    • +6
    ./test/webtest-procs.tcl
Monday 22 Feb 2021
5:25 pm

antoniop

Skip deprecated api that is neutralized by the next upgrade, reinstate deprecated api just for upgrade purposes, complies with acs-api-browser.graph__bad_calls automated test

Options
    • -2
    • +4
    ./forums-install-procs.tcl
    • -3
    • +5
    ./forums-sc-procs.tcl
5:13 pm

antoniop

Whitespace cleanup

Options
    • -7
    • +7
    ./forums-sc-procs.tcl
Tuesday 16 Feb 2021
9:59 pm

gustafn

improve listing of test coverage

Options
    • -4
    • +37
    ./test/forums-procs.tcl
  2. … 17 more files in changeset.
7:54 am

trenner

consider subject field restriction from the database also in the ui

Options
    • -1
    • +1
    ./form-procs.tcl
Monday 01 Feb 2021
11:58 am

gustafn

make end of options explicit

Options
    • -3
    • +3
    ./forums-callback-procs.tcl
    • -2
    • +2
    ./messages-procs.tcl
  3. … 16 more files in changeset.
Tuesday 11 Aug 2020
3:35 pm

antoniop

Fix typo

Options
    • -2
    • +2
    ./messages-procs.tcl
Saturday 08 Aug 2020
1:19 pm

gustafn

improve spelling

Options
    • -3
    • +3
    ./messages-procs.tcl
  2. … 16 more files in changeset.
Tuesday 21 Jul 2020
3:58 pm

gustafn

prefer "ns_conn isconnected" over "ad_conn isconnected", since the latter might not notice changes in the connect state

Options
    • -2
    • +2
    ./forums-callback-procs.tcl
    • -2
    • +2
    ./forums-sc-procs.tcl
    • -2
    • +2
    ./messages-procs.tcl
  4. … 16 more files in changeset.
Friday 29 May 2020
12:40 pm

antoniop

Kill message key translation only when the original user message is included in the notification

Options
    • -10
    • +11
    ./messages-procs.tcl
12:37 pm

antoniop

Do not kill localization for moderator notifications, as they contain indeed message keys to be localized

Options
    • -10
    • +1
    ./messages-procs.tcl
Wednesday 13 May 2020
4:31 pm

antoniop

Implement a new type of "Moderator" notification type for forums

This notification will be triggered also by unapproved messages. The UI will show the subscription link only to forum moderators, using a different color (customizable via css, vanilla color is red). Message content will always be hidden for such notifications, so user will need to have access to new message.

Options
    • -1
    • +87
    ./forums-install-procs.tcl
    • -3
    • +88
    ./messages-procs.tcl
  3. … 6 more files in changeset.
Tuesday 12 May 2020
5:33 pm

antoniop

Step in the direction of implementing a new kind of "moderator notification": move current notification behavior in a private api, remove dependency on message approval in message::new (also avoids a query)

Options
    • -6
    • +25
    ./messages-procs.tcl
5:21 pm

antoniop

Fix typo

Options
    • -2
    • +3
    ./messages-procs.tcl
4:39 pm

antoniop

Comment unused computations

Options
    • -11
    • +12
    ./messages-procs.tcl
4:30 pm

antoniop

Small refactoring

Options
    • -7
    • +10
    ./messages-procs.tcl
Thursday 07 May 2020
4:43 pm

antoniop

Move logics to create forum notification type to tcl to:

- reduce code duplication

- make it simpler to extend forums with new notification types

This reform was triggered by a downstream request, where users would like a new kind of notification for forum moderators that triggers also when a forum message has not been approved

Options
    • -1
    • +95
    ./forums-install-procs.tcl
  2. … 4 more files in changeset.
10:34 am

antoniop

Complete a long standing transition (before 5.5): rely on callbacks intead of service contracts to implement FTS datasource logics in the forums package

Options
    • -3
    • +14
    ./forums-install-procs.tcl
    • -11
    • +41
    ./forums-sc-procs.tcl
  3. … 1 more file in changeset.
Tuesday 25 Feb 2020
5:55 pm

hectorr

Prefer acs::test::reply_has_status_code over manually checking status code in the reply

Options
    • -17
    • +28
    ./test/webtest-procs.tcl