• last updated 11 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Step in the direction of implementing a new kind of "moderator notification": move current notification behavior in a private api, remove dependency on message approval in message::new (also avoids a query)

Fix typo

Comment unused computations

Small refactoring

Move logics to create forum notification type to tcl to:

- reduce code duplication

- make it simpler to extend forums with new notification types

This reform was triggered by a downstream request, where users would like a new kind of notification for forum moderators that triggers also when a forum message has not been approved

  1. … 4 more files in changeset.
Complete a long standing transition (before 5.5): rely on callbacks intead of service contracts to implement FTS datasource logics in the forums package

  1. … 1 more file in changeset.
Prefer acs::test::reply_has_status_code over manually checking status code in the reply

added editor hints and white-space cleanup

  1. … 24 more files in changeset.
Fix typo

Use fully-qualified api names

Indentation changes

Deprecate obsolete api

No need to explicitly delete reading info, as both oracle and postgres define the reference constraint as on delete cascade

Use fully-qualified api names

Use fully-qualified api names, assume message is there (something went very wrong otherwise)

Reduce divergency between oracle and postgres codebase

Reduce divergency between oracle and postgres codebase

Whitespace cleanup

Deprecate obsolete api

Implement operation in a way that oracle is supported

Add @see for deprecated procs

Reduce divergency between oracle and postgres codebase

    • -43
    • +0
    ./forums-callback-procs-postgresql.xql
Only show the possibility to allow/disallow attachments in the forum new/edit pages if the attachments package is already mounted under the forums package instance

  1. … 2 more files in changeset.
Whitespace changes

  1. … 2 more files in changeset.
Modify user interface to allow/disallow attachments per forum, on forum creation and editing. Added message keys and bumped version as well.

  1. … 6 more files in changeset.
Extend 'forum::attachments_enabled_p' with 'forum_id', so attachments ca be enabled per forum (see previous commit), and update underliying logic to make use of it.

  1. … 2 more files in changeset.
Initialize d variable

Fix call parameters

- prefer "last_request" over "user_id" in automated tests

- make web test more robust against local language dependencies

  1. … 1 more file in changeset.
avoid double substitutions

  1. … 2 more files in changeset.