OpenACS / openacs-4 / packages / file-storage

www

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 45
Last Commit: 21 Nov
Commits this week: 0
Total Lines of Code (LoC): 5,928
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 21 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 07 Dec 2018
12:34 pm

antoniop

Prettify code

Options
    • -10
    • +20
    ./file-add.tcl
12:12 pm

antoniop

Remove obsolete xql files

Options
    • -31
    • +0
    ./version-delete-oracle.xql
    • -26
    • +0
    ./version-delete-postgresql.xql
    • -25
    • +0
    ./version-delete.xql
1:02 am

antoniop

Bugfixes et al:

- don't throw a server error if one clicks submit on the empty form without specifying a file

- allow to upload the same zipfile multiple times without throwing an error

- streamline idioms

Options
    • -48
    • +26
    ./file-add.tcl
Thursday 06 Dec 2018
4:48 pm

antoniop

File storage max upload limit reform:

the max upload limit will now default to empty. Rationale: this value is

one that ages quickly with respect to new storage requirements, and is

currently set to something incompatible with the vanilla Naviserver configuration

(500MB fs vs 20MB ns).

The upgrade script will make so that instances setting this parameter

higher than the server upload limit configuration will be

set empty as well (this would never have an effect, as server

will prevent the upload altogheter anyway).

Max upload limit in bytes is now retrieved from a proc implementing

this fallback to server configuration logics. Other than centralizing,

its purpose is to be used in client-side code checks in the future

so we could prevent a doomed upload in advance.

Options
    • -2
    • +2
    ./file-add.tcl
    • -2
    • +2
    ./folder-zip-add.tcl
    • -2
    • +2
    ./admin/upload-size-limit.tcl
  4. … 4 more files in changeset.
Monday 17 Sep 2018
4:23 pm

hectorr

Whitespace changes

Options
    • -102
    • +101
    ./file-add.tcl
    • -84
    • +83
    ./folder-add.tcl
  3. … 2 more files in changeset.
4:15 pm

hectorr

Fix typos and wording.

Options
    • -2
    • +2
    ./folder-add.tcl
  2. … 1 more file in changeset.
Thursday 13 Sep 2018
11:53 am

trenner

create folder only if it not already exists

Options
    • -2
    • +5
    ./folder-zip-add.tcl
Tuesday 17 Jul 2018
8:51 am

antoniop

Remove commented leftover debugging statement, add comment about why we need to name the list by folder_id

Options
    • -3
    • +4
    ./folder-chunk.tcl
Monday 16 Jul 2018
6:43 pm

antoniop

Put template::list name back as parametric, because this code might be included multiple times

Options
    • -1
    • +1
    ./folder-chunk-oracle.xql
    • -1
    • +1
    ./folder-chunk-postgresql.xql
    • -1
    • +1
    ./folder-chunk.adp
    • -2
    • +4
    ./folder-chunk.tcl
5:52 pm

antoniop

Redefine this page as ad_include_contract, therefore removing all hardcoded variable checks and exploit builtin checks, remove duplicated definitions and queries, streamline template::list definitions in a way its is readable and simpler to maintain

Options
    • -16
    • +6
    ./folder-chunk-oracle.xql
    • -62
    • +7
    ./folder-chunk-postgresql.xql
    • -1
    • +1
    ./folder-chunk.adp
    • -104
    • +116
    ./folder-chunk.tcl
5:37 pm

antoniop

Pass also orderby to the includelet

Options
    • -1
    • +1
    ./index.adp
3:55 pm

antoniop

Trim whitespaces

Options
    • -12
    • +12
    ./folder-chunk.tcl
3:55 pm

antoniop

Remove unnecessary parentheses and idioms, state query variables explicitly

Options
    • -9
    • +20
    ./folder-chunk.tcl
9:44 am

gustafn

don't pass deprecated argumentent "-user_id" to fs::get_folder_contents_count

Options
    • -7
    • +4
    ./index.tcl
  2. … 1 more file in changeset.
Thursday 28 Jun 2018
2:30 pm

hectorr

Prefer 'person::name' to 'acs_user::get_element ... -name'

Options
    • -3
    • +2
    ./file.tcl
  2. … 1 more file in changeset.
Friday 22 Jun 2018
12:40 pm

antoniop

Exploit api instead of using local sql

Options
    • -10
    • +5
    ./folder-delete.tcl
    • -28
    • +0
    ./folder-delete.xql
Thursday 21 Jun 2018
10:47 am

michaela

Localize possible I18n message in folder name

Options
    • -2
    • +2
    ./folder-delete.tcl
Friday 15 Jun 2018
5:11 pm

antoniop

While working on reducing divergencies between oracle and postgres codebase and testing changes I have found the following issues:

- fs::add_created_version.new_text_revision query was defined in postgres only

- version-delete and folder-delete were broken in case notification was enabled,

because this was issued after object was deleted and therefore all references

needed to build notification message were missing (and query failed looking up the object)

Options
    • -39
    • +13
    ./folder-delete.tcl
    • -26
    • +17
    ./version-delete.tcl
  3. … 3 more files in changeset.
11:27 am

antoniop

Reduce divergency between oracle and postgres codebase and remove redundant statements

Options
    • -17
    • +0
    ./file-oracle.xql
    • -43
    • +0
    ./file-postgresql.xql
    • -8
    • +22
    ./file.tcl
Thursday 14 Jun 2018
4:46 pm

michaela

Dont even offer to delete the root folder as this is prevented anyway

Options
    • -2
    • +2
    ./folder-chunk.tcl
Wednesday 09 May 2018
5:33 pm

hectorr

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

Options
    • -2
    • +2
    ./folder-chunk.tcl
  2. … 475 more files in changeset.
Monday 30 Apr 2018
9:57 am

gustafn

improve query name

Options
    • -1
    • +1
    ./search-oracle.xql
    • -1
    • +1
    ./search-postgresql.xql
    • -2
    • +2
    ./search.tcl
9:57 am

gustafn

regenerated documentation

Options
    • -34
    • +24
    ./doc/design.adp
    • -2
    • +1
    ./doc/index.adp
Thursday 26 Apr 2018
10:56 am

hectorr

Prefer '{}' to '[list]' when creating empty lists

Options
    • -2
    • +2
    ./folder-chunk.tcl
  2. … 225 more files in changeset.
Saturday 07 Apr 2018
9:13 pm

gustafn

remove conditions, which are always true

remove parens

Options
    • -2
    • +2
    ./file-add.tcl
    • -3
    • +3
    ./folder-zip-add.tcl
    • -4
    • +4
    ./index.tcl
Saturday 24 Mar 2018
12:53 am

hectorr

Fix more typos

Options
    • -1
    • +1
    ./doc/design.adp
    • -1
    • +1
    ./doc/design.html
  3. … 83 more files in changeset.
Friday 19 Jan 2018
3:18 pm

gustafn

add required ad_script_abort after ad_returnredirect

Options
    • -2
    • +2
    ./simple-add-2.tcl
    • -1
    • +2
    ./simple-delete.tcl
    • -1
    • +2
    ./simple-edit.tcl
    • -1
    • +3
    ./url-goto.tcl
    • -1
    • +2
    ./admin/upload-size-limit.tcl
  6. … 9 more files in changeset.
1:03 pm

gustafn

add required ad_script_abort after ad_returnredirect

Options
    • -1
    • +2
    ./file-edit.tcl
    • -3
    • +4
    ./folder-add.tcl
    • -2
    • +2
    ./simple-add.tcl
Thursday 18 Jan 2018
4:29 pm

trenner

add required ad_script_abort after ad_returnredirect

Options
    • -1
    • +2
    ./folder-edit.tcl
Friday 29 Dec 2017
12:26 pm

gustafn

Use "ad_try" instead of "with_catch"

Options
    • -9
    • +10
    ./download-zip.tcl
  2. … 1 more file in changeset.