OpenACS / openacs-4 / packages / file-storage

www

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 45
Last Commit: 21 Nov
Commits this week: 0
Total Lines of Code (LoC): 5,928
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 21 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 16 Jul 2018
6:43 pm

antoniop

Put template::list name back as parametric, because this code might be included multiple times

Options
    • -1
    • +1
    ./folder-chunk-oracle.xql
    • -1
    • +1
    ./folder-chunk-postgresql.xql
    • -1
    • +1
    ./folder-chunk.adp
    • -2
    • +4
    ./folder-chunk.tcl
5:52 pm

antoniop

Redefine this page as ad_include_contract, therefore removing all hardcoded variable checks and exploit builtin checks, remove duplicated definitions and queries, streamline template::list definitions in a way its is readable and simpler to maintain

Options
    • -16
    • +6
    ./folder-chunk-oracle.xql
    • -62
    • +7
    ./folder-chunk-postgresql.xql
    • -1
    • +1
    ./folder-chunk.adp
    • -104
    • +116
    ./folder-chunk.tcl
5:37 pm

antoniop

Pass also orderby to the includelet

Options
    • -1
    • +1
    ./index.adp
3:55 pm

antoniop

Trim whitespaces

Options
    • -12
    • +12
    ./folder-chunk.tcl
3:55 pm

antoniop

Remove unnecessary parentheses and idioms, state query variables explicitly

Options
    • -9
    • +20
    ./folder-chunk.tcl
9:44 am

gustafn

don't pass deprecated argumentent "-user_id" to fs::get_folder_contents_count

Options
    • -7
    • +4
    ./index.tcl
  2. … 1 more file in changeset.
Thursday 28 Jun 2018
2:30 pm

hectorr

Prefer 'person::name' to 'acs_user::get_element ... -name'

Options
    • -3
    • +2
    ./file.tcl
  2. … 1 more file in changeset.
Friday 22 Jun 2018
12:40 pm

antoniop

Exploit api instead of using local sql

Options
    • -10
    • +5
    ./folder-delete.tcl
    • -28
    • +0
    ./folder-delete.xql
Thursday 21 Jun 2018
10:47 am

michaela

Localize possible I18n message in folder name

Options
    • -2
    • +2
    ./folder-delete.tcl
Friday 15 Jun 2018
5:11 pm

antoniop

While working on reducing divergencies between oracle and postgres codebase and testing changes I have found the following issues:

- fs::add_created_version.new_text_revision query was defined in postgres only

- version-delete and folder-delete were broken in case notification was enabled,

because this was issued after object was deleted and therefore all references

needed to build notification message were missing (and query failed looking up the object)

Options
    • -39
    • +13
    ./folder-delete.tcl
    • -26
    • +17
    ./version-delete.tcl
  3. … 3 more files in changeset.
11:27 am

antoniop

Reduce divergency between oracle and postgres codebase and remove redundant statements

Options
    • -17
    • +0
    ./file-oracle.xql
    • -43
    • +0
    ./file-postgresql.xql
    • -8
    • +22
    ./file.tcl
Thursday 14 Jun 2018
4:46 pm

michaela

Dont even offer to delete the root folder as this is prevented anyway

Options
    • -2
    • +2
    ./folder-chunk.tcl
Wednesday 09 May 2018
5:33 pm

hectorr

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

Options
    • -2
    • +2
    ./folder-chunk.tcl
  2. … 475 more files in changeset.
Monday 30 Apr 2018
9:57 am

gustafn

improve query name

Options
    • -1
    • +1
    ./search-oracle.xql
    • -1
    • +1
    ./search-postgresql.xql
    • -2
    • +2
    ./search.tcl
9:57 am

gustafn

regenerated documentation

Options
    • -34
    • +24
    ./doc/design.adp
    • -2
    • +1
    ./doc/index.adp
Thursday 26 Apr 2018
10:56 am

hectorr

Prefer '{}' to '[list]' when creating empty lists

Options
    • -2
    • +2
    ./folder-chunk.tcl
  2. … 225 more files in changeset.
Saturday 07 Apr 2018
9:13 pm

gustafn

remove conditions, which are always true

remove parens

Options
    • -2
    • +2
    ./file-add.tcl
    • -3
    • +3
    ./folder-zip-add.tcl
    • -4
    • +4
    ./index.tcl
Saturday 24 Mar 2018
12:53 am

hectorr

Fix more typos

Options
    • -1
    • +1
    ./doc/design.adp
    • -1
    • +1
    ./doc/design.html
  3. … 83 more files in changeset.
Friday 19 Jan 2018
3:18 pm

gustafn

add required ad_script_abort after ad_returnredirect

Options
    • -2
    • +2
    ./simple-add-2.tcl
    • -1
    • +2
    ./simple-delete.tcl
    • -1
    • +2
    ./simple-edit.tcl
    • -1
    • +3
    ./url-goto.tcl
    • -1
    • +2
    ./admin/upload-size-limit.tcl
  6. … 9 more files in changeset.
1:03 pm

gustafn

add required ad_script_abort after ad_returnredirect

Options
    • -1
    • +2
    ./file-edit.tcl
    • -3
    • +4
    ./folder-add.tcl
    • -2
    • +2
    ./simple-add.tcl
Thursday 18 Jan 2018
4:29 pm

trenner

add required ad_script_abort after ad_returnredirect

Options
    • -1
    • +2
    ./folder-edit.tcl
Friday 29 Dec 2017
12:26 pm

gustafn

Use "ad_try" instead of "with_catch"

Options
    • -9
    • +10
    ./download-zip.tcl
  2. … 1 more file in changeset.
Thursday 23 Nov 2017
11:07 am

antoniop

Fix typo

Options
    • -1
    • +1
    ./file-oracle.xql
11:06 am

antoniop

Reduce divergencies between oracle and postgres codebase by using api when available and avoiding unnecessary xql queries

Options
    • -23
    • +1
    ./file-oracle.xql
    • -21
    • +0
    ./file-postgresql.xql
    • -5
    • +4
    ./file.tcl
Tuesday 21 Nov 2017
12:35 pm

antoniop

Reduce divergencies between oracle and postgres codebase

Options
    • -8
    • +0
    ./folder-chunk-oracle.xql
    • -8
    • +0
    ./folder-chunk-postgresql.xql
    • -8
    • +14
    ./folder-chunk.xql
Monday 06 Nov 2017
12:45 pm

antoniop

Revert db_exec_plsql or Oracle will break, remove leftover xql files

Options
    • -17
    • +0
    ./folder-delete-oracle.xql
    • -15
    • +0
    ./folder-delete-postgresql.xql
  3. … 1 more file in changeset.
Friday 03 Nov 2017
4:58 pm

antoniop

Reduce divergence between oracle and postgres

Options
    • -25
    • +1
    ./move-oracle.xql
    • -40
    • +1
    ./move-postgresql.xql
    • -20
    • +28
    ./move.tcl
4:11 pm

antoniop

Uniform API when deleting folder, drill through some calling levels in stored procedure, use a simpler db_string instead of db_exec_plsql

Options
    • -6
    • +3
    ./folder-delete.tcl
  2. … 2 more files in changeset.
Monday 02 Oct 2017
9:20 am

gustafn

Fix boolean expressions in .adp file

Options
    • -1
    • +1
    ./file.adp
    • -1
    • +1
    ./simple.adp
Sunday 01 Oct 2017
2:09 pm

gustafn

Bug fix: avoid confusion between command argument and option, when argument starts with "-"

Options
    • -1
    • +1
    ./delete.tcl
  2. … 81 more files in changeset.