OpenACS / openacs-4 / packages / file-storage

www

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 45
Last Commit: 21 Nov
Commits this week: 0
Total Lines of Code (LoC): 5,928
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 20 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 19 Sep 2017
2:50 pm

antoniop

Fix idiom to check for string being populated

Options
    • -1
    • +1
    ./file.adp
12:47 pm

antoniop

Use full <if @foo_p@ true> instead of undocumented shortcut idiom <if @foo_p@>

Options
    • -1
    • +1
    ./file.adp
  2. … 1 more file in changeset.
10:56 am

trenner

normalize expression in adp

Options
    • -1
    • +1
    ./folder-chunk.adp
Tuesday 08 Aug 2017
1:47 am

gustafn

merged changes from the oacs-5-9 branch and resolved conflicts

Options
    • -5
    • +9
    ./copy-oracle.xql
    • -23
    • +25
    ./copy-postgresql.xql
    • -8
    • +35
    ./copy.tcl
    • -1
    • +7
    ./delete.tcl
    • -7
    • +13
    ./download-zip.tcl
    • -21
    • +0
    ./file-add.adp
    • -46
    • +86
    ./file-add.tcl
    • -8
    • +0
    ./file-add.xql
    • -14
    • +0
    ./file-edit-oracle.xql
    • -12
    • +0
    ./file-edit-postgresql.xql
    • -3
    • +8
    ./file-edit.tcl
    • -6
    • +3
    ./file-postgresql.xql
    • -1
    • +7
    ./file-upload-confirm.tcl
    • -2
    • +2
    ./file.adp
    • -15
    • +51
    ./file.tcl
  16. … 7820 more files in changeset.
Sunday 06 Aug 2017
1:31 pm

gustafn

regenerated ducumentation

Options
    • -2
    • +2
    ./doc/requirements.adp
  2. … 251 more files in changeset.
Wednesday 02 Aug 2017
10:08 am

gustafn

Modernize script:

- use export_vars

- reduce redundancy

- remove misleading SQL statements

- brace SQL statements, when no substitutions are needed

Options
    • -34
    • +27
    ./version-delete.tcl
9:36 am

gustafn

pass required return url to included adp

Options
    • -1
    • +1
    ./permissions.adp
    • -1
    • +2
    ./permissions.tcl
Monday 17 Jul 2017
7:49 pm

trenner

add check before file moving to avoid violation of 'cr_items_unique_name' constraint

Options
    • -2
    • +10
    ./move-postgresql.xql
    • -43
    • +48
    ./move.tcl
Tuesday 11 Jul 2017
4:31 pm

gustafn

Fixed a seemingly 11 years old bug

Options
    • -3
    • +4
    ./index.vuh
Thursday 08 Jun 2017
6:42 pm

antoniop

- Introduce new proc ad_sanitize_filename implementing current best practices for ensuring a valid filename on most filesystems.

- Use it in every place where filename sanitization is performed in the code and deprecate fs::remove_special_file_system_characters.

TODO deprecate also util_text_to_html? Use case of sanitizing urls and filenames might have different requirements.

Options
    • -3
    • +1
    ./folder-chunk.tcl
    • -2
    • +5
    ./folder-create.tcl
  3. … 4 more files in changeset.
Tuesday 30 May 2017
2:00 pm

antoniop

Fix typo

Options
    • -1
    • +1
    ./folder-delete.adp
1:58 pm

antoniop

Check if we have already a folder with same name before inserting, or we get error in the logs.

Remove small duplication

Options
    • -8
    • +15
    ./folder-create.tcl
Wednesday 24 May 2017
6:09 pm

antoniop

Prevent user from selecting source folder as destination folder when moving files. Localize feedback messages (thanks to Markus Moser for the germen translation)

Options
    • -33
    • +34
    ./move.tcl
  2. … 3 more files in changeset.
Tuesday 09 May 2017
2:03 pm

antoniop

Remove debugging comment

Options
    • -4
    • +3
    ./copy.tcl
2:01 pm

antoniop

Use name and title for the copy, rather than name as title and file_upload_name as name. This will make so copied files will have also the same title as the original when this was renamed.

Try conserving file extension in the name when adding the suffix

Options
    • -6
    • +6
    ./copy-oracle.xql
    • -6
    • +6
    ./copy-postgresql.xql
    • -9
    • +15
    ./copy.tcl
12:07 pm

antoniop

Localize untranslated messages in the copy file-storage script (thanks to Markus Moser for the german translation)

Options
    • -2
    • +2
    ./copy.tcl
  2. … 3 more files in changeset.
Wednesday 03 May 2017
8:18 pm

antoniop

Use a lazy but feasible check to decide if we have buttons for copy in the file storage

Options
    • -3
    • +6
    ./file.tcl
    • -3
    • +7
    ./folder-chunk.tcl
Tuesday 25 Apr 2017
8:08 pm

antoniop

Fix hiding of delete and move buttons. For move I resolved using the

delete permission as a criteria, because otherwise one should ensure

also the availability of a suitable destination, which must be writable

and in none of the object's subtrees. Complicated and costly to execute everytime.

Options
    • -6
    • +5
    ./file.tcl
    • -4
    • +12
    ./folder-chunk.tcl
Friday 21 Apr 2017
10:00 pm

gustafn

Fix spelling errors

Options
    • -1
    • +1
    ./download-zip.tcl
    • -1
    • +1
    ./admin/rss-subscr-ae.adp
    • -1
    • +1
    ./doc/design.adp
    • -1
    • +1
    ./doc/design.html
  5. … 9 more files in changeset.
7:14 pm

antoniop

Allow copy of files/folders into the same folder of the original content. This is done by appending a numerical suffix to the name.

It required modifying copy stored procedures so they could accept a different name and title for the copy.

I have also removed redundant package definition in oracle code that was immediately overridden afterwards.

Options
    • -5
    • +9
    ./copy-oracle.xql
    • -4
    • +8
    ./copy-postgresql.xql
    • -2
    • +18
    ./copy.tcl
  4. … 10 more files in changeset.
Wednesday 19 Apr 2017
8:15 pm

antoniop

Add move and copy buttons only when available folders for these actions exist

Options
    • -8
    • +16
    ./file.tcl
    • -4
    • +12
    ./folder-chunk.tcl
Tuesday 11 Apr 2017
7:52 am

antoniop

Hide file-storage actions that are not allowed for the user. (receives analogous modifications on Learn@WU)

Options
    • -13
    • +33
    ./file.tcl
    • -33
    • +42
    ./folder-chunk.tcl
7:20 am

antoniop

Use standard file-storage delete api, as extlink one seems to require extra sql stored procedures (which don't seem necessary to me)

Options
    • -3
    • +5
    ./simple-delete.tcl
Monday 27 Mar 2017
12:44 pm

gustafn

Improve robustness of "file delete" operations

Options
    • -5
    • +5
    ./download-zip.tcl
    • -3
    • +3
    ./file-add.tcl
    • -4
    • +4
    ./folder-zip-add.tcl
    • -1
    • +1
    ./admin/rss-subscr-del.tcl
  5. … 16 more files in changeset.
Saturday 04 Feb 2017
3:13 pm

gustafn

- replace "<include ... />" by "<include ... >", since adp parser in

AOLserver and NaviServer passes "/" as argument to the adp-include.

Options
    • -1
    • +1
    ./permissions.adp
  2. … 14 more files in changeset.
Thursday 02 Feb 2017
4:15 pm

gustafn

- tighten page contracts

Options
    • -2
    • +2
    ./copy.tcl
    • -2
    • +2
    ./folder-chunk.tcl
    • -2
    • +2
    ./move.tcl
  4. … 2 more files in changeset.
Wednesday 18 Jan 2017
8:50 am

gustafn

- make boolean tests in .adp files more uniform

Options
    • -2
    • +2
    ./file.adp
    • -1
    • +1
    ./folder-chunk.adp
    • -1
    • +1
    ./folder-delete.adp
    • -2
    • +2
    ./simple.adp
  5. … 1 more file in changeset.
Sunday 27 Nov 2016
1:19 pm

gustafn

Some more Tcl cleanup

- use curly brackes to enable byte code compilation

- don't use "[expr ...]" when not needed

- prefer "incr i -1" over "set i [expr {$i - 1}] "

Options
    • -2
    • +2
    ./file-add.tcl
  2. … 15 more files in changeset.
Tuesday 08 Nov 2016
12:04 pm

gustafn

- remove dead code: form n_past_days_form is nowhere used, probably some legacy

Options
    • -3
    • +3
    ./folder-chunk.tcl
    • -12
    • +8
    ./index.adp
    • -25
    • +2
    ./index.tcl
Saturday 08 Oct 2016
10:35 am

gustafn

- provide image dimensions

Options
    • -2
    • +2
    ./folder-chunk.tcl
  2. … 2 more files in changeset.