• last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Move custom calendar widget javascript implementation out of the core.js and into a separate file

In core/maintained packages, this widget is used only by template::widget::textdate (which in turn is used nowhere). For this widget, we can include the relevant code on-demand.

Direct usages found in unsupported packages have been adapted by adding the extra requirement on the fly.

It is unclear if we should keep maintaining a calendar widget in our codebase, however, as the current one still works (kudos to the original author), we do not deprecate it for the time being.

It is also true that a custom widget provides a way to customize the look and feel of date fields, which is otherwise completely delegated to the browser.

Various packages, including the core, provide custom css styling for the current widget.

  1. … 17 more files in changeset.
Replace custom calendar widget implementation with native HTML5 fields

  1. … 1 more file in changeset.
add explicit casts to all max_n_rels with value null to increase readability and to ease function disambiguation

  1. … 8 more files in changeset.
Deprecate value_if_exists proc, replace occurrences with plain tcl idioms

    • -3
    • +3
    ./www/admin/ecommerce/invoice-payment.tcl
    • -1
    • +1
    ./www/ecommerce/checkout-one-form-2.tcl
    • -3
    • +3
    ./www/manage/ecommerce/invoice-payment.tcl
  1. … 17 more files in changeset.
Replace some deprecated idioms

Whitespace cleanup

  1. … 2 more files in changeset.
Deprecate exists_and_equals and replace its occurrences

    • -3
    • +3
    ./www/admin/ecommerce/invoice-payment.tcl
    • -3
    • +3
    ./www/manage/ecommerce/invoice-payment.tcl
  1. … 2 more files in changeset.
removed obsolete flag -include_bio of acs_user::get

  1. … 3 more files in changeset.
improve testcases by removing useless expr commands

  1. … 17 more files in changeset.
improve rowcount expressions

    • -1
    • +1
    ./www/ecommerce/participant-change.adp
  1. … 35 more files in changeset.
minor changes for consistency

  1. … 1 more file in changeset.
Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

    • -2
    • +2
    ./www/admin/process-purchase-course.tcl
    • -3
    • +3
    ./www/admin/ecommerce/invoice-payment.tcl
    • -3
    • +3
    ./www/manage/ecommerce/invoice-payment.tcl
  1. … 464 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

    • -2
    • +2
    ./www/admin/process-purchase-course.tcl
    • -3
    • +3
    ./www/admin/ecommerce/invoice-payment.tcl
    • -3
    • +3
    ./www/manage/ecommerce/invoice-payment.tcl
  1. … 215 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 203 more files in changeset.
Fix typos

  1. … 148 more files in changeset.
Fix typos

    • -1
    • +1
    ./catalog/dotlrn-ecommerce.en_US.ISO-8859-1.xml
  1. … 21 more files in changeset.
Fix typos (info exist -> info exists)

  1. … 19 more files in changeset.
Fix typos

    • -4
    • +4
    ./catalog/dotlrn-ecommerce.en_US.ISO-8859-1.xml
    • -2
    • +2
    ./www/ecommerce/application-request.tcl
    • -1
    • +1
    ./www/manage/ecommerce/items-add-2.tcl
  1. … 61 more files in changeset.
Fix more typos

    • -1
    • +1
    ./catalog/dotlrn-ecommerce.en_US.ISO-8859-1.xml
  1. … 82 more files in changeset.
Fix typos

  1. … 52 more files in changeset.
Use consistently ad_script_abort after ad_return_error.

    • -2
    • +2
    ./www/admin/ecommerce/items-return-4.tcl
    • -1
    • +2
    ./www/admin/ecommerce/items-void-2.tcl
    • -2
    • +2
    ./www/manage/ecommerce/items-return-4.tcl
    • -1
    • +3
    ./www/manage/ecommerce/items-void-2.tcl
  1. … 28 more files in changeset.
add ad_script_abort after connection-closing commands to make termination intent explicit

    • -2
    • +1
    ./www/admin/ecommerce/items-return-2.tcl
    • -2
    • +1
    ./www/admin/ecommerce/items-return-3.tcl
    • -2
    • +1
    ./www/admin/ecommerce/items-return-4.tcl
    • -2
    • +1
    ./www/manage/ecommerce/items-return-2.tcl
    • -2
    • +1
    ./www/manage/ecommerce/items-return-3.tcl
    • -2
    • +1
    ./www/manage/ecommerce/items-return-4.tcl
  1. … 23 more files in changeset.
add required ad_script_abort after ad_returnredirect

    • -2
    • +3
    ./www/admin/process-group-purchase.tcl
  1. … 7 more files in changeset.
normalize boolean expressions in ADP files

  1. … 24 more files in changeset.
- remove backup file

Add support for section and course admins that are not pacakge admins

    • -0
    • +66
    ./www/manage/add-course-admin.tcl
    • -0
    • +21
    ./www/manage/application-approve.tcl
    • -0
    • +21
    ./www/manage/application-reject.tcl
    • -0
    • +7
    ./www/manage/application-view.adp
    • -0
    • +16
    ./www/manage/application-view.tcl
    • -0
    • +5
    ./www/manage/applications.adp
    • -0
    • +91
    ./www/manage/applications.tcl
    • -0
    • +6
    ./www/manage/course-add-edit.adp
    • -0
    • +237
    ./www/manage/course-add-edit.tcl
    • -0
    • +35
    ./www/manage/course-add-edit.xql
    • -0
    • +14
    ./www/manage/course-admins.adp
    • -0
    • +31
    ./www/manage/course-admins.tcl
    • -0
    • +5
    ./www/manage/course-attribute-add.adp
    • -0
    • +48
    ./www/manage/course-attribute-add.tcl
    • -0
    • +27
    ./www/manage/course-attributes-delete.tcl
  1. … 123 more files in changeset.
Use course_id to key course links

Fix bulk reject. Use acs_rel api instead of dotlrn api

Support no registration classes. Support section administrators

Setu application groups