• last updated 8 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Small improvements:

- use "string is space" instead of trimming the string and checking if empty, at least 2x faster on development, wherever we don't need the trimmed value

- modernize leftover foreach trick with lassign

  1. … 6 more files in changeset.
Deprecate template::util::is_true, implemented as a simple string command oneliner since 2015 and inline occurrences

  1. … 33 more files in changeset.
Generalized ADP compilation caching, simplified handling of ad_init

Generalized adp-compilation caching

* since the result of ADP compilation can depend on the icon set

(and maybe more factors in the future), and the icon set

can be switched freely, either one needs more ADP compilation

at runtime (page rendering time) or caching had to be generalized.

* generalization of caching leads to better scalability, and

since the number of icon sets concurrently active at one

site is limited, this option seems favorable.

* The only potential incompatibility might be from installations

doing "manual" incantations of "template::adp_init" followed by

direct calls of the stub. The only packages (out of the 365

packages in CVS) effected by this are "diagram" and

"workflow". Both have been fixed in the repository. This

incantation can be simplified as followed.

Simplified handling of adp_init

* old:

template::adp_init adp $file_stub

template::code::adp::$file_stub

* new

[template::adp_init adp $file_stub]

Bumped version to 5.10.1d8

  1. … 3 more files in changeset.
improve spelling

  1. … 2 more files in changeset.
improve safety of SQL queries

  1. … 3 more files in changeset.
Reduce divergency between oracle and postgres codebase

  1. … 5 more files in changeset.
Make api public, as this might be called in adp files from other packages

Fix long standing regression

After https://cvs.openacs.org/changelog/OpenACS?cs=MAIN%3Adaveb%3A20080908165252, in template::list::write_csv we started looping through the list "elements", rather than the "display_elements". This prevents specifying different sets of columns to be returned depending on the "-formats" and "-selected_format" options in template::list::create. Many thanks to Oasi Software that customized this proc a long time ago, so that I could realize where the problem was.

Whitespace changes

Add minimal proc doc. Fixes 'documentation__check_proc_doc' test case

make procs public, since these have to be called from pages of other packages

  1. … 1 more file in changeset.
make end of options explicit

  1. … 42 more files in changeset.
improve spelling: move closer to the linux documentation recommendations

  1. … 34 more files in changeset.
Rename template_tag proc to comply with OpenACS naming convention, create deprecated wrapper, massage variable juggling (use an absolutely namespaced variable instead of a namespace-sensitive one)

  1. … 4 more files in changeset.
Rename string_truncate and string_truncate_middle to comply with OpenACS naming convention, create deprecated wrappers, replace occurrences

As string_truncate_middle was defined in xotcl-request-monitor, bring it to acs-tcl instead

  1. … 11 more files in changeset.
Fix regression on template list

Deprecate exists_and_not_null proc as it does not comply with openacs naming convention and can be replaced with plain tcl idioms

  1. … 3 more files in changeset.
Deprecate exists_and_equals and replace its occurrences

  1. … 1 more file in changeset.
improve spelling

  1. … 15 more files in changeset.
implemented suggestion #3412 (many thanks to Rainer Bachleitner)

support different delimiters in template::list::write_csv.

Replace ad_decode idiom

  1. … 1 more file in changeset.
made value retrival for parameters "DefaultDimensionalStyle" and "DefaultListFilterStyle" theme aware

  1. … 1 more file in changeset.
improve capitalization and wording in comments

  1. … 6 more files in changeset.
Fix parameter names in proc doc

  1. … 2 more files in changeset.
Fix parameter name in proc documentation

prefer built-in ns_dbquotevalue over DoubleApos

  1. … 3 more files in changeset.
Whitespace changes + add editor hints

  1. … 26 more files in changeset.
Remove superflous parentheses

  1. … 29 more files in changeset.
Simplify code: set defaults for proc parameters, which are de facto optional, avoiding unnecesary existence checks.

  1. … 2 more files in changeset.
Use the actual tag name when retrieving its parameter, otherwise it would cause a missleading error message

  1. … 2 more files in changeset.