• last updated 6 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Form widget attributes reform:

- consolidate the logics to merge tag attributes coming from the adp and the tcl definitions of widgets into a private api

- change the previous behavior of having attributes coming from the adp (aka the tag_attributes argument) take over attributes coming from the element

See https://openacs.org/forums/message-view?message_id=5799349

  1. … 6 more files in changeset.
Update api to streamline idiom

Deprecate template::form::export, superseded by export_vars

Deprecate template::util::is_true, implemented as a simple string command oneliner since 2015 and inline occurrences

  1. … 33 more files in changeset.
Generalized ADP compilation caching, simplified handling of ad_init

Generalized adp-compilation caching

* since the result of ADP compilation can depend on the icon set

(and maybe more factors in the future), and the icon set

can be switched freely, either one needs more ADP compilation

at runtime (page rendering time) or caching had to be generalized.

* generalization of caching leads to better scalability, and

since the number of icon sets concurrently active at one

site is limited, this option seems favorable.

* The only potential incompatibility might be from installations

doing "manual" incantations of "template::adp_init" followed by

direct calls of the stub. The only packages (out of the 365

packages in CVS) effected by this are "diagram" and

"workflow". Both have been fixed in the repository. This

incantation can be simplified as followed.

Simplified handling of adp_init

* old:

template::adp_init adp $file_stub


* new

[template::adp_init adp $file_stub]

Bumped version to 5.10.1d8

  1. … 3 more files in changeset.
make end of options explicit

  1. … 42 more files in changeset.
Deprecate "form" proc, as it doesn't comply with naming convention

Try to address issue reported by Michael Aram: export variables sooner, when the uplevel they come from is still well known, rather than later in the rendering, when this could not be so trivial (e.g. in OO code)

  1. … 1 more file in changeset.
Greatly reduce complexity of code required to support -export flag for ad_form:

instead of juggle variables around to mimick export_vars, just set -export flag

value as a form property, then use the real export_vars on it later when form

is rendered. This will support all current features (e.g. :multiple, :sign, :array)

more reliably and reduce code duplication.

  1. … 1 more file in changeset.
improve spelling

  1. … 15 more files in changeset.
Whitespace changes

Fix duplicate wording

simplyfy expressions, remove useless file

  1. … 3 more files in changeset.
fix example in documentation and small code cleanup

  1. … 4 more files in changeset.
remove dead code

improve spelling

  1. … 7 more files in changeset.
Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 475 more files in changeset.
make spelling more uniform

  1. … 5 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 71 more files in changeset.
Prefer lappend over concat for appending lists (lappend modifies the variable 'in place')

  1. … 1 more file in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7834 more files in changeset.
Update documentation so best practice is suggested

- add log entry, when listener is automatically registered

- automatically convert on* event registrations passed to formtemplate into event listener

Introduced missing ad_library statement. Normalized overall library description.

  1. … 21 more files in changeset.
improve demo example: www/doc/demo/form.tcl

- add second validator

- protect against runtime errors from duplicate user_ids

  1. … 1 more file in changeset.
- use ad_log for two more warnings

- improve warning message

- fix comparison for actions (this is not a boolean test)

- prefer ns_quotehtml over ad_quotehtml

  1. … 36 more files in changeset.