• last updated 12 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Make api public, complies with acs-api-browser.graph__bad_calls automated test

  1. … 4 more files in changeset.
moved filters into namespace and made these consistently private

  1. … 1 more file in changeset.
Brace 'expr' + Prefer 'lassign' over 'set' when assigning multiple variables with list values

Rework variable assignment (set -> lassign) + Whitespace changes

  1. … 2 more files in changeset.
add ad_script_abort after ad_returnredirect to make termination intent explicit

  1. … 48 more files in changeset.
Protect against potential XSS vectors

replace catch by ad_try

merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7834 more files in changeset.
Introduced missing ad_library statement. Normalized overall library description.

  1. … 21 more files in changeset.
- prefer ns_quotehtml over ad_quotehtml

  1. … 36 more files in changeset.
- add editor hints to keep spaces/tabs in the furture more consistent

  1. … 754 more files in changeset.
- template::resource_path: new function to generalize access to

acs-templating's resource files

- add resource_dir (db) / ResourceDir (package parameter of subsite)

to allow for usage of them specific (adp) resources while preserving

existing semantics

  1. … 14 more files in changeset.
- remove globals for errorInfo/errorCode and use namespace qualifiers instead

  1. … 12 more files in changeset.
Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

  1. … 2547 more files in changeset.
- use $::acs::rootdir rather than [acs_root_dir] or [get_server_root]

  1. … 14 more files in changeset.
- normalize string expressions

  1. … 12 more files in changeset.
- simplify various wierd ways to set the variable ::template::parse_level

  1. … 5 more files in changeset.
Normalizing string comparison operations into tcl 8.4 operations, enabling byte-code compilation for expressions and many conditionals

  1. … 367 more files in changeset.
add proc doc to a bunch of procs, declare some things with explicit namespaces rather than in namespace eval, make some public things private

  1. … 25 more files in changeset.
all TCL's clock clicks always with the -milliseconds option. The TCL manual

explicitly states that without this switch the return result is platform

dependant. The OpenACS code works at the millisecond granulartiy and silently

assumes that 1 millisecond equals 1000 clicks which is not necessarily true.

I used this shell script to automatize the replacing:

#!/bin/bash

for file in `grep -lsr "\[clock clicks\]" /web/openacs-head/packages/ `; do

echo "repairing $file"

sed "s/\[clock clicks\]/\[clock clicks -milliseconds\]/g" $file > fout

mv fout $file

done

And then grepped for

grep -r "expr.*clock clicks" /web/openacs-head/packages/

to manually remove the divisions by 1000.

  1. … 10 more files in changeset.
make some Notices either warnings or debug and made them more descriptive by generally including the proc name as well bug #1032

  1. … 74 more files in changeset.
Started I18N work (Together with Lars)

Added namespace eval $namespace calls to each file in the tcl dir.

Rooted out some hardcoded text, replaced it with respective calls to

the i18n text catalog text function.

Shuffled around proc creation and calling, so that everything works properly.

  1. … 25 more files in changeset.
add a space

modified the wizard to be nlevel deep. also added more doc. wizard is also modified by Brad Duell

  1. … 1 more file in changeset.
Rolling back patch #239, because #238 didn't work

Applied patch #239

About 60 more ad_procs in acs-templating now have doc strings; still more to go

  1. … 8 more files in changeset.

1. Changed a lot of package info files to fix problems ...

2. Added Vinod's bboard patch

3. Rationalized party e-mail checking by putting a "before insert or update"

trigger on the table that lower-cases email (this was already done by the

party.new() func but at least one update missed this). Got rid of all

"lower(email) = " and "upper(email) = " checks and just made all use the

db email column directly and lower-cased Tcl vars. In this way the index

on the email column is always and consistently used without needing to

define functional indexes on the column (an EE feature for Oracle).

4. Rationalized naming of a couple of workflows and fixed a glossary PG bug

where apparently its workflow got overwritten by one from the CMS at some

point in time.

5. Made the .cmp/.dat/.frm filters in the template code usable though not

very beautiful nor exactly correct. But with practice you can use them

to debug pages in the packages/* hierarchy. I also turned these off by

default as there's no need to run these filters on a production site!

6. Performed minor surgery on templating, including adding a new

"ad_return_exception_template" that allows you to return a templated

error page and aborts the script.

7. ??? probably but I think this covers most stuff.

  1. … 74 more files in changeset.
removed FILTER_ABORT code from template::forward as the RP doesn't support the catching of the FILTER_ABORT error as a control structure. Removal of the FILTER_ABORT code allows code to be executed after a template::forward command

  1. … 2 more files in changeset.
cleanup

tested and fixed the template query db api

  1. … 26 more files in changeset.