• last updated 9 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Cleanup debug statements, re-instate safe tmpfile check

Fixes acs-templating automated tests

minor changes: fixed typo, ease debugging, ...

  1. … 3 more files in changeset.
Gracefully reject invalid lists supplied as a file triple instead of failing and log the occurrence

improve spelling

  1. … 4 more files in changeset.
Make also sure the tmpfile from the widget exists beforehand, when validating: we don't want users to "explore" our tmpdir with bogus values that just look sane

  1. … 2 more files in changeset.
Improve doc

Revert to previous template::widget::file behavior of accepting input in a form of a list of 3 elements (e.g. without a .tmpfile in the request), but introduce validation so that we enforce all widget values to be in the proper format and the files to be "safe"

  1. … 4 more files in changeset.
Test the behavior of the file-storage when a malicious user would try to store a pre-existing file on the server as its own

The fix for the file-storage is a simple validation to make sure that the tmpfile exists, however, for the generic case of the file widget, we cannot trust the tmpfile value when this was not generated by the server. This will probably cause regression when one wants to show a "preview" of a form, to be continued.

  1. … 2 more files in changeset.
Incorporate feedback from downstream penetration tests:

do not skip basic validation in the file widget when a tmpfile is not found in the request.

make end of options explicit

  1. … 42 more files in changeset.
Check for already converted form variables on 'template::util::file_transform'. This can happen, for instance, during the 'preview' action of a form.

Add some AOLserver compatibility code for 'template::util::file_transform'

Modify 'template::util::file_transform' to manage multiple files

  1. … 1 more file in changeset.
Bug fix: avoid confusion between command argument and option, when argument starts with "-"

  1. … 81 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7834 more files in changeset.
Introduced missing ad_library statement. Normalized overall library description.

  1. … 21 more files in changeset.
- add editor hints to keep spaces/tabs in the furture more consistent

  1. … 754 more files in changeset.
Normalizing string comparison operations into tcl 8.4 operations, enabling byte-code compilation for expressions and many conditionals

  1. … 367 more files in changeset.
All templating procs now have at least minimal documentation.

  1. … 8 more files in changeset.
Reverting all changes done previously as the procedure is now in acs-content-repository

  1. … 2 more files in changeset.
removed proc for checking for existing filenames and added it to the party proc as it is party specific

removed get_file_extension, replace with file command

Added procedure to store a file for a party_id

Refactored template::data::transform::file so the mechanism that gets .tmpfile and .content-type from the page form can be reused.

Started I18N work (Together with Lars)

Added namespace eval $namespace calls to each file in the tcl dir.

Rooted out some hardcoded text, replaced it with respective calls to

the i18n text catalog text function.

Shuffled around proc creation and calling, so that everything works properly.

  1. … 25 more files in changeset.
About 60 more ad_procs in acs-templating now have doc strings; still more to go

  1. … 8 more files in changeset.
Added stuff to form processing including the new form builder type

"file" which is a bit cleaner than the widget-only kludge which existed


  1. … 11 more files in changeset.