• last updated 25 mins ago
Constraints: committers
Constraints: files
Constraints: dates
Move custom calendar widget javascript implementation out of the core.js and into a separate file

In core/maintained packages, this widget is used only by template::widget::textdate (which in turn is used nowhere). For this widget, we can include the relevant code on-demand.

Direct usages found in unsupported packages have been adapted by adding the extra requirement on the fly.

It is unclear if we should keep maintaining a calendar widget in our codebase, however, as the current one still works (kudos to the original author), we do not deprecate it for the time being.

It is also true that a custom widget provides a way to customize the look and feel of date fields, which is otherwise completely delegated to the browser.

Various packages, including the core, provide custom css styling for the current widget.

  1. … 2 more files in changeset.
Form widget attributes reform:

- consolidate the logics to merge tag attributes coming from the adp and the tcl definitions of widgets into a private api

- change the previous behavior of having attributes coming from the adp (aka the tag_attributes argument) take over attributes coming from the element

See https://openacs.org/forums/message-view?message_id=5799349

  1. … 6 more files in changeset.
Reinstate behavior:

behave again that when a date fragment value is empty, the padded value will also be empty and not a sequence of zeroes

See https://openacs.org/forums/message-view?message_id=5798230

improve strictness of tests

  1. … 8 more files in changeset.
ensure year has only 4 digits

  1. … 3 more files in changeset.
There is no year zero in the Gregorian calendar

Minor modernization

- use atomic stack operations to reduce locks and avoid race conditions

- improve spelling

- break overlong lines

- better align comments with actual code

  1. … 2 more files in changeset.
improve spelling

  1. … 2 more files in changeset.
Fix order in expression

Port of downstream modification: apply trimming of zeros to all fields in advance

This allows to treat fields as real numbers without the need to trim case by case. One can also reduce dependency to api and just use plain tcl expressions to evaluate conditions

Port of downstream HTML5 date and time form widgets by Günter Ernst

These widgets provide a better and more consistent user experience and client-side validation across multiple platforms. They should in time become the preferred alternative for dates and time for template forms.

  1. … 2 more files in changeset.
Comment noop result of a 18 years old typo, add remarks

Arrays might or not have been a better choice for the date object, however, such decision happened very long ago and it has worked good enough... cleanup concerning remarks

Whitespace change

Review concerning remark: the algotirhm is indeed correct, assuming the year is expressed in the Gregorian calendar

Replace deprecated idiom

Uniform documentation formatting and indentation, add missing documentation

make end of options explicit

  1. … 42 more files in changeset.
improve spelling: move closer to the linux documentation recommendations

  1. … 34 more files in changeset.
improve spelling

  1. … 3 more files in changeset.
fix issue #3392, improve testability via paramterization of clock value, add regression test, improve Tcl sanity

  1. … 1 more file in changeset.
Deprecate unamusing template::util::date::now_min_interval_plus_hour

Fix obvious bug; Note that the proc is still buggy, as it blindly incr's the hour value, even if it is 23 o'clock

improve spelling

  1. … 13 more files in changeset.
Trailing whitespace cleanup

Replace deprecated proc template::util::leadingPad with ad_pad

improve spelling

  1. … 15 more files in changeset.
improve capitalization and wording in comments

  1. … 6 more files in changeset.
Deprecate 'template::util::leadingPad' in favor of the new and more general 'ad_pad'

Fix proc and contract doc elements, so they are properly parsed by apidoc::api_*_documentation.

- @cvs_id -> @cvs-id

- @version -> @cvs-id

- @creation_date -> @creation-date

- @date -> @creation-date

- Different variations of $Id$

- Remove wrong @param entry

- Fix typos

  1. … 368 more files in changeset.