OpenACS / openacs-4 / packages / acs-tcl / tcl

utilities-procs.tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 1
Total Committers: 33
Last Commit: 13 Sep
Commits this week: 1
Total Lines of Code (LoC): 4,658
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 15 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 11 Sep
8:11 am

gustafn

merge with missing files

Options
    • -0
    • +0
    ./utilities-procs.tcl
  2. … 1464 more files in changeset.
Tuesday 03 Sep
5:37 pm

gustafn

merge from oacs-5-10

Options
    • -1307
    • +1701
    ./utilities-procs.tcl
  2. … 8099 more files in changeset.
Thursday 29 Aug
10:37 am

gustafn

Use "ns_mkdtemp" when available to create temporary directories

Options
    • -13
    • +27
    ./utilities-procs.tcl
  2. … 1 more file in changeset.
Tuesday 27 Aug
3:01 pm

gustafn

align nameing with 'resource_info_procs'

Options
    • -4
    • +4
    ./utilities-procs.tcl
  2. … 7 more files in changeset.
Tuesday 20 Aug
3:58 pm

gustafn

Fix potential problems when calling polymorphic SQL functions from Tcl

Some functions are defined in the database with the same number of

arguments but different types, e.g., first argument "package_key"

(type text) or "package_id" (type integer). This is fine from the SQL

standpoint, but when calling from Tcl via bind-vars

(e.g. ":package_id"), everything is passed as a string, and

potentially, the wrong function is called.

Now, all the automatically generated subs are generated with casts,

when the integer based variant must be called.

Some examples:

Before:

set s [ns_pg_bind 0or1row $__DB {select apm__set_value(:package_id,:parameter_name,:attr_value)}]

set s [ns_pg_bind 0or1row $__DB {select apm__get_value(:package_id,:parameter_name)}]

Now:

set s [ns_pg_bind 0or1row $__DB {select apm__set_value(CAST(:package_id AS integer),:parameter_name,:attr_value)}]

set s [ns_pg_bind 0or1row $__DB {select apm__get_value(CAST(:package_id AS integer),:parameter_name)}]

- bumped version number to 5.10.1b11

Options
    • -2
    • +2
    ./utilities-procs.tcl
  2. … 2 more files in changeset.
Saturday 17 Aug
7:07 pm

gustafn

More resource-info updates:

- fixed wrong and inconsistent naming of dict members (many thanks to Sebastian Scheder for figuring this out)

- removed duplicated slashes in resource paths

- fixed incorrect paths when CDN is used

- simplified handling of cspMaps

- added test checking consistency of resource-info dicts

Options
    • -10
    • +10
    ./utilities-procs.tcl
  2. … 10 more files in changeset.
Tuesday 13 Aug
4:33 pm

gustafn

::util::resources::resource_info_procs: function to improve roustness of fetching of resource info procs

bumped version number to 5.10.1b10

Options
    • -3
    • +43
    ./utilities-procs.tcl
  2. … 1 more file in changeset.
Monday 12 Aug
3:03 pm

gustafn

added link to snyk advisor (bumped version to 5.10.1b9)

Options
    • -2
    • +6
    ./utilities-procs.tcl
  2. … 3 more files in changeset.
Sunday 11 Aug
8:22 am

gustafn

Further simplify handling of resource_info specs

- Added convenience function "::util::resources::register_urns" to

register all URNs with CSP handling provided by a package (denoted

by its top level namespace)

- made parameter "version" in "check-installed" include optional

- bumped version number to 5.10.1b8

Options
    • -1
    • +25
    ./utilities-procs.tcl
  2. … 2 more files in changeset.
Monday 05 Aug
4:42 pm

gustafn

factored out vulerability check to make it reusable

- New proc ::util::resources::check_vulnerability

- bumped verison number to 5.10.1b7

Options
    • -1
    • +40
    ./utilities-procs.tcl
  2. … 3 more files in changeset.
Tuesday 30 Jul
7:53 pm

gustafn

improved spelling

Options
    • -2
    • +2
    ./utilities-procs.tcl
  2. … 4 more files in changeset.
7:49 pm

gustafn

added comment

Options
    • -1
    • +8
    ./utilities-procs.tcl
1:22 pm

antoniop

Latest released NaviServer still requires for servers using SNI that the -hostname flag is specified with ns_http, while it seems that in latest code we can omit it

The wrapper utility already takes care of this

Options
    • -3
    • +3
    ./utilities-procs.tcl
12:25 pm

gustafn

Ease management of external js packages to automate admin tasks

- provide explicit information about optional package paramters

- make these accessible from site-wide admin pages

- provide information, how the configuration of the version number happend

- improve design of site-wide admin pages with action items

- further streamlined handling of external js packages

Options
    • -3
    • +4
    ./utilities-procs.tcl
  2. … 18 more files in changeset.
Monday 29 Jul
2:01 pm

gustafn

js-libraries: improved naming of variables

Changed name "installedVersion" to "configuredVersion", since

the former might lead to the impression, that it refers only

to the locally installed version. Instead, this refers as well

to a CDN version (when available)

Options
    • -14
    • +14
    ./utilities-procs.tcl
  2. … 18 more files in changeset.
Sunday 28 Jul
7:41 pm

gustafn

js-libraries: removed variable "resourceUrl"

The variable "resourceUrl" was always used in a single branch but set

for all branches before. To ease maintenance and simplify

comprehension, it was removed.

Options
    • -2
    • +1
    ./utilities-procs.tcl
  2. … 10 more files in changeset.
6:27 pm

gustafn

In essence, this change renames "version_dir" to "version_segment" as

well as "versionDir" to "versionSegment" to reflect the fact, that

this variable does not denote a directory, but a part of the path

appended to path "resourceDir".

Options
    • -27
    • +27
    ./utilities-procs.tcl
  2. … 4 more files in changeset.
2:15 pm

gustafn

various small fixes for js libraries

- fixed page contract in case a non-default version is downloaded

- provide always an argument "-version" to resource_info procs

- obtain current version number always via resource_info.installedVersion

(it refers to CDN and locally installed version)

- pass always versionDir via resource_info to ::util::resources::download

- always obtain version_dir from resource_info

Options
    • -25
    • +19
    ./utilities-procs.tcl
  2. … 25 more files in changeset.
Thursday 25 Jul
4:24 pm

gustafn

Improved resource information for external libraries

- added vulnerability check for a particular version

- centralized URL generation for cdnjs URLS (will reduce maintenance work, when external URL changes)

- improve behavior when running without an Internet connection

Options
    • -11
    • +47
    ./utilities-procs.tcl
  2. … 11 more files in changeset.
Wednesday 24 Jul
3:25 pm

gustafn

Include available version number and vulnerability check on swa pages

This eases the use of external JavaScript libraries by adding

the available version number and a link for vulnerability checks

on the site-wide admin pages (when this information is available)

- bumped version number to 5.10.1b6

Options
    • -11
    • +54
    ./utilities-procs.tcl
  2. … 3 more files in changeset.
Tuesday 23 Jul
2:49 pm

gustafn

Made download helper more modular and added support for a version_API

Options
    • -10
    • +34
    ./utilities-procs.tcl
Wednesday 10 Jul
3:12 pm

gustafn

a protocol relative URL is not complete, but it can be understood as external

Options
    • -8
    • +21
    ./utilities-procs.tcl
  2. … 1 more file in changeset.
2:42 pm

antoniop

Make util_complete_url_p recognize protocl-relative URLs

Options
    • -9
    • +5
    ./utilities-procs.tcl
Monday 08 Jul
4:10 pm

antoniop

After further consideration, ns_absoluteurl is actually sufficient to preform location header completion on its own and does not need a wrapper utility

Options
    • -46
    • +1
    ./utilities-procs.tcl
  2. … 3 more files in changeset.
3:20 pm

gustafn

Streamline terminology with other occurrences in OpenACS and NaviServer/AOLserver

- the term "location" is usually used in OpenACS/NaviServer/AOLserver for the

part of a URL before the path (i.e. SCHEME+HOST+PORT)

- the new function util::absolute_url is a value-added version of NaviServer's "ns_absoluteurl".

This is now documented with its differences, and aligned with its terminology

Options
    • -29
    • +29
    ./utilities-procs.tcl
  2. … 2 more files in changeset.
Friday 05 Jul
3:43 pm

antoniop

Introduce util::complete_location

This utility is meant to require the value of the Location header in an HTTP response to be completed vith the host coming from a reference complete URL, which is normally that of the redirected request.

It is intended for use in the context of HTTP client APIs, where we want to handle server responses affected by https://www.rfc-editor.org/rfc/rfc7231#section-7.1.2

Options
    • -1
    • +46
    ./utilities-procs.tcl
  2. … 3 more files in changeset.
Monday 03 Jun
7:47 pm

gustafn

Added support for relative redirects

RFC 2616 requires an absolute URI in the "Location" header field. So

if someone calls "ns_returnredirect /", NaviServer transforms it on

the fly into an absolute URL by prefixing it with the location

(e.g. https://openacs.org/). NaviServer (and OpenACS) has some complex

code to compute the location value, especially when virtual servers

are involved (or for "host-node mapped" subsites in OpenACS). The

situation is further complicated when running behind a reverse proxy

and/or in a containerized environment. In such cases, the location is

computed from the "host" request header field, which must be

validated, otherwise an attacker could hijack a session and redirect

it to a spoofed site.

The situation changed 10 years ago (June 2014) with the introduction

of RFC 7231, which allows relative redirects (see

https://www.rfc-editor.org/rfc/rfc7231#section-7.1.2). Using relative

redirects greatly simplifies configuration and closes the attack

vector using the host header field. RFC 7231 has been superseded by

RFC 9110 (June 2022), which also supports relative redirects via the

"location" response header field (see

https://www.rfc-editor.org/rfc/rfc9110#field.location).

Since OpenACS prefixed always the URL with a location, when it

encounters are relative URL in a "ad_returnredirect", this change

makes use of the new feature of NaviServer 5.

Make sure to use a current version of NaviServer, where the support

was added recently.

Options
    • -4
    • +10
    ./utilities-procs.tcl
  2. … 1 more file in changeset.
Friday 31 May
2:00 pm

gustafn

improved spelling

Options
    • -4
    • +4
    ./utilities-procs.tcl
  2. … 5 more files in changeset.
Friday 05 Apr
10:28 am

gustafn

Improved readability of configuration parameter "parameterSecret"

- Switched to camelCase for better readabilty and uniformity

- NaviServer configuration parameters are case insensitive, so no danger for backward compatibility

Options
    • -2
    • +2
    ./utilities-procs.tcl
  2. … 5 more files in changeset.
Monday 26 Feb
12:09 pm

gustafn

Rework of util::which

The new version deals now correctly with absolute paths,

where just the extensions are added, and it is checked

whether the program is executable.

Extended regression test to deal with optional and required

external dependencies. Missing optional external programs

produce warnings.

Options
    • -30
    • +46
    ./utilities-procs.tcl
  2. … 1 more file in changeset.