• last updated 3 hours ago
Constraints: committers
Constraints: files
Constraints: dates
improve listing of test coverage

  1. … 1 more file in changeset.
make listing of tested procs more complete

  1. … 18 more files in changeset.
Add 'xml_doc_get_first_node', 'randomRange', 'whos_online::user_invisible_p' and 'site_node::get_url_from_object_id' to the list of covered procs of different testcases

  1. … 2 more files in changeset.
- fix caching bug, when urls are retrieved via object_ids, and packages are unmounted

- make code more robust

- extend regression tests

  1. … 1 more file in changeset.
whitespace cleanup

  1. … 11 more files in changeset.
fix name of tested procs

make tested API calls explicit

  1. … 2 more files in changeset.
Trim whitespace

fix site-node test in regression test

don't use per-request caching, since we migh shoot in our own foot

interrupt cache_transaction to achieve desired semantics

allow in a few cases empty node_ids for method "get_url" as it is used by current OpenACS

  1. … 1 more file in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7834 more files in changeset.
- add editor hints to keep spaces/tabs in the furture more consistent

  1. … 754 more files in changeset.
Removed the old test case #3 (and renumbered the remaining ones). The test

checked that updating the cache without sync'ing the children didn't change

the results returned by the get procedure. However the lazy caching code by

Malte changed the semantics of get to automatically load the cache with

children if you try to get the node_id of a node with kids. This is a good

thing, actually, since the update cache w/o sync'ing kids exists to make the

cache update quick. But it did break the test checking explicitly for the old


It would be nice, however, if people, after writing new code and noticing that

tests break, would actually sit down and determine if the test or code is wrong

and take appropriate action.

Because I just spent two full hours tracking this down and verifying that the

new semantics invalidate the old test code in a reasonable way, and I'm not the

author of the new code.

  1. … 1 more file in changeset.
Added categories to the automated test(s).

  1. … 10 more files in changeset.
populate site-nodes-cache by resolving urls in tcl instead of using the slow plsql

  1. … 6 more files in changeset.
Cleaned up site_node::closest_ancestor_package and test case

Deprecated site_node_closest_ancestor_package

  1. … 1 more file in changeset.
- test for site_node::closest_ancestor_package

    • -0
    • +74