OpenACS / openacs-4 / packages / acs-tcl / tcl

security-procs.tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 1
Total Committers: 23
Last Commit: 10:53
Commits this week: 1
Total Lines of Code (LoC): 3,710
Net change in LoC this week: 6

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 12 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 25 May 2023
11:19 am

antoniop

Document public api

Options
    • -6
    • +9
    ./security-procs.tcl
Tuesday 23 May 2023
2:36 pm

gustafn

refactor login cookie handling

The old code required repeated execption handlers.

Now, these exception handlers are on one place, and

users of sec_login_read_cookie can rely that a dict

is returned

Options
    • -97
    • +81
    ./security-procs.tcl
Friday 19 May 2023
2:14 pm

gustafn

added exception handler for sec_login_get_external_registry

This is necessary for cases, where no login cookie exists

Options
    • -7
    • +13
    ./security-procs.tcl
Monday 15 May 2023
1:08 am

gustafn

don't assume, the oauth package is installed

Options
    • -14
    • +16
    ./security-procs.tcl
  2. … 3 more files in changeset.
12:18 am

gustafn

External identity provider reform (part 3)

- logout from external identity provider, if logged in via it

- extend default login page via ADP include, when external

identity providers are configured.

Options
    • -2
    • +53
    ./security-procs.tcl
  2. … 5 more files in changeset.
Sunday 14 May 2023
1:09 pm

gustafn

External identity provider reform (part 2)

Use the external identity provider for refresh of logins. When a user

is logged in via an external identity provider, use the same identity

provider for a refresh when it expires. The expiration time is

controlled via the classical OpenACS parameters.

Note that in general, the same user might be authenticated via a

classical OpenACS authority (e.g. local authority) and/or via an

external one (e.g. Microsoft Identity Platform (Azure) or GitHub).

For single-sign-ons, when the token is still valid, the redirect to

the external identity provider does not mean necessarily that the use

is shown the external identity provider's login page.

Options
    • -21
    • +76
    ./security-procs.tcl
  2. … 3 more files in changeset.
Wednesday 03 May 2023
2:39 pm

gustafn

whitespace changes

Options
    • -5
    • +5
    ./security-procs.tcl
2:35 pm

gustafn

Added preliminary support for secondary registries (e.g., MS Azure via oauth2)

- When login happened via external registry, the logout should happen

there as well.

- let "sec_login_read_cookie" return a dict instead of a list

(eases future extension)

- bump version number to 5.10.1d31

Options
    • -26
    • +73
    ./security-procs.tcl
  2. … 1 more file in changeset.
Monday 27 Feb 2023
6:57 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./security-procs.tcl
  2. … 4 more files in changeset.
6:47 pm

gustafn

security::safe_tmpfile_p: fix false positive under macOS

This fixes as well the regression test for acs-tcl under macOS

Options
    • -5
    • +6
    ./security-procs.tcl
6:31 pm

gustafn

provide an API for single-token signed values

Options
    • -1
    • +40
    ./security-procs.tcl
12:37 pm

antoniop

Consider failures obtaining the token as failure to verify the value and report into the log file

Options
    • -2
    • +8
    ./security-procs.tcl
Monday 20 Feb 2023
4:48 pm

gustafn

reduce verbosity

Options
    • -2
    • +2
    ./security-procs.tcl
Sunday 27 Nov 2022
6:55 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./security-procs.tcl
  2. … 9 more files in changeset.
Saturday 26 Nov 2022
5:47 pm

gustafn

Make use of new API "ad_mktmpdir" and "ad_opentmpfile" instead of "ad_tmpnam"

Options
    • -2
    • +2
    ./security-procs.tcl
  2. … 7 more files in changeset.
Sunday 13 Nov 2022
10:37 am

gustafn

Minor CSP improvements

- provided ability to add "trusted-types" and "require-trusted-types-for"

directives (Trusted Types policies)

For details, see:

https://blog.bitsrc.io/trusted-types-api-for-javascript-dom-security-fcdafa927e73

- changed default "object-src" from 'self' to 'none'

Options
    • -5
    • +8
    ./security-procs.tcl
6:11 am

raulr

improve Oracle compatibility

Options
    • -8
    • +18
    ./security-procs.tcl
Monday 12 Sep 2022
6:04 pm

antoniop

Document public api

Options
    • -2
    • +4
    ./security-procs.tcl
Monday 29 Aug 2022
12:34 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./security-procs.tcl
  2. … 6 more files in changeset.
Friday 26 Aug 2022
2:06 pm

antoniop

tmpfile page contract filter reform:

do not allow acs-subsite TmpDir parameter to define where the tmpfolder is located anymore. This MUST be the one configured in the server-wide configuration. Tmpfiles cannot be in a subfolder of the tmpfolder, they MUST be direct children instead. A tmpfile MUST exist beforehand and be owned, be readable and writable by the user running the nsd process. This complies with the definition of a tmpfile by AolServer/NaviServer when they are created to store content coming from a file upload.

Options
    • -36
    • +2
    ./security-procs.tcl
  2. … 4 more files in changeset.
Thursday 25 Aug 2022
5:37 pm

antoniop

Reimplement ad_page_contract_filter_proc_tmpfile using security::safe_tmpfile_p

Some of the features implemented by this filter have been ported into the api, namely the possibility to fetch the valid temp folders from the subsite TmpDir parameter and the possibility to relax the check and allow also files deeper in the tmpfolder hierachy.

Notably, the hardcoded tmpfolders "/var/tmp" and "/tmp" have NOT been ported. One should configure these values via the many available options. security::safe_tmpfile_p is also more restrictive when a file exists, because it checks for ownership and read and write permissions on the file.

Options
    • -3
    • +42
    ./security-procs.tcl
  2. … 2 more files in changeset.
2:37 pm

antoniop

Add must_exist flag to enforce a safe tmpfile to already exist

Options
    • -4
    • +9
    ./security-procs.tcl
  2. … 2 more files in changeset.
1:25 pm

antoniop

Introduce security::safe_tmpfile_p checking whether a file belongs to the configured tmpfolder and respects other constraints

The plan is to use it to improve input validations

Options
    • -1
    • +54
    ./security-procs.tcl
  2. … 2 more files in changeset.
Wednesday 24 Aug 2022
4:51 pm

gustafn

Deactivated script-dynamic again

activating "script-dynamic" for script-src prevents resources as the following from loading

<script type="text/javascript" src="/resources/xowiki/bootstrap-treeview/1.2.0/bootstrap-treeview.min.js" nonce="F8843D5CD542FB1CDB4C94C5D13C4E5ECC2E1DCA">

Options
    • -2
    • +2
    ./security-procs.tcl
Tuesday 23 Aug 2022
8:44 pm

gustafn

Properly escape "<" and ">" in api-doc documentation.

Since all documentation is rendered via HTML, the characters

"<" and ">" have to be HTML-quoted, otherwise strange things

(omission, unintended renderings) might occur.

E.g. the sentence

Define an interface between a page and an

ADP <include> similar to the page_contract.

was rendered as

Define an interface between a page and an

ADP similar to the page_contract.

which is incorrect.

Options
    • -5
    • +9
    ./security-procs.tcl
  2. … 13 more files in changeset.
Sunday 26 Jun 2022
9:37 pm

gustafn

security::cookie_name: since this is used in acs-lang, it has to be public

Options
    • -2
    • +2
    ./security-procs.tcl
  2. … 4 more files in changeset.
Tuesday 07 Jun 2022
10:18 am

gustafn

flipping of session_id apparently works without keeping track of the old session_id, so there is no need of keeping track of it

Options
    • -7
    • +3
    ./security-procs.tcl
Sunday 03 Apr 2022
10:46 am

gustafn

reduce verbosity

Options
    • -2
    • +2
    ./security-procs.tcl
Friday 01 Apr 2022
3:54 pm

gustafn

new API call ::security::csp::add_static_resource_header

The API call set the CSP rule on the current connection for a static

resource depending on the MIME type.

# Sample definition for custom CSP rules for static files in the

# OpenACS configuration file.

#

# ns_section ns/server/$server/acs {

# ...

# ns_param StaticCSP {

# image/svg+xml "script-src 'none'"

# }

# ...

# }

bump version number of acs-tcl to 5.10.1d13

Options
    • -2
    • +22
    ./security-procs.tcl
  2. … 3 more files in changeset.
Tuesday 29 Mar 2022
11:25 am

gustafn

New feature: cookie namespaces

So far, all OpenACS versions used "ad_" as a prefix for cookies (such

as ad_login, ad_session_id, ...). In certain situations this can lead

to confusion, since cookies are managed by browsers via domain names,

and running multiple OpenACS instances in the same domain will cause

overwriting of such cookies by these instances. The can happen e.g.

when running multiple instances on the same machine, or using

port-forwarding to virtual machines/containers, using reverse proxies,

etc. Note that the cookie overwriting problem does not exist for

host-node-mapped subsites, since host-node-mapping depends on domain

names.

One could consider using the port in the cookie name (as

sometimes noted as an option), but this would not work, in case the

same server should be reachable over multiple ports.

Therefore, one can now specify a "CookieNamespace" in the OpenACS

configuration file, which is per default "ad_", which is sufficient

for the majority of installations. In cases, where it is needed, a

different CookieNamespace can now be configured.

To manage the cookie names internally, OpenACS provides a new API call

security::cookie_name to derive the namespaced cookie name from a stem.

Snippet of the OpenACS configuration file for setting the CookieNamespace

#---------------------------------------------------------------------

# OpenACS specific settings (per server)

#---------------------------------------------------------------------

ns_section ns/server/${server}/acs {

ns_param CookieNamespace "ad_"

...

}

Options
    • -29
    • +52
    ./security-procs.tcl
  2. … 2 more files in changeset.