OpenACS / openacs-4 / packages / acs-tcl / tcl

http-client-procs.tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 5
Last Commit: 01 Oct
Commits this week: 0
Total Lines of Code (LoC): 1,984
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 17 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 03 Sep
5:37 pm

gustafn

merge from oacs-5-10

Options
    • -668
    • +671
    ./http-client-procs.tcl
  2. … 8099 more files in changeset.
Tuesday 30 Jul
1:27 pm

antoniop

Use ns_parseurl to validate the URL and to determine the hostname

Options
    • -5
    • +7
    ./http-client-procs.tcl
Wednesday 17 Jul
2:34 pm

gustafn

Fixes for regression test: util_http_json_encoding

This change corrects 2 bugs, causing the regression test to fail under certain circumstances:

1) use for test location [::acs::test::url] instead of [ad_url]

The call [::acs::test::url] should be used for all tests in the regression tests and avoids

problems with wrong URLs when running e.g. in a container

2) When running on a setup with self-signed certificates, the curl requests require a "-k"

flag to be passed. Otherwise, the regression test fails.

Options
    • -10
    • +11
    ./http-client-procs.tcl
  2. … 1 more file in changeset.
Monday 08 Jul
4:10 pm

antoniop

After further consideration, ns_absoluteurl is actually sufficient to preform location header completion on its own and does not need a wrapper utility

Options
    • -3
    • +1
    ./http-client-procs.tcl
  2. … 3 more files in changeset.
3:20 pm

gustafn

Streamline terminology with other occurrences in OpenACS and NaviServer/AOLserver

- the term "location" is usually used in OpenACS/NaviServer/AOLserver for the

part of a URL before the path (i.e. SCHEME+HOST+PORT)

- the new function util::absolute_url is a value-added version of NaviServer's "ns_absoluteurl".

This is now documented with its differences, and aligned with its terminology

Options
    • -3
    • +3
    ./http-client-procs.tcl
  2. … 2 more files in changeset.
Friday 05 Jul
3:43 pm

antoniop

Introduce util::complete_location

This utility is meant to require the value of the Location header in an HTTP response to be completed vith the host coming from a reference complete URL, which is normally that of the redirected request.

It is intended for use in the context of HTTP client APIs, where we want to handle server responses affected by https://www.rfc-editor.org/rfc/rfc7231#section-7.1.2

Options
    • -1
    • +9
    ./http-client-procs.tcl
  2. … 3 more files in changeset.
Sunday 25 Feb
5:13 pm

gustafn

Cleanup of external binaries: always use "util::which" to resolve binaries

Background: it is important to always use the same binaries of some

programs. This is important for security reasons, consistency, and

configurability (some operating systems have read-only file systems,

which might be on the path and should be avoided for some operations).

Options
    • -2
    • +2
    ./http-client-procs.tcl
  2. … 3 more files in changeset.
Friday 23 Jun 2023
2:39 pm

antoniop

Prefer ns_base64encode where we already require modern NaviServer

Options
    • -2
    • +2
    ./http-client-procs.tcl
Saturday 26 Nov 2022
5:47 pm

gustafn

Make use of new API "ad_mktmpdir" and "ad_opentmpfile" instead of "ad_tmpnam"

Options
    • -2
    • +2
    ./http-client-procs.tcl
  2. … 7 more files in changeset.
Thursday 01 Sep 2022
12:41 am

antoniop

Fix self-inflicted bug: one should indeed be able to specify the same form var multiple time, test the behavior for the future

Options
    • -17
    • +21
    ./http-client-procs.tcl
  2. … 2 more files in changeset.
Wednesday 31 Aug 2022
2:51 pm

antoniop

Extend util::http::post_payload and util::http::post to receive form varaibles also in dict form, update documentation

Options
    • -22
    • +58
    ./http-client-procs.tcl
12:18 pm

antoniop

Cleanup leftover arguments

Options
    • -8
    • +0
    ./http-client-procs.tcl
Thursday 25 Aug 2022
3:09 pm

antoniop

Factor the payload building behavior in util::http::post into its own proc, so that it can be reused elsewhere

Options
    • -69
    • +170
    ./http-client-procs.tcl
Tuesday 28 Jun 2022
2:24 pm

antoniop

Make api public

Options
    • -1
    • +1
    ./http-client-procs.tcl
Monday 02 Aug 2021
11:26 pm

gustafn

Reduce usage of ns_mktemp in OpenACS

ns_mktemp uses the deprecated old POSIX call mktemp(), which should

not be used anymore for security reasons (race between the name

creation and opening the file). This change removes several usages of

"ns_mktemp" from OpenACS and replaces it with calls to the

safe Tcl call "file tempfile ..." (introduced by Tcl 8.6).

Options
    • -4
    • +3
    ./http-client-procs.tcl
  2. … 7 more files in changeset.
Friday 12 Mar 2021
11:24 am

antoniop

Remove extra decoding ns_parsequery provides it already

Options
    • -2
    • +0
    ./http-client-procs.tcl
Thursday 11 Mar 2021
11:46 am

antoniop

Use naviserver api to parse URL variables

Options
    • -12
    • +5
    ./http-client-procs.tcl
  2. … 1 more file in changeset.
Thursday 14 Jan 2021
10:35 pm

gustafn

Revert to previous strategy of determining available subcommands.

Running the provided subcommand is dangerous, since the command might

have side effects, might require connections, etc.

The feature test for "ns_http run" was incorrect, since it was not

introduced with 4.99.15 (as the comment suggested), but already with

4.99.4 (2017)... but at this time, the command did not return a dict,

which is assumed in the http-client procs. One can use "ns_http stats"

as an indicator for this feature, which was introduced at the time

when "ns_http run" was starting to return dicts as results.

Provide a more precise name for the feature test of ns_http returning

dicts (naming the feature simply "ns_http" is not a good idea, since

the command could of course be used already before the feature change).

Options
    • -1
    • +1
    ./http-client-procs.tcl
  2. … 2 more files in changeset.
3:40 pm

antoniop

Do not improperly rely on apm_version_names_compare to check for NaviServer version number, use a more reliable capability check instead

Options
    • -9
    • +1
    ./http-client-procs.tcl
  2. … 1 more file in changeset.
Wednesday 13 Jan 2021
2:16 pm

antoniop

Keep supporting the previous proc signature, throwing a warning

Options
    • -0
    • +5
    ./http-client-procs.tcl
2:10 pm

antoniop

util::http should provide enough fallback via curl already without targeting specific Naviserver versions, use other fallbacks only when no implementation is available

Options
    • -2
    • +1
    ./http-client-procs.tcl
  2. … 1 more file in changeset.
1:39 pm

hectorr

Fix webserver version check using 'apm_version_names_compare' for rc versions.

Between 4.99.6 and 4.99.20rc1, for example, 'apm_version_names_compare' will consider the latter to be the lowest.

As this is not the expected behavior for webserver version check, this patch just removes the rc part of the version before comparing in the few cases where this is done, and should be removed if the behavior changes in the future.

Options
    • -1
    • +4
    ./http-client-procs.tcl
  2. … 1 more file in changeset.
12:25 pm

antoniop

Fix version check

Options
    • -1
    • +1
    ./http-client-procs.tcl
12:00 pm

antoniop

Tear down a lot of boilerplate used to support native HTTP api on Naviserver versions < 4.99.15, which will now fallback to curl

Options
    • -245
    • +40
    ./http-client-procs.tcl
  2. … 1 more file in changeset.
11:09 am

antoniop

Doc formatting changes

Options
    • -330
    • +406
    ./http-client-procs.tcl
10:44 am

antoniop

Avoid markup in documentation

Options
    • -72
    • +69
    ./http-client-procs.tcl
10:37 am

antoniop

Reduce people expectations

Options
    • -1
    • +2
    ./http-client-procs.tcl
Wednesday 28 Oct 2020
4:39 pm

hectorr

Prefer 'namespace which' over 'info commands', as it is faster (on local tests, around 2x) and returns a single value. Many thanks to Nathan Coulter.

Options
    • -5
    • +5
    ./http-client-procs.tcl
  2. … 58 more files in changeset.
Tuesday 11 Aug 2020
10:44 pm

gustafn

improve spelling

Options
    • -5
    • +5
    ./http-client-procs.tcl
  2. … 4 more files in changeset.
Thursday 06 Aug 2020
3:09 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./http-client-procs.tcl
  2. … 6 more files in changeset.