apm-install-procs.tcl

  • last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
reduce frequent small SQL queries and streamline code

  1. … 2 more files in changeset.
Make so that upon package deletion, also the leftover site nodes are deleted (if they do no have children nodes)

  1. … 1 more file in changeset.
Performance improvement: make "apm_version_names_compare" faster by a factor of ~100

The function "apm_version_names_compare" is called relatively often

and issues an SQL query. The function is stable (returns always the

same results for the same input) and called with only a few different

input values. By using acs::per_thread_cache the performance improves

from 265 microseconds to 2 microseconds; by using the per-tread cache

the operation scales better since it is fully lock-free (once cached).

Make a bunch of apm procs public, as they are used in 'acs-admin'.

Could be worth considering moving the ones used only in 'acs-admin' to that package, and making them private again, leaving public only those who may be useful to other packages/applications (i.e. CI/CD logic).

  1. … 4 more files in changeset.
mark private functions as private

  1. … 9 more files in changeset.
Make api public, complies with acs-api-browser.graph__bad_calls automated test

  1. … 3 more files in changeset.
make end of options explicit

  1. … 42 more files in changeset.
Prefer 'namespace which' over 'info commands', as it is faster (on local tests, around 2x) and returns a single value. Many thanks to Nathan Coulter.

  1. … 58 more files in changeset.
Skip upgrade attempts when the package is installed and disabled

Avoid skipping datamodel scripts during initial installation

ignore upgrade attempt for disabled package

introduced "ad_file" as a means to avoid unexpected tilde substitution in file names

  1. … 50 more files in changeset.
improve spelling: move closer to the linux documentation recommendations

  1. … 34 more files in changeset.
whitespace changes

  1. … 2 more files in changeset.
improve spelling

  1. … 15 more files in changeset.
reduce verbosity

improve spelling

  1. … 14 more files in changeset.
Replace ad_decode idioms

  1. … 2 more files in changeset.
Bring files on oacs-5-10 in sync with HEAD

  1. … 162 more files in changeset.
Replace/remove deprecated proc 'db_null' and update doc accordingly

  1. … 33 more files in changeset.
prefer https over http on request going to openacs.org

  1. … 3 more files in changeset.
fix typo

  1. … 1 more file in changeset.
improve spelling

  1. … 6 more files in changeset.
Fix parameter names and descriptions in proc doc

  1. … 3 more files in changeset.
Fix misleading and uncoherent 'apm_data_model_scripts_find' proc documentation

improve spelling

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 475 more files in changeset.
Prefer 'lappend' to 'set ... concat' for appending elements to lists + Whitespace changes

  1. … 3 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 71 more files in changeset.
improve documentation

  1. … 10 more files in changeset.