• last updated 16 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Fixes for Oracle 19c recursive query

Oracle has a slightly differnt syntax for CTEs require arguments, keyword "recursive" is not allowed.

This fixes the following error during initial installation:

nsoracle.c:1367:OracleSelect: error in `OCIStmtExecute ()': ORA-00905: missing keyword


with recursive !>>>!object_hierarchy as (

select object_type, supertype

from acs_object_types

where object_type = coalesce(:object_type, (select object_type

from acs_objects

where object_id = :object_id))

union all

select t.object_type, t.supertype

from acs_object_types t,

object_hierarchy s

where t.object_type = s.supertype


select distinct callback, callback_type as type

from subsite_callbacks

where event_type = :event_type

and object_type in (select object_type from object_hierarchy)

  1. … 2 more files in changeset.
Rename subsite_callback to comply with OpenACS naming convention, reduce divergency between oracle and postgres codebase

  1. … 2 more files in changeset.
whitespace changes

  1. … 9 more files in changeset.
Fix typos

Fix typos

  1. … 10 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7834 more files in changeset.
Fix spelling errors

  1. … 8 more files in changeset.
.xql overhaul:

- removed misleading sql-statements from db_* calls, which were

ignored due .xql files

- removed bug where same query name was used in a single proc

with different intended sql queries, but the same was picked

up from the .xql file due to the name

- removed multiple entries of same query name from .xql files

(e.g. the entry "package_create_attribute_list.select_type_info" was

7 (!!!) times in a single .xql file)

- removed redundant queries for unsupported versions of the dbms

- added missing xql entries for db-backends, where other db-specific

queries exists (e.g. added an entry to -oracle.xql, where an entry

existed in -postgres.xql)

  1. … 70 more files in changeset.
- add editor hints to keep spaces/tabs in the furture more consistent

  1. … 754 more files in changeset.
Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

  1. … 2547 more files in changeset.
- replace mulitple "lindex" operations by "lassign"

  1. … 7 more files in changeset.
1. First shot at sitewide admin ui for global parameters. You can edit them

from the sitewide admin page list that was previously built for packages

that have a sitewide-admin subdirectory. Package is now displayed for

either the existence of sitewide-admin or global parameters.

2. Did something I'd wanted to do for some time. When Nima added the

parameter_changed callback in acs subsite, he actually *moved* the

set_value call there. I've changed it so it more rationally sets the

value in the parameters page, then calls the parameter_changed callback.

3. Invented a global_parameter_changed callback that works as the regular

parameter_changed callback. This was necessary to avoid breaking existing

uses of parameter_changed.

More testing is required before release (which will hopefully happen

tomorrow, Sunday Apr 4).

  1. … 5 more files in changeset.
Normalizing string comparison operations into tcl 8.4 operations, enabling byte-code compilation for expressions and many conditionals

  1. … 367 more files in changeset.
Nick accidently broke the callback contract for paramter_changed by adding

documentation. The check code allows anything if there are only two

elements in the ad_proc list (i.e. name doc) but if three elements

are there (name doc empty_body) the body must be "-" or "" (not the

empty list).

Bug stomp: added documentation to acs core procs that had no docs.

  1. … 2 more files in changeset.
Merged acs-core oacs-5-2 (currently 5.2.3) -> HEAD.


1. Bump acs-core package version numbers to 5.3.0d1

2. Would be nice to do a test install, wouldn't it?

  1. … 721 more files in changeset.
Added subsite::url callback and hooked it into o.vuh

  1. … 1 more file in changeset.
Commit on behalf of Nima. Support for a callback on parameter change

  1. … 1 more file in changeset.
OpenACS 4.x

  1. … 1321 more files in changeset.
Initial revision

    • -0
    • +76
  1. … 1321 more files in changeset.