OpenACS / openacs-4 / packages / acs-bootstrap-installer / tcl

40-db-query-dispatcher-procs.tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 15
Last Commit: 13 Dec
Commits this week: 0
Total Lines of Code (LoC): 1,007
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 11 Sep
8:11 am

gustafn

merge with missing files

Options
    • -0
    • +0
    ./40-db-query-dispatcher-procs.tcl
  2. … 1464 more files in changeset.
Tuesday 03 Sep
5:37 pm

gustafn

merge from oacs-5-10

Options
    • -293
    • +398
    ./40-db-query-dispatcher-procs.tcl
  2. … 8099 more files in changeset.
Friday 05 Apr
10:41 am

gustafn

clean dirty editor buffer

Options
    • -1
    • +1
    ./40-db-query-dispatcher-procs.tcl
10:39 am

gustafn

improved spelling

Options
    • -2
    • +3
    ./40-db-query-dispatcher-procs.tcl
  2. … 3 more files in changeset.
Monday 01 Mar 2021
1:05 pm

gustafn

improve comments

Options
    • -4
    • +9
    ./40-db-query-dispatcher-procs.tcl
11:43 am

gustafn

reduce the number of locks (nsv-accesses) for OACS_FULLQUERIES by a factor of 3 when NaviServer is used.

OACS_FULLQUERIES is one of the 3 most intensively locked nsv arrays for

busy implementation

Options
    • -20
    • +52
    ./40-db-query-dispatcher-procs.tcl
11:11 am

gustafn

reduce visibility of internal functions

Options
    • -4
    • +4
    ./40-db-query-dispatcher-procs.tcl
10:26 am

gustafn

move function db_current_rdbms to acs-bootstrap installer to improve code locality

Options
    • -2
    • +6
    ./40-db-query-dispatcher-procs.tcl
  2. … 1 more file in changeset.
10:19 am

gustafn

Cleanup of low-level DB-interace: use dict instead of list with fixed positions

VS: ----------------------------------------------------------------------

Options
    • -28
    • +48
    ./40-db-query-dispatcher-procs.tcl
  2. … 3 more files in changeset.
Saturday 27 Feb 2021
6:48 pm

gustafn

Fix for issue #3442 to support range types in .xql files

PostgreSQL supports range types since 9.5. When using range types,

square braces have to be used in SQL statements. Since OpenACS uses

always Tcl substitution in .xql files, and OpenACS does NOT allow

backslash substitution in these files, square brackets could not be

escaped and therefore not be used in .xql files so far. This change

allows now a developer to deactivate the substitution by passing

e.g. "-subst none" to the db_* command using the .xql file. Valid

values for "-subst" are "all", "none", "vars", and "commands", default

is "all" which is exactly the behavior of before. Therefore, this

change is fully backward compatible.

Options
    • -3
    • +19
    ./40-db-query-dispatcher-procs.tcl
  2. … 3 more files in changeset.
Wednesday 24 Feb 2021
5:00 am

gustafn

reduce the size of the public interface

Options
    • -10
    • +10
    ./40-db-query-dispatcher-procs.tcl
  2. … 2 more files in changeset.
Monday 22 Feb 2021
6:13 pm

gustafn

whitespace changes: break overlong lines

Options
    • -150
    • +176
    ./40-db-query-dispatcher-procs.tcl
5:56 pm

gustafn

make clear from the name that db_qd_prepare_queryfile_content is intended to be used in different packages

Options
    • -7
    • +6
    ./40-db-query-dispatcher-procs.tcl
  2. … 2 more files in changeset.
3:14 pm

antoniop

Make proc public (it is used in a test is acs-tcl)

Complies with acs-api-browser.callgraph__bad_calls

Options
    • -2
    • +2
    ./40-db-query-dispatcher-procs.tcl
3:05 pm

antoniop

Whitespace cleanup

Options
    • -69
    • +69
    ./40-db-query-dispatcher-procs.tcl
Sunday 14 Feb 2021
10:08 pm

gustafn

improve spelling

Options
    • -10
    • +12
    ./40-db-query-dispatcher-procs.tcl
  2. … 4 more files in changeset.
Wednesday 28 Oct 2020
4:39 pm

hectorr

Prefer 'namespace which' over 'info commands', as it is faster (on local tests, around 2x) and returns a single value. Many thanks to Nathan Coulter.

Options
    • -4
    • +4
    ./40-db-query-dispatcher-procs.tcl
  2. … 58 more files in changeset.
Monday 13 Jul 2020
2:02 pm

gustafn

introduced "ad_file" as a means to avoid unexpected tilde substitution in file names

Options
    • -2
    • +2
    ./40-db-query-dispatcher-procs.tcl
  2. … 50 more files in changeset.
Wednesday 14 Aug 2019
9:13 am

gustafn

improve spelling

Options
    • -2
    • +2
    ./40-db-query-dispatcher-procs.tcl
  2. … 3 more files in changeset.
Wednesday 11 Jul 2018
9:31 am

gustafn

improve spelling

Options
    • -3
    • +3
    ./40-db-query-dispatcher-procs.tcl
  2. … 2 more files in changeset.
Monday 21 May 2018
6:40 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./40-db-query-dispatcher-procs.tcl
  2. … 8 more files in changeset.
Wednesday 09 May 2018
5:33 pm

hectorr

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

Options
    • -2
    • +2
    ./40-db-query-dispatcher-procs.tcl
  2. … 475 more files in changeset.
12:37 am

hectorr

Rework variable assigning loops (set -> lassign) + Whitespace changes

Options
    • -3
    • +2
    ./40-db-query-dispatcher-procs.tcl
  2. … 13 more files in changeset.
Wednesday 25 Apr 2018
9:23 pm

hectorr

Prefer '{}' to '[list]' when creating empty lists

Options
    • -2
    • +2
    ./40-db-query-dispatcher-procs.tcl
  2. … 71 more files in changeset.
Tuesday 08 Aug 2017
1:47 am

gustafn

merged changes from the oacs-5-9 branch and resolved conflicts

Options
    • -16
    • +16
    ./40-db-query-dispatcher-procs.tcl
  2. … 7834 more files in changeset.
Saturday 22 Apr 2017
8:26 pm

gustafn

Fix spelling errors, use OpenACS

Options
    • -3
    • +3
    ./40-db-query-dispatcher-procs.tcl
  2. … 6 more files in changeset.
Monday 13 Feb 2017
4:21 pm

gustafn

- modernize tcl

Options
    • -13
    • +3
    ./40-db-query-dispatcher-procs.tcl
Friday 25 Mar 2016
10:56 am

gustafn

- add missing doc string

Options
    • -1
    • +3
    ./40-db-query-dispatcher-procs.tcl
Monday 17 Aug 2015
6:43 pm

gustafn

ad_proc reform:

- use nsf::proc for defining ad_procs, when nsf::proc is available

- nsf::proc is part of the environment of XOTcl2 and provides

an efficient, C-implemented argument parser that can replace

the scripted *__arg_parser of OpenACS.

- The benefits are performance and reduced memory consumption.

* Simple functions (where the calling overhead was a large

part of the execution times can become several times faster

(e.g. db_name is 3x faster, cookie handling is 2x faster),

for functions with much db-activities the percentage will

be less.

* The memory consumption (RSS) of a site like OpenACS.org

is reduced by about 15%.

NEW (with nsf::proc)

::ad_get_cookie x: 10.93 microseconds per iteration

::ad_get_cookie ad_session_id: 21.95 microseconds per iteration

::dt_systime: 24.89 microseconds per iteration

::db_name: 8.70 microseconds per iteration

::db_string dbqd.null.g "select version() from dual": 316.66 microseconds per iteration

::ad_convert_to_html "hello world": 102.29 microseconds per iteration

OLD (without nsf::proc)

::ad_get_cookie x: 19.42 microseconds per iteration

::ad_get_cookie ad_session_id: 30.10 microseconds per iteration

::dt_systime: 27.55 microseconds per iteration

::db_name: 32.28 microseconds per iteration

::db_string dbqd.null.g "select version() from dual": 366.69 microseconds per iteration

::ad_convert_to_html "hello world": 160.51 microseconds per iteration

======================================================================

proc mtime cmd {set c 5000

set t [time [list time $cmd $c]];

regexp {^(-?[0-9]+) +} $t _ mS1;

set ms [expr {$mS1*1.0/$c}];

return "[format %6.2f $ms] microseconds per iteration"

}

set tests {

{::ad_get_cookie x} {::ad_get_cookie ad_session_id} {::dt_systime}

{::db_name} {::db_string dbqd.null.g "select version() from dual"}

{::ad_convert_to_html "hello world"}

}

foreach t $tests {append ::_ $t ": " [mtime $t] \n}

set ::_

======================================================================

Options
    • -2
    • +10
    ./40-db-query-dispatcher-procs.tcl
  2. … 9 more files in changeset.
Monday 27 Oct 2014
5:38 pm

victorg

Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

Options
    • -25
    • +41
    ./40-db-query-dispatcher-procs.tcl
  2. … 2547 more files in changeset.