• last updated 13 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Rework parameter check:

the way the if was construed would allow e.g.:

1. a value for EmailRegistrationConfirmationToUserP = 'nottrue' to pass the first if, but fail the second.

2. a value EmailRegistrationConfirmationToUserP = 'false' to be "true" in the first if, but not in the second

In fact, if EmailRegistrationConfirmationToUserP should be a boolean, there is no need to further check the other parameters and variables in the second if. This change is not 100% equivalent to the previous code, but makes it clear that EmailRegistrationConfirmationToUserP should be interpreted as a boolean and fixes these inconsistencies.

Make clear that parameters come from the same subsite

Fix signature of service contract implementation, that is defined with 3 and not 4 arguments, complete coverage of the auth_password contract local implementation

  1. … 1 more file in changeset.
Bring the implementation of the "Search" operation of the "auth_search" service contract in line with the operation's definition by correcting the returned value ("username" instead of "user_id") and restricting the search to the local authority.

Streamline idiom: we are only interested in the user ids

  1. … 1 more file in changeset.
- Rework acs-api-browser.callgraph__bad_calls automated test so that acs-service-contract calling contract implementation is considered OK

- Reinstate authentication service contracts as private

- Move test authority implementation to acs-authentication to remove intra-package dependency

acs-api-browser.callgraph__bad_call still fails because proc acs-tcl.install::xml::action::create-user calls private acs-authentication.auth::local::registration::Register... to be continued

  1. … 3 more files in changeset.
Make api public, complies with acs-api-browser.graph__bad_calls automated test

  1. … 2 more files in changeset.
Make service contract implementation public

Complies with acs-api-browser.callgraph__bad_calls

pass authority_id to acs_user::get_by_username

improve spelling

  1. … 12 more files in changeset.
Exploit new api where appropriate

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 475 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 71 more files in changeset.
whitespace cleanup

  1. … 9 more files in changeset.
Use "ad_try" instead of "with_catch"

  1. … 5 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7834 more files in changeset.
simplify idiom

Remove (harmless) inconsistency in local authority service contract (many thanks to Günther Ernst)

- prefer empty sql statements over various forms of *SQL*

  1. … 1 more file in changeset.
- no need to use backslash for continuation between curly brackets

- improve readability of code

- modernize tcl

  1. … 8 more files in changeset.
- add editor hints to keep spaces/tabs in the furture more consistent

  1. … 754 more files in changeset.
- remove globals for errorInfo and use namespace qualifiers instead

  1. … 15 more files in changeset.
- fix for bug #3251 from Andrew Helsley

  1. … 6 more files in changeset.
Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

  1. … 2547 more files in changeset.
- make exists_and_not_null explicit

  1. … 6 more files in changeset.
Add missing search implementation procs

- replace ns_sendmail call with acs_mail_lite::send ones

- use ad_outgoing_sender for notifying of new registration instead of the new user email

- when notifying new registrations fall back to site-wide locale in case the email address to notify to doesn't belong to any user

Fix search service contract. We handle local specifically similar to all the other local handling in acs-authenticaton

  1. … 2 more files in changeset.
Add search service contract for acs-authenticaton. TIP#125

  1. … 5 more files in changeset.
Merged 5.3 to HEAD

  1. … 60 more files in changeset.